Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 12:21
    niemyjski synchronize #452
  • 12:21

    niemyjski on elastic7

    WIP - Added migration job to mi… (compare)

  • 11:34
    niemyjski labeled #462
  • 11:34
    niemyjski commented #462
  • 11:34
    niemyjski commented #461
  • 02:09
    kfj1688 opened #462
  • 01:42
    BrisWhite commented #461
  • Oct 22 13:52
    niemyjski labeled #461
  • Oct 22 13:52
    niemyjski commented #461
  • Oct 22 13:35
    niemyjski synchronize #452
  • Oct 22 13:35

    niemyjski on elastic7

    Moved migration job (compare)

  • Oct 22 12:32
    niemyjski synchronize #452
  • Oct 22 12:32

    niemyjski on elastic7

    Added migration job (compare)

  • Oct 22 12:09
    niemyjski synchronize #452
  • Oct 22 12:09

    niemyjski on elastic7

    Fixed tests (compare)

  • Oct 22 09:50
  • Oct 22 09:17
    xiaotiannet starred exceptionless/Exceptionless
  • Oct 22 07:04
  • Oct 22 07:01
  • Oct 22 06:15
    BrisWhite edited #461
Eric J. Smith
@ejsmith
sweet
Blake Niemyjski
@niemyjski
that will be sweet
good job!
Blake Niemyjski
@niemyjski
@ejsmith I wanted to give log stacks a nicer names
        if (!stack.SignatureInfo.ContainsKeyWithValue("Type", Event.KnownTypes.Log))
            return null;

        return new SummaryData { TemplateKey = "stack-log-summary", Data = new Dictionary<string, object> { { "Title", stack.Title } } };
but that has a wrench thrown into it now that you can have custom stack titles
I can’t just say this will always be set to the source...
I wanted to do something about the long stack titles
"template_key": "stack-log-summary",
"data": {
  "Title": "Exceptionless.Core.Plugins.EventProcessor.CheckForDuplicateReferenceIdPlugin"
}
guess we could still treat it as a source if it has a period in it?
Frank Ebersoll
@frankebersoll
ToddThomson/tsproject#86
Sander Rijken
@srijken
could there be a problem with extended data indexing?
oh.. lowercase
Blake Niemyjski
@niemyjski
@srijken what did you find?
good morning :)
@frankebersoll looking
Sander Rijken
@srijken
I have an added property FooBar
I have to search for data.foobar
data.FooBar doesn’t give results
Blake Niemyjski
@niemyjski
hmm.
we call too lower on it
maybe to normalize it
maybe we shouldn’t be
@ejsmith thoughts?
Sander Rijken
@srijken
in that case, call tolower on that part of the query as well?
Blake Niemyjski
@niemyjski
yeah
I guess we should eh
I’ll fix it
Blake Niemyjski
@niemyjski
pushing it to a branch with some other changes
will merge it in today
so question for you guys
For log stacks we set the title to the source which is the full type name in most cases… but you can also specify a custom stacking title too (not typical)...
so we have these ugly stack titles we could collapse but we aren’t 100% sure if they are a full type name..
so should I add a special check to see if it the title contains at least 1 period and there are no spaces
in any of the parts
like blah.xyz.blah would match
but blah. xyz.blah wouldn't
what are your thoughts
Eric J. Smith
@ejsmith
calling you Blake
Blake Niemyjski
@niemyjski
        // allow any single hour to have 10 times the monthly limit converted to hours
        //return (int)Math.Ceiling(organization.GetMaxEventsPerMonthWithBonus() / 30d * 0d);
        int eventsLeftInMonth = organization.GetMaxEventsPerMonthWithBonus() - organization.GetCurrentMonthlyTotal();
        if (eventsLeftInMonth < 0)
            return 0;

        var hoursLeftInMonth = (DateTime.UtcNow.EndOfMonth() - DateTime.UtcNow).TotalHours;
        if (hoursLeftInMonth < 1)
            return eventsLeftInMonth;

        return (int)Math.Ceiling(eventsLeftInMonth / hoursLeftInMonth * 10d);
new :)
Eric J. Smith
@ejsmith
nice
Blake Niemyjski
@niemyjski
not sure how our unit tests are going to work now
lol
since it’s a revolving period of time based on when the tests are running
lol
Eric J. Smith
@ejsmith
yeah, will have to figure something out for that.
or get rid of the tests.
Blake Niemyjski
@niemyjski
I got them working