Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Yoann Delouis
    @yDelouis
    Maybe, the plugins could return a list of AnnotationHandler. And we put them into the AnnotationsHanlders ourselves.
    Csaba Kozák
    @WonderCsabo
    i just wanted to write this down. :D
    Yoann Delouis
    @yDelouis
    Done and pushed.
    Csaba Kozák
    @WonderCsabo
    checking it now
    i see you removed the type parameter
    Yoann Delouis
    @yDelouis
    Yes, it is not needed.
    Csaba Kozák
    @WonderCsabo
    well, i think it is ugly to use a class without a type parameter
    you will even get a compilation warning for it
    for example if you declare List myList;
    so at least you should add <?>
    Yoann Delouis
    @yDelouis
    I think it doesn't bring information to add <?>.
    Between the two following, I prefer the first.
    • List myList;
    • List<?> myList;
    Csaba Kozák
    @WonderCsabo
    i do not !
    most IDEs will add a warning if you the the first
    there is also an inspection for it in IntelliJ, but it is turned off by default it seems
    Reports any uses of parameterized classes where the type parameters are omitted. Such raw uses of parameterized types are valid in Java, but defeat the purpose of using type parameters, and may mask bugs. This inspection mirrors the rawtypes warning of javac.
    i go to lunch, be back in an hour
    Yoann Delouis
    @yDelouis
    Ok, I revert my changes so.
    Yoann Delouis
    @yDelouis
    Done
    Csaba Kozák
    @WonderCsabo
    Thanks!
    Seems to be OK.
    On my list, only the JavaDoc is left. But i think the API is quiet self explanatory. I will write some JavDoc, but i want to focus on creating new features instead...
    I am OK to merge the branch into develop.
    Csaba Kozák
    @WonderCsabo
    This message was deleted
    This message was deleted
    Csaba Kozák
    @WonderCsabo
    @yDelouis are you here? :)
    Yoann Delouis
    @yDelouis
    Nope, I'm driving.
    Csaba Kozák
    @WonderCsabo
    Oops, do not text and drive.
    Csaba Kozák
    @WonderCsabo
    We brainstormed with @dodgex a little bit
    Kay-Uwe Janssen
    @dodgex
    hey there :D
    Csaba Kozák
    @WonderCsabo
    It would be nice to move the core plugin to a different artifact. The only problem is that handlers are tightly coupled with holders. We should separate them somohow. We could use delegate for everything which is not core holder thing. Then we should find a way to use these delegates, by not implementing them with the core holders, but adding them in a generic way.
    i would really love to see this happen.
    Csaba Kozák
    @WonderCsabo
    i was thinking about a method in Handler, which can add the delegete
    then store all the delegates in a map
    the handler could access its own delegate in the process method parameter, a new parameter
    it can work, but it is much painful then the current way
    so any suggestions on this are appreciated
    Kay-Uwe Janssen
    @dodgex
    I'd move the plugin api into something like an androidannotations-plugin-api artifact that the plugin only get those exposed classes (i know that they still could add the apt itself as dependency)
    for the delegate stuff i currently have no idea, and i'd like to finish the method injection PR before i think about that in detail.
    Csaba Kozák
    @WonderCsabo
    @dodgex i think creating another dependency for the plugin API is not needed
    but it could be done for sure
    but it would make things event more difficult
    AA was not desigend to handle plugins, in the first place
    OK, let's focus on your work
    and thanks!
    Csaba Kozák
    @WonderCsabo
    On the other hand, it would be quiet odd that EBeanHandler is in one artifact, the holder is in the other. I feel it is already a little bit odd.
    Kay-Uwe Janssen
    @dodgex
    i have a rough idea how this could be done, but i want to dig a bit into the related code if it is possible at all. and for now i don't know how to explain my idea in a good way :)
    but as mentioned i want to finish the method injection first. i hope i get it done today - at least to a feature complete state that is ready to be fully reviewed
    Csaba Kozák
    @WonderCsabo
    @dodgex no worries!