Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 28 13:31
    ctyytc starred fabric8io/kubernetes-client
  • Jan 28 13:04
    vrnsky starred fabric8io/kubernetes-client
  • Jan 28 10:01
    wjmwss starred fabric8io/kubernetes-client
  • Jan 28 05:05

    dependabot[bot] on maven

    (compare)

  • Jan 28 05:05
    dependabot[bot] commented #4799
  • Jan 28 05:05
    manusa closed #4799
  • Jan 28 05:05
    manusa commented #4799
  • Jan 28 05:04

    manusa on master

    chore: remove tentative entry f… (compare)

  • Jan 28 05:03

    manusa on master

    improve: generate crds in paral… (compare)

  • Jan 28 05:03
    manusa closed #4644
  • Jan 28 04:57
    manusa labeled #4803
  • Jan 28 04:57
    manusa opened #4803
  • Jan 27 17:12
    rdesgroppes edited #4797
  • Jan 27 17:12
    rdesgroppes edited #4797
  • Jan 27 15:35
    shawkins commented #4798
  • Jan 27 15:35
    shawkins assigned #4798
  • Jan 27 15:19
    Vlatombe commented #4802
  • Jan 27 15:17
    shawkins commented #4802
  • Jan 27 15:10
    MartijnStraatman edited #4800
  • Jan 27 14:46
    Vlatombe opened #4802
Rohan Kumar
@rohanKanojia
These all checks need to pass https://github.com/fabric8io/kubernetes-client/pull/3214/checks?check_run_id=2743626843
Ghost
@ghost~60b391476da03739847dc13e
no.
thank you rohan sir for your help.
I will build
Rohan Kumar
@rohanKanojia
:+1:, Please don't use sir . You can address everyone by their names :-)
Ghost
@ghost~60b391476da03739847dc13e

Test set: io.fabric8.kubernetes.client.internal.UtilsTest

Tests run: 20, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.947 s <<< FAILURE! - in io.fabric8.kubernetes.client.internal.UtilsTest
io.fabric8.kubernetes.client.internal.UtilsTest.testGetCommandPlatformPrefix Time elapsed: 0.031 s <<< ERROR!
java.lang.ExceptionInInitializerError
at io.fabric8.kubernetes.client.internal.UtilsTest.testGetCommandPlatformPrefix(UtilsTest.java:369)
Caused by: java.lang.StringIndexOutOfBoundsException: begin 0, end 3, length 2
at io.fabric8.kubernetes.client.internal.UtilsTest.testGetCommandPlatformPrefix(UtilsTest.java:369)
Rohan Kumar
@rohanKanojia
Do you have your branch somewhere which we can pull and check?
Ghost
@ghost~60b391476da03739847dc13e
https://github.com/ps-19/kubernetes-client i just installed it using
mvn clean install after cloning
Rohan Kumar
@rohanKanojia
You mean master branch?
Is it related to fabric8io/kubernetes-client#3214 ?
I see you closed this PR. Was it by accident?
Ghost
@ghost~60b391476da03739847dc13e
no i again forked file then cloned it and installed using CONTRIBUTION.md guidelines
i will submit another PR when it will work fine.
and deleted by previous forked file.
Ghost
@ghost~60b391476da03739847dc13e

[INFO] Running io.fabric8.kubernetes.client.dsl.internal.uploadable.PodUploadTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.88 s - in io.fabric8.kubernetes.client.dsl.internal.uploadable.PodUploadTest
[INFO] Running io.fabric8.kubernetes.client.dsl.internal.uploadable.PodUploadWebSocketListenerTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.246 s - in io.fabric8.kubernetes.client.dsl.internal.uploadable.PodUploadWebSocketLis
tenerTest
[INFO] Running io.fabric8.kubernetes.client.extended.leaderelection.LeaderElectorBuilderTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.477 s - in io.fabric8.kubernetes.client.extended.leaderelection.LeaderElectorBuilderT
est
[INFO] Running io.fabric8.kubernetes.client.extended.leaderelection.LeaderElectorTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.854 s <<< FAILURE! - in io.fabric8.kubernetes.client.ex
tended.leaderelection.LeaderElectorTest
[ERROR] io.fabric8.kubernetes.client.extended.leaderelection.LeaderElectorTest.loopInterruptedShouldShutdownExecutorService Time elapsed: 0.1 s <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
at io.fabric8.kubernetes.client.extended.leaderelection.LeaderElectorTest.loopInterruptedShouldShutdownExecutorService(LeaderElectorTest.java:195)

[INFO] Running io.fabric8.kubernetes.client.extended.leaderelection.resourcelock.ConfigMapLockTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.713 s - in io.fabric8.kubernetes.client.extended.leaderelection.resourcelock.ConfigMa
pLockTest
[INFO] Running io.fabric8.kubernetes.client.extended.leaderelection.resourcelock.LeaseLockTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.427 s - in io.fabric8.kubernetes.client.extended.leaderelection.resourcelock.LeaseLoc
kTest
[INFO] Running io.fabric8.kubernetes.client.extended.run.RunConfigUtilTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.536 s - in io.fabric8.kubernetes.client.extended.run.RunConfigUtilTest
[INFO] Running io.fabric8.kubernetes.client.extended.run.RunOperationsTest
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

Ghost
@ghost~60b391476da03739847dc13e
mintty.2021-06-04_18-54-15.png
mintty.2021-06-04_18-56-02.png
Rohan Kumar
@rohanKanojia
oh, you're using windows
Ghost
@ghost~60b391476da03739847dc13e
yes
Rohan Kumar
@rohanKanojia
I'm afraid our tests might be failing on windows
I think for you task you don't really need to run test but check whether project complies fine
Does this work mvn clean install -DskipTests
Ghost
@ghost~60b391476da03739847dc13e
1 "I'm afraid our tests might be failing on windows" Yes sir this is happening with two test cases.
2 Okay.
3 Yes it is.
Rohan Kumar
@rohanKanojia
Could you please create a PR in draft mode so that I can check?
Ghost
@ghost~60b391476da03739847dc13e
sure
Ghost
@ghost~60b391476da03739847dc13e
fabric8io/kubernetes-client#3220
Rohan Kumar
@rohanKanojia
Thanks
let me try to check this on Monday
Rohan Kumar
@rohanKanojia
Sorry for not being clear on the issue. tests in kubernetes-itests/ module use arquillian which is dependent in Junit4. Could you please remove modifications from this module?
No
Your changes are fine. Just need to remove your changes from kubernetes-itests/ directory
Ghost
@ghost~60b391476da03739847dc13e
Okay.
Rohan Kumar
@rohanKanojia
git checkout -- kubernetes-itests/ upstream/mastershould do the job
Rohan Kumar
@rohanKanojia
what does git remote -v give?
oh, you don't have fabric8's remote added
Could you please check if this works git checkout -- kubernetes-itests/ master
Rohan Kumar
@rohanKanojia
ah, sorry git checkout master -- kubernetes-itests/ should work.
Mohd Uzair
@MUzairS15
fabric8io/kubernetes-client#2942 is this issue still relevant ?
Rohan Kumar
@rohanKanojia
I'm not sure
Mohd Uzair
@MUzairS15
Ok
Mohd Uzair
@MUzairS15
@rohanKanojia can you suggest me an issue on which I can work ?
Rohan Kumar
@rohanKanojia
Could you please check if fabric8io/kubernetes-client#2849 would work for you(see my last comment)
Rohan Kumar
@rohanKanojia
If it's a bit involved feel free to go through sonar code smells and fix any which seems okay to you https://sonarcloud.io/project/issues?id=fabric8io_kubernetes-client&languages=java&resolved=false&rules=java%3AS5786&types=CODE_SMELL
Mohd Uzair
@MUzairS15
#2849 will go for this, will try
And then later on with the sonarcloud.
Will it be ok?
Rohan Kumar
@rohanKanojia
sounds good to me.
You would need to create these two classes specific to each extension module. Here is example for OpenShift Mock Extension:
https://github.com/fabric8io/kubernetes-client/blob/master/openshift-server-mock/src/main/java/io/fabric8/openshift/client/server/mock/EnableOpenShiftMockClient.java
https://github.com/fabric8io/kubernetes-client/blob/master/openshift-server-mock/src/main/java/io/fabric8/openshift/client/server/mock/OpenShiftMockServerExtension.java
then you'll be able to use junit5 annotations like @EnableKnativeMockClient, @EnableTektonMockClient etc
Mohd Uzair
@MUzairS15
Thank you
Marc Nuri
@manusa
Starting release process for 5.5.0