Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:45
    andreaTP review_requested #4642
  • 14:44
    andreaTP commented #4642
  • 14:32
    shawkins opened #4643
  • 14:07
    shawkins commented #4641
  • 13:48
    biswadyuti-mahato starred fabric8io/kubernetes-client
  • 13:37
    nicoloboschi commented #4598
  • 13:37
    nicoloboschi edited #4642
  • 13:32
    nicoloboschi synchronize #4642
  • 13:31
    nicoloboschi opened #4642
  • 13:23
    sonarcloud[bot] commented #4639
  • 13:23
    sonarcloud[bot] commented #4639
  • 13:05
    shawkins labeled #4637
  • 12:50
    shawkins synchronize #4639
  • 12:43
    shawkins milestoned #4624
  • 11:39
    sonarcloud[bot] commented #261
  • 08:13
    manusa milestoned #4635
  • 08:13
    manusa milestoned #4635
  • 08:13
    manusa review_requested #4635
  • 06:14

    manusa on master

    fix #4540: adding generic and r… fix #4540: adding a test to ens… fix #4540: regenerating the mod… and 3 more (compare)

Rohan Kumar
@rohanKanojia
let me try to check this on Monday
Rohan Kumar
@rohanKanojia
Sorry for not being clear on the issue. tests in kubernetes-itests/ module use arquillian which is dependent in Junit4. Could you please remove modifications from this module?
No
Your changes are fine. Just need to remove your changes from kubernetes-itests/ directory
Ghost
@ghost~60b391476da03739847dc13e
Okay.
Rohan Kumar
@rohanKanojia
git checkout -- kubernetes-itests/ upstream/mastershould do the job
Rohan Kumar
@rohanKanojia
what does git remote -v give?
oh, you don't have fabric8's remote added
Could you please check if this works git checkout -- kubernetes-itests/ master
Rohan Kumar
@rohanKanojia
ah, sorry git checkout master -- kubernetes-itests/ should work.
Mohd Uzair
@MUzairS15
fabric8io/kubernetes-client#2942 is this issue still relevant ?
Rohan Kumar
@rohanKanojia
I'm not sure
Mohd Uzair
@MUzairS15
Ok
Mohd Uzair
@MUzairS15
@rohanKanojia can you suggest me an issue on which I can work ?
Rohan Kumar
@rohanKanojia
Could you please check if fabric8io/kubernetes-client#2849 would work for you(see my last comment)
Rohan Kumar
@rohanKanojia
If it's a bit involved feel free to go through sonar code smells and fix any which seems okay to you https://sonarcloud.io/project/issues?id=fabric8io_kubernetes-client&languages=java&resolved=false&rules=java%3AS5786&types=CODE_SMELL
Mohd Uzair
@MUzairS15
#2849 will go for this, will try
And then later on with the sonarcloud.
Will it be ok?
Rohan Kumar
@rohanKanojia
sounds good to me.
then you'll be able to use junit5 annotations like @EnableKnativeMockClient, @EnableTektonMockClient etc
Mohd Uzair
@MUzairS15
Thank you
Marc Nuri
@manusa
Starting release process for 5.5.0
Rohan Kumar
@rohanKanojia
Thanks a lot!
Rafael Guillen
@rguillens

Hi, this method of SharedInformerFactory is deprecated in version 5.5.0
public synchronized <T extends HasMetadata> SharedIndexInformer<T> sharedIndexInformerFor(Class<T> apiTypeClass, OperationContext operationContext, long resyncPeriodInMillis)

This could be an alternative implementation to OperationContext to watch labelled workloads?

SharedIndexInformer<Pod> podInformer = kubernetesClient.pods()
                .withLabels(DEFAULT_SELECTORS)
                .inform(podHandler, RESYNC_PERIOD);
Marc Nuri
@manusa
Yes, IIRC that should be the recommended approach now. I'm not completely sure that the label filtering applies. @shawkins?
Steven Hawkins
@shawkins
Yes labels and any other context apply as well - the inform is just piggy-backing on the list and watch operations at the given context
Rafael Guillen
@rguillens
Thanks folks!
paulgeiger-eng
@paulgeiger-eng

Hi,

My team is facing a new issue after uptaking 5.4.0 that we have not seen with previous versions. The problem comes when we have a SharedInformer for a class where the CRD has been loaded in the cluster but no actual CRD resources have been created.

We have some code to get the list of resources in a workspace from the informer cache:

final var indexer = resourceInformer.getIndexer();
final var resourcesListOptional = Optional.ofNullable(indexer.byIndex(Cache.NAMESPACE_INDEX, namespace));

This existing code is now with 5.4.0 producing an exception:

Caused by: java.lang.NullPointerException
at io.fabric8.kubernetes.client.informers.cache.Cache.byIndex(Cache.java:291)

Note that the byIndex method does a check for existence of indexName in "indexers" but does not do an equivalent check in "indices". There seems to be an assumption that indices would have the same keys as indexers and in the constructor they are both initialized with the same key "namespace". However in our scenario I am observing that indexers still contains the "namespace" key but indices is an empty map. Hence we get the null pointer exception on line 291.

I have observed that when the informer is starting the Cache::replace method is being called with an empty list parameter. Then on line 157 it sets indices to a new/empty map. Since there are no items there is no additional initialization performed on indices. The call stack looks like:

Cache::replace (157)
ProcessorStore::replace (90)
Reflector::listSyncAndWatch (83)
Controller::run (93)

It appears that we don't have any mechanism to check for this condition since the Cache indices property is private.

Would anyone please suggest a check, work-around, or fix?

Rohan Kumar
@rohanKanojia
Do you think your issue is this one ? fabric8io/kubernetes-client#3272
Marc Nuri
@manusa
Starting release process for 5.6.0
Rohan Kumar
@rohanKanojia
:+1:
paulgeiger-eng
@paulgeiger-eng
Hi @rohanKanojia. It looks like the issue you mentioned is the same issue we are facing. We will try taking up the 5.5.0 or it looks like 5.6.0 is about to be released so maybe we'll go directly to that one.
Rohan Kumar
@rohanKanojia
5.6.0 got released yesterday
Yes, maybe you can try it out and provide feedback :-)
emrealpogunc
@emrealpogunc
Hello everyone, Im having an issue with fabric8 atm. Can someone please check it out? fabric8io/kubernetes-client#3352 I dont know if this is allowed, if not I can delete this message.
I'm using Ubuntu btw.
Rohan Kumar
@rohanKanojia
Do you have some simple reproducer project which we can try out?
I havent really used fabric8 with Eclipse.. I usually build a maven project and load as a maven project in IntelliJ
emrealpogunc
@emrealpogunc
Will give intellij a shot ^_^ Thank you so much for the recommendation.
Rohan Kumar
@rohanKanojia
I think it might also be possible to build maven project and load in Eclipse as maven project
emrealpogunc
@emrealpogunc
I tried intellij and did just like you've said(build and load as a maven project) and right now everything seems fine. I think I've found some of your tutorials and articles on the web and I'm trying to learn through them atm. Thank you once again👍
Rohan Kumar
@rohanKanojia
my tutorials?
emrealpogunc
@emrealpogunc
https://developers.redhat.com/blog/2020/05/20/getting-started-with-the-fabric8-kubernetes-java-client# by tutorials I meant this article in particular, I might have misused the term "tutorial" a bit, apologies If I caused an inconvenience.
Rohan Kumar
@rohanKanojia
oh, I see.
No need to apologize.
emrealpogunc
@emrealpogunc
I get exited when I'm talking with you talented people so I might apologize or thank for unnecessary reasons (I know it's silly but I can't help myself :D)