It seems we happened to miss @nZac 's comment on falconry/falcon#1592, and forgot to add a Towncrier newsfragment. So that fragment could also go into the follow-up PR.
OTOH re
api_helpers.py, one could argue those helpers are private helpers supporting the Falcon API interface, not the API class, so probably not a big deal either way for me. But it is probably a good idea to rename for consistency provided we have renamed everything else.
app = falcon.API(middleware=[
AuthMiddleware(),
RequireJSON(),
JSONTranslator(),
])falcon.API -> falcon.App
FWIW, @mikeyusko I see no new news fragments in the master branch that would have been added recently: https://github.com/falconry/falcon/tree/master/docs/_newsfragments .
@vytas7 @nZac I'll create a follow-up PR for this one falconry/falcon#1592
- Rename
api_helpers->app_helpersto be consistent - Add newsfragment (could you provide a bit more info on how to do it? because I can't understand for which goals it needed)
- Fix
falcon.APIin the README file.
Thanks
@mikeyusko Sounds like a plan. Could you also take a look at the "look" tutorial tests? https://travis-ci.org/falconry/falcon/jobs/622120513
At least the decorator is working as expected :wink:
coverage is 75%, we need 100% :smiling_imp:
@mikeyusko Sorry for the confusion if that was my fault. We don't even track coverage for "look" AFAICT. Where do you get that 75% from? :confused:
What I meant was that running "look" tests seemed to emit the
What I meant was that running "look" tests seemed to emit the
API deprecation warning, as if these tests hadn't been upgraded to use App yet.
examples/look/tests/test_app.py ... [ 75%] :arrow_left: @mikeyusko if you mean that 75%, it is, to the best of my knowledge, merely a pytest progress indicator (3/4 tests complete at that point).
@vytas7 oh, cool! thank you for clarification:)
https://github.com/falconry/falcon/blob/master/examples/look/tests/test_app.py#L21
https://github.com/falconry/falcon/blob/master/examples/look/look/app.py#L10
those ^^ lines also should be fixed as well.
@vytas7 and yeah, thank you for your support, it’s really helpful, and I day by day much more understands falcon’s flow, principles, and rules.
And as a result - contribute to Falcon will be a bit easier
:thumbsup:
If we are to accept some pure Cython stuff into Falcon, I'm also experimenting with an IBM Z (s390x) pipeline in Travis, as it seems to be Big Endian architecture.
Woohoo multipart Cython parts passed on Big Endian :tada:
I will probably need opinions :)
>>> import timeit
>>> k = 'key'; v = 'value'; keep_blank = True
>>> timeit.timeit(lambda: not (v or (keep_blank and k)), number=int(1e8))
5.702389151003445
>>> timeit.timeit(lambda: not (v or (keep_blank and k)), number=int(1e8))
5.684955962999084
>>> timeit.timeit(lambda: not (v or (keep_blank and k)), number=int(1e8))
5.685243817999435
>>> timeit.timeit(lambda: not v and (not keep_blank or not k), number=int(1e8))
5.500417819006543
>>> timeit.timeit(lambda: not v and (not keep_blank or not k), number=int(1e8))
5.490288328001043
>>> timeit.timeit(lambda: not v and (not keep_blank or not k), number=int(1e8))
5.471835395997914
This was CPython 3.8.0, FWIW.
Aye, the whole story is somewhat funny because I'm not that much of a performance junkie as some other Falcon maintainers :slight_smile: But once you dig deep into the problem, it becomes so cool to shave off that nanosecond in some obscure Cython optimization :slight_smile:
E: Unable to locate package libunwind-dev
The command "sudo apt-get install -y libunwind-dev" failed and exited with 100 during .
Oh, failed with something mundane :grimacing: I think it was me who added this
libunwind-dev for our benchmark suite to work on 16.04, I could try to make it conditional
Falcon is now "certified" on IBM Z (
s390x) :slight_smile: : https://travis-ci.org/falconry/falcon/jobs/624750430