it would be convenient to be able to detect that the url is not encoded properly
to respond with some sensible error
I actually guess that javascript fetch... automatically url encodes... I should check
Im maybe only running into this problem in unittests
Yes, OK I see that javascript fetch... automatically URL encodes this stuff
so this is just a problem in my testing
haha, ok thats not so bad
so does % / url encoding handle all languages... its some kind of UTF8 protocol over ASCII I guess
at least I can write chinese and whatever in there and get url encoding from my javascript fetch
so I guess it is
Right, so the client is responsible for taking their string, encoding it as UTF8, and then percent-encoding the result. Then Falcon will percent-decode the incoming byte string and then decode to a unicode string. Under Python 2.7 there is an optimization that causes the framework to only decode to unicode when there are non-ASCII characters in there after percent-decoding.
I just created this. Feel free to comment. falconry/falcon#1685
@vytas7 ^^^
Also note that the upcoming Falcon 3.0 release will not support Python 2, but we will continue to maintain the Falcon 2.x series for a while.
wont be too hard I imagine, not sure why I dont take the time yet
ok I found now that in my testing i should be doing
urllib.quote_plus(... my query...)
ok thanks man!
I also added a note to that issue re simulating requests
FWIW, I noticed that Nginx blocks such requests outright with a 400, does not propagate them further to the app server.
I'm moving my api from Flask to Falcon and everything has been smooth expect Stripe wont decode json payloads
I was using payload = json.load(req.bounded_stream)
Then with stripe using the following;
event = stripe.Webhook.construct_event(
payload, sig_header, os.environ["STRIPE_ENDPOINT_SECRET"]
)
payload, sig_header, os.environ["STRIPE_ENDPOINT_SECRET"]
)
Which is causing 'No signatures found matching the expected signature for payload' to happen
This isn't happening with other endpoints I have parsing json data
if the content type header is properly set you can use req.media to obtain the parsed json. https://falcon.readthedocs.io/en/stable/api/media.html
Am I missing something in terms of getting the raw string? I also tried bounded_stream
I also asked at https://stackoverflow.com/questions/60797980/has-to-be-my-code-in-falcon-resources-thread-safe. When (if) I get answer, I'll post it also there.
Hi @liborjelinek_twitter !
Responder methods, such as on_get, on_post etc, may be called in parallel (as part of handling parallel requests) in different processes, threads and/or greenlets/eventlets/coroutines etc if your WSGI server of choice supports that. Gunicorn can be configured to run multi-threaded.
So in that sense yes, if your responder methods are accessing shared resources, care needs to be taken they are thread-safe. The same applies to hooks, middleware methods, router converters, custom error handlers etc.
See also here: Is Falcon thread-safe?
