Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

fastpack/general

Pack JS code fast & easy

People

Repo info

Activity

Oleksiy Golovko

@zindel

@rauanmayemir what would be the clearer message for you?

Rauan Mayemir

@rauanmayemir

i think something like 'Cache: empty'/ 'Cache: yes'/'Cache: disabled' would make it more helpful

Oleksiy Golovko

@zindel

@rauanmayemir just committed the fix for renamings & deletions in watch mode

Rauan Mayemir

@rauanmayemir

👍

Rauan Mayemir

@rauanmayemir

@zindel hey! have you guys considered adding built-in SASS support? as in native-native sass/scss compiler

Rauan Mayemir

@rauanmayemir

i wonder what would one need to do had he wanted to add such support

or try and play around

Rauan Mayemir

@rauanmayemir

though i'd rather start with something easier, like file-loader or image-loader

Oleksiy Golovko

@zindel

Hi @rauanmayemir!

we haven't thought enough how to do it in a native way yet

Although we're trying to maintain the compatibility with webpack loaders

see this issue: fastpack/fastpack#41

Rauan Mayemir

@rauanmayemir

i didn't quite understand the issue. does that mean file-loader is baked-in or you just plug the webpack's file-loader in-process?

Oleksiy Golovko

@zindel

sass-loader specifically is not tested yet, but we have a plan to test it before the release

not really

Rauan Mayemir

@rauanmayemir

i meant trying to replace all the loaders with native built-in modules, at least for basic ones

Oleksiy Golovko

@zindel

if we see such loaders in the config - we start the node process as the service

and communicate the config right to it, feeding the result back to the main process

it is absolutely on the target system to have the needed dependencies installed, as well as 'loader-runner'

we have couple integration tests built-in, to demonstrate the example config

for instance, see this one:

https://github.com/fastpack/fastpack/tree/master/test/pack-cra

and specifically, this file: https://github.com/fastpack/fastpack/blob/master/test/pack-cra/pack-cra.test.js

Rauan Mayemir

@rauanmayemir

have you considered e.g replacing the node process part with native call? 'just because'

Oleksiy Golovko

@zindel

we did :)

although we don't have enough resources

yesterday I dreamed about the OCaml native CSS parser

Rauan Mayemir

@rauanmayemir

if you can give some guidance, i'd love to start with the basic loaders and try contributing

Oleksiy Golovko

@zindel

if you want to try it out I can walk you through the architecture

great!

would it be easier with some sort of voice chat / screen sharing?

Rauan Mayemir

@rauanmayemir

sure

Oleksiy Golovko

@zindel

Hey guys, did some fastpack development streaming today

pretty basic, but in case you're interested:

https://www.twitch.tv/zindelzindel/videos/all

Oleksiy Golovko

@zindel

got sass-loader working!

Oleksiy Golovko

@zindel

@/all Hi! Would appreciate your feedback on this issue (see my last comment): fastpack/fastpack#41

Thanks!

Rauan Mayemir

@rauanmayemir

Screen Shot 2018-02-28 at 1.56.08 PM.png

@zindel have you considered using ocaml infra for testing? cause bash scripts feel messy and prone to issues

Oleksiy Golovko

@zindel

@rauanmayemir Hi!

so my main motivation of using Bash was to make it as close to the usage scenario as possible

i.e. it has to be run as shell command, so let's use shell :)

Another important piece I find useful and nice to work with is the diff command which is executed on directories

makes it easy to see what has changed and how

On the other hand I'm happy to consider other alternatives. If there is more standard / canonical way to such kind of testing in the OCaml world - we could try it out

Rauan Mayemir

@rauanmayemir

great, let's table this discussion until we have a clearer picture how to make it work from the ocaml side

Oleksiy Golovko

@zindel

agreed!

Oleksiy Golovko

@zindel

@here So, I'm about to announce a release