Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Aleksuei Riabtsev
@AleksueiR
Aly Merchant
@alyec
Nicely done, both of you
Aleksuei Riabtsev
@AleksueiR
I think I remember someone was comparing airbnb and angular styleguide jshint files. They don't look that similar to me: http://www.mergely.com/wO1OuNTb/
Aly Merchant
@alyec
:white_check_mark: I'll walk through the diff, but it might also be worth bringing this up during planning
Aleksuei Riabtsev
@AleksueiR
Same applies to JSCS: http://www.mergely.com/depBPgMx/
Aly Merchant
@alyec
Can you link the source files? I don't like the online merge tool.
Aly Merchant
@alyec
It's pretty ridiculous that jshint doesn't list the default status of its options in the docs.
Aly Merchant
@alyec
On jshint: they're a lot closer once the defaults are removed.
diff
Aleksuei Riabtsev
@AleksueiR
if you add unused: true, strict: true, indent: 4, the only difference is latedef and esnext.
Aly Merchant
@alyec
Only in Angular:
  • es3
  • immed
  • loopfunc
  • sub
Aleksuei Riabtsev
@AleksueiR
Should we keep them?
Aly Merchant
@alyec
immed will be deprecated so that should definitely go
Personally I don't like any of the others
As in, I think we should keep to the defaults and not follow Angular.
Aleksuei Riabtsev
@AleksueiR
:heavy_check_mark:
Aly Merchant
@alyec
Haven't looked at JSCS yet, have you?
Or anyone else?
Aleksuei Riabtsev
@AleksueiR
no, was distracted by bots
Aly Merchant
@alyec
:white_check_mark: an excellent reason
I'll do the diff and summarize
Aly Merchant
@alyec
Unless we adopt ES6
Aleksuei Riabtsev
@AleksueiR
Sure, seems like a good options to have on.
Aly Merchant
@alyec
I'll bring it up when we're discussing the diff (haven't forgotten about that, but I figured it would be better to go over that when Johann is back).
Aleksuei Riabtsev
@AleksueiR
Makes sense.
Say, reviewable works for you, right?
I get this error and nothing loads:
df9de46f.app.js:1 Uncaught SyntaxError: Unexpected token <
Aly Merchant
@alyec
Works fine for me.
Console is clear on load.
Aleksuei Riabtsev
@AleksueiR
Got back on.
Aly Merchant
@alyec
But I did have some FW issues for a few minutes. When I was looking up JSCS rules I had JSCS blocked for a few minutes, I was going to email service desk then it started working again.
Evil network demons strike again.
Aleksuei Riabtsev
@AleksueiR
Travis is still blocked.
Aly Merchant
@alyec
:x:
Aly Merchant
@alyec

Travis fgpv-vpgf/gulp-i18n-csv#20 broken (29)

Someone didn't run unit tests

Aleksuei Riabtsev
@AleksueiR
or style checks
Aly Merchant
@alyec
:astonished:
glitch
@glitch-bot
  alyec pushed 1 commit(s) to alyec/gulp-i18n-csv: [compare]
glitch
@glitch-bot
  alyec labeled an issue: fgpv-vpgf/gulp-i18n-csv#24
  alyec opened an issue: fgpv-vpgf/gulp-i18n-csv#24
  alyec pushed 2 commit(s) to alyec/gulp-i18n-csv: [compare]
  alyec opened a Pull Request: fgpv-vpgf/gulp-i18n-csv#25
Aleksuei Riabtsev
@AleksueiR
Is working on weekends a muffin offence? :smile:
glitch
@glitch-bot
  AleksueiR commented on issue fgpv-vpgf/gulp-i18n-csv#25
glitch
@glitch-bot
  alyec commented on issue fgpv-vpgf/gulp-i18n-csv#25
glitch
@glitch-bot
  AleksueiR commented on issue fgpv-vpgf/gulp-i18n-csv#25
glitch
@glitch-bot
  AleksueiR closed a Pull Request: fgpv-vpgf/gulp-i18n-csv#25
  alyec closed an issue: fgpv-vpgf/gulp-i18n-csv#2
  AleksueiR pushed 5 commit(s) to fgpv-vpgf/gulp-i18n-csv: [compare]