These are chat archives for fgpv-vpgf/gulp-i18n-csv

18th
Aug 2015
Aly Merchant
@alyec
Aug 18 2015 13:03
You should use "_this" to save a reference to "this" at index.js :
    77 |
    78 |    return through.obj(function (file, enc, cb) {
    79 |        var task = this; // task is a reference to the through stream
----------------^
Do we want to make some exceptions?
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 13:29
What do the angular styleguide or airbn say? _this or that?
Aly Merchant
@alyec
Aug 18 2015 13:32
Using airbnb presets _this
I actually like _this but I know some people really don't like forcing this to be named specifically so I figure I'd ask before doing the refactor.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 13:34
I'm okay with _this.
Aly Merchant
@alyec
Aug 18 2015 13:35
Well, there's only a handful of us working on this right now, so unless @cynngah wants to make a case for _unicorn _this wins.
Cynthia (Qingwei) Li
@cynngah
Aug 18 2015 13:36
yo
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 13:36
_unicorn :D
Cynthia (Qingwei) Li
@cynngah
Aug 18 2015 13:36
ya sure
i'm still having trouble trying to figure out how to do the deep nesting ROFL
unless I can stringify then unstringify something
Aly Merchant
@alyec
Aug 18 2015 13:37
I don't think you need to. Just iterating on the parts of the key should work.
i = 0;
parts = key.split('.');
node = jsonObj;
while (i < parts.length-1) {
  node = node[parts[i]];
  // create empty obj in key hierarchy if necessary
  ++i;
}
node[parts[i]] = value;
Cynthia (Qingwei) Li
@cynngah
Aug 18 2015 13:49
oh that's smart thanks
Aly Merchant
@alyec
Aug 18 2015 14:16
Should I be creating a PR from my branch to master or somewhere else?
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 14:19
Master sounds good.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 14:33
Is it possible to pull a pull request before merging it?
Aly Merchant
@alyec
Aug 18 2015 14:35
Can you clarify what you mean?
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 14:36
How can I download code changes from the pull request to test it on my machine for example?
Aly Merchant
@alyec
Aug 18 2015 14:37
You can add my fork as a remote, or you could clone it separately.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 14:38
ah, right, thanks!
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 14:49
reviewable is cool :D
Aly Merchant
@alyec
Aug 18 2015 14:51
:)
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:19
@dan-bowerman, can you turn on travis integration for gulp-i18n-csv here https://travis-ci.org/profile/fgpv-vpgf?
Dan Bowerman
@dan-bowerman
Aug 18 2015 15:41
Done. Had to do it from my home connection.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:44
Thanks! :+1:
Hm, doesn't seem to work. Still shows as disabled:
Dan Bowerman
@dan-bowerman
Aug 18 2015 15:51
Can I do this manually through GitHub's web hooks settings? I need an API key?
Aly Merchant
@alyec
Aug 18 2015 15:52
I think it's already hooked up, it just needs to be enabled on Travis.
Dan Bowerman
@dan-bowerman
Aug 18 2015 15:53
Sorry, try now.
Had to relogin, the toggle page wasn't loading
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:53
WOMM
Thanks, @dan-bowerman :)
Dan Bowerman
@dan-bowerman
Aug 18 2015 15:53
Hopefully as of tomorrow you can enable these things without me :)
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:54
Then I guess I'll wait till tomorrow and not ask you to create a repo for a r2 config generator :D
Dan Bowerman
@dan-bowerman
Aug 18 2015 15:55
Gimme the details and I can set that up. I'm not complaining about doing these things, just think everyone would prefer to handle it themselves.
Aly Merchant
@alyec
Aug 18 2015 15:55
@AleksueiR don't we need a config format before we start working on config generators? :)
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:56
Nah, who needs that :) At least we can set up a base for that.
Can we call it simple r2-config-generator?
Aly Merchant
@alyec
Aug 18 2015 15:57
Yeah, I actually agree. I think starting on some of the support projects is really helpful. Gives everyone a chance to become familiar with the tools before we start heavy work on the core project.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:58
^ this is so true.
Aly Merchant
@alyec
Aug 18 2015 15:58
I was also thinking of redoing the RCS test page in Angular with Angular-Material just to get some exposure to the front end.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 15:59
I think this is an excellent idea.
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 16:35
Interesting, I cannot merge my own PR from reviewable.
Turns out I can :( Needed to acknowledge the last comment to get the button to show up.
Aly Merchant
@alyec
Aug 18 2015 16:35
That's probably good
Aleksuei Riabtsev
@AleksueiR
Aug 18 2015 16:36
Yeah, I think one shouldn't be able to accept hiw own PRs unless he own both repos.
Aly Merchant
@alyec
Aug 18 2015 16:38
I guess we just make it a muffin offense in the revised constitution.