These are chat archives for fgpv-vpgf/gulp-i18n-csv

19th
Aug 2015
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 13:21
build is broken
Aly Merchant
@alyec
Aug 19 2015 13:25
:arrow_up_small: :donut: :donut: :donut:
No muffin emoji :x:
Dan Bowerman
@dan-bowerman
Aug 19 2015 13:26
:birthday:
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 13:27
Aly Merchant
@alyec
Aug 19 2015 13:29
Nicely done, both of you
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 13:59
I think I remember someone was comparing airbnb and angular styleguide jshint files. They don't look that similar to me: http://www.mergely.com/wO1OuNTb/
Aly Merchant
@alyec
Aug 19 2015 14:06
:white_check_mark: I'll walk through the diff, but it might also be worth bringing this up during planning
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 14:13
Same applies to JSCS: http://www.mergely.com/depBPgMx/
Aly Merchant
@alyec
Aug 19 2015 14:14
Can you link the source files? I don't like the online merge tool.
Aly Merchant
@alyec
Aug 19 2015 14:26
It's pretty ridiculous that jshint doesn't list the default status of its options in the docs.
Aly Merchant
@alyec
Aug 19 2015 16:55
On jshint: they're a lot closer once the defaults are removed.
diff
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 16:56
if you add unused: true, strict: true, indent: 4, the only difference is latedef and esnext.
Aly Merchant
@alyec
Aug 19 2015 16:59
Only in Angular:
  • es3
  • immed
  • loopfunc
  • sub
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 17:00
Should we keep them?
Aly Merchant
@alyec
Aug 19 2015 17:01
immed will be deprecated so that should definitely go
Personally I don't like any of the others
As in, I think we should keep to the defaults and not follow Angular.
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 17:02
:heavy_check_mark:
Aly Merchant
@alyec
Aug 19 2015 17:03
Haven't looked at JSCS yet, have you?
Or anyone else?
Aleksuei Riabtsev
@AleksueiR
Aug 19 2015 17:03
no, was distracted by bots
Aly Merchant
@alyec
Aug 19 2015 17:05
:white_check_mark: an excellent reason
I'll do the diff and summarize