These are chat archives for fiji/fiji

11th
Dec 2015
Jan Eglinger
@imagejan
Dec 11 2015 08:25
hi guys,
is there a chance that we can get my changes to Descriptor-based registration online (i.e. uploaded to the Fiji update site) soon?
It would require:
  • cutting a 2.0.12 release of Descriptor_based_registration
  • updating pom-fiji to include mpicbg-1.1.1 and Descriptor_based_registration-2.0.12
  • uploading both mpicbg.jar and Descriptor_based_registration.jar
Curtis Rueden
@ctrueden
Dec 11 2015 13:37
@imagejan I will work on it today.
I added @StephanPreibisch to this room, since he usually cuts releases of his own components.
@StephanPreibisch @axtimwalde There are some Fiji components that live in bigdataviewer and trakem2 organizations, which are not actually core to those respective projects, but rather depend on them.
The Descriptor_based_registration being one of them. It depends on BDV, but is not part of BDV.
Curtis Rueden
@ctrueden
Dec 11 2015 13:46
My original thinking was that you should extend the "most specific" parent POM related to needed dependencies. So e.g. Descriptor_based_registration extends pom-bigdataviewer right now, and its version is managed there. The same was true of TrakEM2 downstream components (trakem2/TrakEM2@425442d). However, @axtimwalde did not like that for TrakEM2 and he removed management of those components (trakem2/TrakEM2@afc201b).
Hence, the treatment of "Fiji subproject" downstream components is now inconsistent. I would like to fix that.
My proposal is: 1) move these downstream components back to the Fiji org itself; 2) manage the versions of these components in pom-fiji; 3) use scope import of pom-bigdataviewer and/or pom-TrakEM2 in these components in order to inherit the version management of the needed BDV and/or TrakEM2 components.
This is how we should have done it in the first place, so that we can have Fiji components which depend on multiple suborgs at the same time. The single inheritance pattern would not allow e.g. depending on BDV and TrakEM2 at the same time with managed versions of both.
I mention all this now because it directly relates to @imagejan's request above: if I am going to cut a new Descriptor_based_registration and pom-fiji then I would like to fix the above issues as part of that. This also avoids the need to cut a new pom-bigdataviewer just for the downstream Descriptor_based_registration update.
@axtimwalde @StephanPreibisch Please let me know if you have any concerns with this plan.
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:20
@ctrueden @imagejan, sorry for the long silence, I have been travelling and busy
trakem2 is different because all projects live in the same repository
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:26
i do not fully understand the plan
Curtis Rueden
@ctrueden
Dec 11 2015 14:26
@axtimwalde I am talking about projects such as Reconstruct_Reader which do not live in the TrakEM2 repo, and are not part of core TrakEM2. They are rather downstream of TrakEM2 (i.e., they depend on it).
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:26
however, if it sounds good to you, I trust your judgement, just do not have time to work on this right now
indeed
Curtis Rueden
@ctrueden
Dec 11 2015 14:27
@axtimwalde No worries, thanks for taking a moment to respond. I think this will make the project structure better—avoid "polluting" pom-trakem2 and the trakem2 org with non-TrakEM2-specific projects.
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:27
hmmm
Curtis Rueden
@ctrueden
Dec 11 2015 14:27
I'll do it, and if it is horrible, we can fix it again. ;-)
But I am pretty confident it will be less invasive of a structure.
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:28
i did that tracking to make my life simpler as a reminder who else depends on me when I break things
which is a futile attempt
Curtis Rueden
@ctrueden
Dec 11 2015 14:29
Well, we have the melting pot now, which will help us. I still need to hook it to Jenkins, and make it possible for people to feed it requests (e.g.: "please test master branch of TrakEM2 with the rest of Fiji" etc.)
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:29
but it helped me at the time when i had to fix all these projects following up on me breaking mpicbg
ok---cool
Curtis Rueden
@ctrueden
Dec 11 2015 14:29
Or at least write up documentation on how to feed it requests from the CLI (which you can do now).
Stephan Saalfeld
@axtimwalde
Dec 11 2015 14:29
as I said, I trust your judgement
Curtis Rueden
@ctrueden
Dec 11 2015 14:29
Thanks, I'll keep you posted on any issues.