finagle/featherbed

Asynchronous Scala HTTP client using Finagle and Cats

jeremyrsmith

@jeremyrsmith

@travisbrown Printer didn’t change from 0.9.0-0.9.1 as far as I can tell: https://github.com/circe/circe/compare/v0.9.0...v0.9.1

@bhudgeons is it possible you have an older/newer circe dependency elsewhere? These kinds of things are really annoying to track down, but I’m happy to make a featherbed release pointing to whatever the latest circe is.

featherbed really needs some attention… I feel terrible about abandoning my finagle projects, but they just don’t get a lot of priority nowadays since I don’t use finagle at work.

I also thought there were a couple of libs out there to supplant featherbed, but I don’t remember what I thought they were. Can’t immediately find one with good finagle/twitter-util integration. Hmm.

Travis Brown

@travisbrown

@jeremyrsmith I wouldn't update to the 0.10.0 milestone, so there shouldn't be any need to update Featherbed immediately on the circe side (although a more recent Finagle would be nice).

Brandon Hudgeons

@bhudgeons

@travisbrown @jeremyrsmith thanks guys ... doing dependency spelunking now. Will investigate the issue, and I'll report.

Brandon Hudgeons

@bhudgeons

Dammit ... I'm using multiple libs that use circe, and it looks like one is actually using v0.9.0-M1, where Printer changed: https://github.com/circe/circe/compare/v0.9.0-M1...v0.9.1

adding fields to the case class breaks the copy.

[... right?]

I'll track down which lib is the offender.

thanks for your help

Ben Spencer

@dangerousben

@jeremyrsmith out of interest are you not using finagle because you've migrated to something else?

jeremyrsmith

@jeremyrsmith

@dangerousben no, just because I changed jobs about 1.5y ago, and new company doesn’t use finagle (and I work on ML instead of web services/data eng. now, so even if they did I probably wouldn’t be working directly with it)

Brandon Hudgeons

@bhudgeons

I found the problem. Featherbed-circe 0.3.2 uses circe 0.9.0-M2 and Printer did indeed change between then and 0.9.1. I'll get a PR in to upgrade circe to 0.9.1.

Travis Brown

@travisbrown

@bhudgeons you can't update to 0.3.3?

Brandon Hudgeons

@bhudgeons

There was no 0.3.3 tag, so I didn't think there was one.

Does it upgrade to 0.9.0? That's what's in master, and I think that would work fine for me.

Yep ... it does. Thanks @travisbrown!

jeremyrsmith

@jeremyrsmith

:disappointed: I must not have tagged it

Brandon Hudgeons

@bhudgeons

@jeremyrsmith no worries!

harrydevnull

@harrydevnull

hi is there an example of downloading a file from another webservice?

may be the question can be phrased to are there any feather-bed decoders out of the box for decoding binary content?

jeremyrsmith

@jeremyrsmith

@harrydevnull IIRC you can always get a Buf which gives you the bytes.

harrydevnull

@harrydevnull

any code samples? @jeremyrsmith

jeremyrsmith

@jeremyrsmith

hmm, not really. It looks like you’d want to make your own Decoder, i.e. for PDF:

harrydevnull

@harrydevnull

:disappointed:

jeremyrsmith

@jeremyrsmith

implicit val pdfDecoder: Decoder.Aux[Witness.`”application/pdf”`.T, PDF] = Decoder.of(“application/pdf”) {
  response => fnFromBufToPDF(response.content)
}

sorry :(

harrydevnull

@harrydevnull

that works :D

jeremyrsmith

@jeremyrsmith

if you just want a Buf out it’s pretty trivial

Decoder.of(“content/type”)(response => Validated.valid(_.content)) I think

there should be an actual API for that, but there doesn’t seem to be.

harrydevnull

@harrydevnull

implicit val streamDecoder: Decoder.Aux[Witness.`”application/octet-stream”`.T, PDF] = Decoder.of(“application/octet-stream”) {
  response => fnFromBufToPDF(response.content)
}

i wanted something on that lines...

jeremyrsmith

@jeremyrsmith

yeah, actually though the function has to return Validated[PDF]

harrydevnull

@harrydevnull

implicit val streamDecoder: Decoder.Aux[Witness.`”application/octet-stream”`.T, Arrya[Byte] = Decoder.of(“application/octet-stream”) {
  response => fnFromBufToPDF(response.content)
}

may be?

jeremyrsmith

@jeremyrsmith

err ValidatedNel[Throwable, PDF]

harrydevnull

@harrydevnull

cool I think I have enough to play with

jeremyrsmith

@jeremyrsmith

yeah, in that case you’d want to just extract the byte array from the Buf, which there is an API for

harrydevnull

@harrydevnull

thank you @jeremyrsmith

jeremyrsmith

@jeremyrsmith

apologies for lack of any work on featherbed, keep meaning to merge #61 and then open up the maintainer chair, but can never find the time

harrydevnull

@harrydevnull

There was one another place I was stuck was making PUT request

Jarod Belshaw

@jbelshaw-c7ks7s

I have a (hopefully simple) featherbed question...

i'm getting an error in my test..

java.lang.NoSuchMethodError: io.circe.Printer.copy(ZZLjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Lio/circe/Printer;

i'm not sure where that's coming from. the function being called is ...

```def createSession(client: Client): String = {
val d = SSession("spark", "spark1")
val headers = """{'Content-Type': 'application/json'}"""
val req = client.post("/sessions").withContent(d, "application/json")

Await.result {
  req.send[Response]() map {
    response => response.contentString
  }
}

}```

Jarod Belshaw

@jbelshaw-c7ks7s

ok, some searching on here would indicate this is a dependency conflict issue?

harrydevnull

@harrydevnull

@jbelshaw-c7ks7s yeah you have a Circe dependency conflict

Where communities thrive

People

Repo info

Activity