finagle/finagle-postgres

PostgreSQL protocol support for Finagle

Ben Spencer

@dangerousben

what's supposed to happen if a ValueDecoder throws an exception?

from the code it looks rather like it will silently return null :|

jeremyrsmith

@jeremyrsmith

ValueDecoder returns a Try… IIRC there are places where the error is silently discarded (and you get null or 0) but there should be parallel APIs that give you the Try. My fault, sorry – maybe it should throw there, but it would have been a pretty big behavior change I think

i.e. https://github.com/finagle/finagle-postgres/blob/master/src/main/scala/com/twitter/finagle/postgres/Responses.scala#L84 (there is a doc comment not to use it if you care about keeping failures… not really good enough I know, but I didn’t want to introduce exception-throwing behavior into existing Row APIs)

Ben Spencer

@dangerousben

does anyone know what might cause this:

WARNING: channelOpen() called when channel was already open, clobbering an existing timer

Ben Spencer

@dangerousben

hmm might be because my integration tests are creating multiple clients with the same details and not cleaning them up

Stefan Dietiker

@d-s-d

If I await the result of a Future (e.g., Await.result(future, Duration(10, TimeUnit.SECONDS))) and run into a time-out, is the underlying database-transaction aborted?

Ben Spencer

@dangerousben

I think probably not, but I'd test it to be sure

jilen

@jilen

Is finagle postgres still maintained ?

Vladimir Kostyukov

@vkostyukov

@jilen Yea, @leonmaia is the current maintainer. @jeremyrsmith (previous maintainer) and myself contribute ocasionally.

Leon Maia

@leonmaia

Master build green again... for some reason travis failed to build when I merged the lib upgrades, but now it's all green again :green_apple:

Ben Spencer

@dangerousben

any plans for a release in the near future? would quite like to upgrade to finagle 19.1.0

Leon Maia

@leonmaia

I'll do one today :+1:

Ben Spencer

@dangerousben

nice one, thanks :)

Leon Maia

@leonmaia

0.8.3 should be live soon @dangerousben , couldn't do it yesterday my wife wouldn't let me open my computer during valentines :laughing:

Ben Spencer

@dangerousben

haha :)

thanks

Ben Spencer

@dangerousben

@leonmaia looks like finagle-postgres-shapeless didn't go out, this often seems to happen so I'm guessing it's missing from the release script or something?

Leon Maia

@leonmaia

The issue was that shapeless was not aggregated to the core project - this is fixed in my PR. I'll go ahead and merge it so we have this properly working.

Ben Spencer

@dangerousben

thanks again :)

Leon Maia

@leonmaia

no worries :)

Leon Maia

@leonmaia

ok, it worked as expected. @dangerousben I'll trigger a release 0.9.0now and you should now have both artifacts.

Ben Spencer

@dangerousben

great

darri89

@darri89

Hey guys, any plans for an ugprade to finagle 19.2.0? It appears they did some breaking API changes in that

Vladimir Kostyukov

@vkostyukov

@darri89 Looks your right; finagle/finagle-postgres#117 is failng.

Leon Maia

@leonmaia

Hi @darri89 thanks for the heads up. I'll have a look on it.

Leon Maia

@leonmaia

@darri89 I got a green build with 19.2.0, I'll be doing a new release tomorrow.

darri89

@darri89

@leonmaia great thanks!

Yarek T

@YarekTyshchenko

Hi. I'm trying to write a query that uses a WHERE (a, b) IN ((1, 2), (3, 4)) style of where clause. It looks like it's not possible to pass a Seq[T] as a param. Is there any way around this?

Yarek T

@YarekTyshchenko

Interestingly using sql"<query>" syntax works when passing a list of a type fine, but doesn't work with a Tuple, or a case class that has the two fields

jeremyrsmith

@jeremyrsmith

@YarekTyshchenko it looks like tuples should work: https://github.com/finagle/finagle-postgres/blob/master/finagle-postgres-shapeless/src/test/scala/com/twitter/finagle/postgres/generic/QuerySpec.scala#L92

can you post your query and the error(s) you get? Sorry, it’s been a while since I wrote that stuff and it’s not well documented :( There are some quirks of the query DSL that you can hopefully see in that spec

Yarek T

@YarekTyshchenko

This test should demonstrate the problem:

      "Seq of tuple params for IN operator" in {
        val p1 = Seq(("foo", "bar"), ("three", "four"))
        expectQuery("SELECT * FROM foo WHERE (a, b) IN (($1, $2), ($3, $4))", "foo", "bar", "three", "four") {
          sql"SELECT * FROM foo WHERE a IN ($p1)"
        }
      }

Its a bit of a weird syntax, but postgres does support it

@jeremyrsmith ^^.

Philippe Laflamme

@plaflamme

Hi, sorry for the noise, but I'm looking for feedback on finagle/finagle-postgres#128 I'd just like to know if it's something that will be considered for merging before adding more commits...

Philippe Laflamme

@plaflamme

Bump ^

jeremyrsmith

@jeremyrsmith

@plaflamme I think it’s a good direction. I’d merge it if it were fleshed out a bit; I’d just try to minimize API breakage if possible.

Philippe Laflamme

@plaflamme

Great, thanks for the feedback! It's been a while, so what parts of it would need to be more "fleshed out"? Happy to do those first. I'll see what I can do for the API breakage...

Philippe Laflamme

@plaflamme

@jeremyrsmith I've added the remaining bits and also undone the API breakage. Please take a look finagle/finagle-postgres#128

Philippe Laflamme

@plaflamme

@dangerousben @leonmaia Any chance we can get a 0.12.0 release with the latest changes (https://github.com/finagle/finagle-postgres/compare/v0.11.0...master)?

Ben Spencer

@dangerousben

I don't have access to cut a release (afaik), if @leonmaia's not around then @vkostyukov might

jeremyrsmith

@jeremyrsmith

I have access but TBH I’m not sure how it works anymore. I used to basically just sbt +publish but it uses a more complicated (undoubtedly better) process now. Maybe linked to github releases?

Leon Maia

@leonmaia

For generating a new release you just need to update version.sbt with the new release number removing the snapshot tag. The rest is done automagically :)

Sorry - I'm not using postgres at work, moved to mysql and been very busy for the last year working with Kafka. So I'm not with the time to be 'very' active here.

I'll merge the update PRs from scala-stewart and tag a new release.

Leon Maia

@leonmaia

v0.12.0 has been published @plaflamme, thanks a lot for the contribution! Release notes: https://github.com/finagle/finagle-postgres/releases/tag/v0.12.0

Philippe Laflamme

@plaflamme

Thanks so much! BTW: the Kafka work you are referring to, is that related to Finagle? Being curious, because we have a finagle-kafka client and are wondering if people are willing to contirbute

Leon Maia

@leonmaia

I'll DM you so we don't pollute here too much with off-topic :)

Ben Spencer

@dangerousben

thanks @leonmaia! (and @plaflamme for the code)

Where communities thrive

People

Repo info

Activity