@JanBessai Sorry I’m probably late to the party, but I’m curious why you want to expose
Resource. We use it internally in a couple of places, but it’s always hidden from they users behind a IO.
@vkostyukov
Not yet for now.
I tried to replace the following code (which in class 'EncodeEnumerator' of finchx-iteratee package)
final def apply(cb: Either[Throwable, Unit]): IO[Unit] = IO.unitto
final def apply(cb: Either[Throwable, Unit]): IO[Unit] = cb match {
case Right(_) => IO.unit
case Left(error) => IO.raiseError(error)
}After that, the program can throw the exception, but it still can't handle the Exception.
I'm not very familiar with the cats.IO.
If you can give me some hints, I would very appreciate for your.
@vkostyukov thanks for your reply! You are not too late, I decided to work on other stuff first. I'm implementing a server to host jgit instances populated with generated files. The resource is a git repository which is stored on the server's disk, has state and is created/destroyed when the server starts/shuts down. From how I understood the documentation resource seems appropriate for that rather than just IO
@zhangzhonglai I think the key problem here is that the it’s probably too late to respond with 400 when the stream fails. We’re already passed the point of sending headers back (and the response status) to the client. I’d imagine you can still do something along those lines by returning
IO.raiseError instead.
@JanBessai Yes, you’re on point about this. Have you seen
Endpoint.fromInputStream? It operates on Resource and, I belive, should suite your needs well.
Hi all, a newbie question: how to bind a trait to Endpoint? I want something as the following
sealed trait Message
case class GoodMessage(goodMessage: String)
case class BadMessage(badMessage: String)
def hello: Endpoint[IO, Message] = get("hello" ) {
Ok(GoodMessage("good"))
}
@octavz hi. I research for a zio and finch compatibility.
I'll share results soon. You should pay attention to finagle/finch#1138
Fix for this issues is not in 0.3.0 I guess.
You should know that it's extremely painful to deal with Endpoint's in ZIO style, cause it parametrized with invariant F (because cats effect). So you should explicitly define types everywhere.
My typical endpoint now looks like:
class Todo[R <: TodoRepository] extends EndpointModule[TaskR[R, ?]] {
type TodoTask[A] = TaskR[R, A]
def getAll: Endpoint[TodoTask, List[TodoItem]] = get("todos") {
val task: TodoTask[List[TodoItem]] = TodoService.getAll
task.map(Ok)
// or
// TodoService.getAll.map(Ok): TodoTask[Output[List[TodoItem]]
}
}I looking for a better solution. Let me know if you find it
indeed it seems it is in master, but not yet released
can i get a nightly build from somewhere ?
These are against Finagle 19.8.
and effect seems to have maintained binary compatibility with 1.x
not for finagle-http though :(
s/think/hope
It's unlikely we're going to release next finch until 19.10 which hopefully will support 2.13
ive got finch error encoding setup
implicit val encodeExceptionCirce: Encoder[Exception] = Encoder.instance {
case e: Error => errorToJson(e)
case Errors(nel) => Json.arr(nel.toList.map(errorToJson): _*)
}
def errorToJson(e: Error): Json = ErrorResponse(Option(e.getMessage).getOrElse("No error message available")).asJson
final case class ErrorResponse(message: String)
but I can't seem to see it in the response.contentString, the value is ""
A bad request is returned in the status code but no message in the contentString
Set it up, similar to docs example http://finagle.github.io/finch/cookbook.html#converting-errors-into-json but I dont handle types of errors, should not make a difference though
and use some
FunctionK to convert F ~> G
shouldn't be too hard:
final def mapK[G[_]](self: Endpoint[F, A])(nat: FunctionK[F, G]): Endpoint[G, A] =
new Endpoint[G, A] {
final def apply(input: Input): Endpoint.Result[G, A] = self(input) match {
case EndpointResult.Matched(rem, trc, out) =>
EndpointResult.Matched(rem, trc, nat(out))
case skipped: EndpointResult.NotMatched[F] => skipped.asInstanceOf[EndpointResult[G, A]] //should be safe to do, there are no effects on skipped results
}
override def item = self.item
final override def toString: String = self.toString
}