Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 11 12:30
    scala-steward closed #1410
  • Oct 11 12:30
    scala-steward commented #1410
  • Oct 11 12:30
    scala-steward opened #1415
  • Oct 06 07:30
    sergeykolbasov commented #1407
  • Sep 30 12:22
    sergeykolbasov commented #1407
  • Sep 27 15:28
    sachins301 commented #73
  • Sep 25 08:01
    spockz commented #1407
  • Sep 19 08:16
    scala-steward closed #1397
  • Sep 19 08:16
    scala-steward commented #1397
  • Sep 19 08:16
    scala-steward opened #1414
  • Sep 18 05:01
    scala-steward closed #1403
  • Sep 18 05:01
    scala-steward commented #1403
  • Sep 18 05:01
    scala-steward opened #1413
  • Sep 17 21:43
    scala-steward closed #1376
  • Sep 17 21:43
    scala-steward commented #1376
  • Sep 17 21:43
    scala-steward opened #1412
  • Sep 16 22:29
    scala-steward closed #1405
  • Sep 16 22:29
    scala-steward commented #1405
  • Sep 16 22:29
    scala-steward opened #1411
  • Sep 16 11:19
    scala-steward closed #1387
Georgi Krastev
@joroKr21
So I'm not sure if this then means that this release note is not quite true
Or was that Scala 2.11?
Or perhaps that is source incompatibility?
Sounds like you got a compile error
Georgi Krastev
@joroKr21
Is there a PR or branch to Caliban? I couldn't find one.
Dermot Haughey
@hderms
I was working on it locally
let me see about making a PR
Dermot Haughey
@hderms
@joroKr21 full compile error is:
Dermot Haughey
@hderms
to be honest I haven't looked into it much so it's quite possible the determination it was a library incompatibility problem was in error
Pierre Ricadat
@ghostdogpr
Yes, zio-interop-cats is using the new Parallel that appeared in cats-effect 2.0.0, therefore it doesn’t compile with cats-effect 1.x
Georgi Krastev
@joroKr21
Cool, so it should be fine to compile (and run) with cats-effect 2.x
At least on Scala 2.12
Georgi Krastev
@joroKr21
Yeah it works fine for me if I add an explicit dependency on cats-effect 2.0.0
I don't know why zio-interop-cats doesn't fix the version (is it optional?)
Pierre Ricadat
@ghostdogpr
ah yeah it's optional because some people only want the interop with cats
thanks for the help!
@hderms fyi :)
Georgi Krastev
@joroKr21
oh right :thumbsup:
Dermot Haughey
@hderms
Sweet guys thanks
Dermot Haughey
@hderms
Can someone explain what the particular issue was? Did I have access to some other version of cats effect based on a transitive dependency or something?
Pierre Ricadat
@ghostdogpr
yes, finch transitively made you use cats-effect 1.4.0. Since zio-interop-cats marked the dependency on cats-effect Optional, it didn't bring 2.0.0 for you
and zio-interop-cats is using some stuff from 2.0.0 that is not in 1.4.0
Dermot Haughey
@hderms
ah that makes sense
my knowledge of SBT is very limited
Vinh Vu
@Vinh-Vu-ck
Hey all! I am currently using the multipart fileupload, however, I’ve run into some issues where large files aren’t uploadable if the server doesn’t have enough memory/disk space to serve the request. Is there anyway I can stream the file contents?
Vladimir Kostyukov
@vkostyukov
@Vinh-Vu-ck You can surely do generic byte-level streaming but there is no really a support to parse that stream as a multipart message. Do you control your client? Can you change that as in “dowgrade to a regular byte-streaming” as opposed to multipart file upload?
Vinh Vu
@Vinh-Vu-ck
Yes, I control my client
An option we are considering is sticking with the multipart file upload, but we have been receiving 413 Request Entity Too Large for files above 100MB. We tried using .withMaxRequestSize(StorageUnit.fromGigabytes(1L)), but then our endpoint returns 404 instead. Without the .withMaxRequestSize call, we get a 413. Is this expected? Anything I’m missing?
Vladimir Kostyukov
@vkostyukov
@Vinh-Vu-ck That doesn’t sound right, especially the 404 part. The default limit is 5mb and I belive it’s bypassed when the payload is streamed. I remember it was changed recently in Finagle too. Let me look around a bit.
Vladimir Kostyukov
@vkostyukov
This is the change I was refering to: twitter/finagle#781
This still doesn’t not explain 404 you’ve been seeing. If there any other proxy sitting in fron of Finch server in your setup?
Vinh Vu
@Vinh-Vu-ck
There is no proxy sitting in front of Finch
pra527vin
@pra527vin
Is there way to log request coming in finch?
Ryan Plessner
@rpless
hi @pra527vin. It depends on whether you are using the finchx or finch artifacts. If you are using the finchx builds there is an example in the middleware example app https://github.com/finagle/finch/blob/master/examples/src/main/scala/io/finch/middleware/Main.scala#L39-L43. if you are using the finch builds you can use a finagle filter https://twitter.github.io/finagle/guide/ServicesAndFilters.html
Dermot Haughey
@hderms
not to be pessimistic but given how long it's taken finagle to support 2.13, I'm wondering what it will be like when Scala 3 finally drops. No blame towards finagle, given it's a part of a huge ecosystem and it's not a trivial effort
Sergey Kolbasov
@sergeykolbasov
not to mention things like Spark :eyes:
Sergey Kolbasov
@sergeykolbasov
well, there will be quite an earth shake in the whole Scala ecosystem for a while, but it's fiiine
Georgi Krastev
@joroKr21
well there is something to be said about companies being slow to update
e.g. Twitter doesn't care much about 2.13 so the Finagle update is a community effort
Hamdi Allam
@hamdiallam
I wouldn't say this is true. There's a lot that goes into an update. (performance regressions / breaking changes in the language). It's an effort to do at scale
Georgi Krastev
@joroKr21
Yeah and it brings little business value
So most companies don't care much and it's fine to admit it
pacman899
@pacman899

Hey, Im updating my company code to use the finchx versions (adding the F[_]). we have these -

FuturePool.unboundedPool { ....endpoint logic  }

in all our endpoints. should this be replaced with something else? or can I just delete this?

pacman899
@pacman899
not sure if something similar to FuturePool that works with cats.effect.ContextShift is needed 🤔?
pacman899
@pacman899
Im almost sure I can just delete the FuturePool and get the same logic for "free" from the F[_] change
Ryan Plessner
@rpless
@pacman899 yep! A context shift is what you want there. you could also shift on to an ExecutionContext if you are using those currently
Dermot Haughey
@hderms
@hamdiallam agreed. based on having been following the 2.13 stuff in finagle, it was quite easy to introduce performance regressions
Bagus Jatikusuma
@BagusJatikusuma
hello everyone. i have a question regarding iteratee example in finch github repo. when i tried to compile it, compiler complained that it couldnt find implicit value for parameter io.finch.LiftReader when using jsonBodyStream. should i provide LiftReader as implicit val manually? or am i missing some imports?? anyway sorry for any grammar mistakes. english isnt my native language. i hope you'll understand my question.