Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jan 01 2016 11:35
    @tobscure banned @flame05
David Sevilla Martín
@datitisev
I PR'd as-is... hopefully it's good. At least it's something ;)
David Sevilla Martín
@datitisev
Something happened here (flarum/core)...
Screen Shot 2017-05-20 at 11.42.41 AM.png
Daniël Klabbers
@Luceos
@franzliedke do you have a sec to help me understand something, it's related to the WebAppView and the user added to it

I've been trying to add some default includes to all users loaded, but it seems that is not possible due to this:

https://github.com/flarum/core/blob/master/src/Http/WebApp/WebAppView.php#L444

and i can't add it to the serializer because the includes are resolved later on
i'm considering PR'ing an event to allow configuration of those relationships, or.. perhaps this logic should be done differently anyway, what do you think?
Toby Zerner
@tobyzerner
@Luceos That method used to just call the API to get the user document... we refactored it to save a query because we already have the user model on hand. But this is a valid concern, and I think we probably need to revert back to the old method of calling the API.
Daniël Klabbers
@Luceos
I'll open an issue
allows us to keep track of the outcome of a discussion then
thanks @tobscure
Toby Zerner
@tobyzerner
:+1:
Daniël Klabbers
@Luceos
Did anyone notice 401 on discuss lately?
and after mentioning ralkage I get a 401
image.png
so .. accustomed to being logged out, did a hard refresh
but no luck
i saw another report somewhere here on gitter flarum/flarum
image.png
{errors: [{status: "401", code: "permission_denied"}]}
errors
:
[{status: "401", code: "permission_denied"}]
0
:
{status: "401", code: "permission_denied"}
code
:
"permission_denied"
status
:
"401"
so weird
i'll try log out and in
Confirmed, so what happens the mention pop up shows users in the js store, but the users query fails
@jordanjay29 @franzliedke @tobscure did that update for permissions for the users list get deployed and was the permission not set up correctly?
Toby Zerner
@tobyzerner
@Luceos that seems to be it! I've changed the permission, let me know if it's still not working
thanks for that
Franz Liedke
@franzliedke
401 and "permission_denied" is also weird ;)
Daniël Klabbers
@Luceos
it's fixed @tobscure
yes that should be a 403, right @franzliedke
Franz Liedke
@franzliedke
Or another text. I would have to look up the details to decide.
David Sevilla Martín
@datitisev
We need to have messages in these exceptions so the user knows why and so we can debug problems. Davis brought it up, and it's probably something that we should have.
David Sevilla Martín
@datitisev
um what happened on github?
image.png
there's been no activities in any of these issues
except the last one
Daniël Klabbers
@Luceos
he got banned
was spam
David Sevilla Martín
@datitisev
Ah, ok. Good to know Github isn't messing with me.
Charlie
@CDK2020
@tobscure Do you have any idea when I can expect beta 8 to be out? I'm going to be making an extension that registers all of the old namespaces (pre next-back) so that forum admins can somewhat continue to use extensions that aren't updated until someone can update them
or @franzliedke :)
Franz Liedke
@franzliedke
Depends on how long we will need to finish the milestone.
Thanks for your PRs!
Toby Zerner
@tobyzerner
Good idea @CDK2020! Yeah hard to say at this point, we might end up splitting into b8 and b9 as well
Charlie
@CDK2020
@franzliedke of course!
@tobscure Sounds good!
Franz Liedke
@franzliedke
I faintly remember an issue about API responses being truncated because of the Content-Length header... but I cannot find the issue anymore.
This is probably fixed with the latest Diactoros release: https://github.com/zendframework/zend-diactoros/releases/tag/1.6.0
Franz Liedke
@franzliedke
I have rebased flarum/core's next-back branch on a newer commit of master, so that it is consistent with all extensions' next-back branches.
Toby Zerner
@tobyzerner
Awesome thanks :+1: