floraison/flor

a ruby workflow engine

Danny Fullerton

@northox

We're having an issue with the hooks and you appreciate if you could chime in a little.

John Mettraux

@jmettraux

ok, I will try

Danny Fullerton

@northox

We have { point: return, consumed: true, require: 'pollen/pollen.rb', class: 'ReturnedPollenHook' }, within envs/dev/lib/hooks/hooks.json to mostly observe the payload evolve but ReturnedPollenHook is never called.

we see the return ('ReturnedPollenHook') loaded at executor.traps_and_hooks flor/unit/hooker.rb:54
we see the instance at lib/flor/unit/hook.rb to_hook
we see that there is a message with point: return and consumed: true being created and propagated - but not to the return() hook specifically.
Not sure where to go from here. Any pointers?

John Mettraux

@jmettraux

let me try to build a spec that reproduces that...

Danny Fullerton

@northox

We do get the payload at the end via terminated though.

John Mettraux

@jmettraux

so the hook is not called

Danny Fullerton

@northox

Yes, only return is not being called.

John Mettraux

@jmettraux

I'm wiring a hook into quickstart1/ the quickstart of flor

John Mettraux

@jmettraux

OK, I have a reproduction case

Danny Fullerton

@northox

oh great

John Mettraux

@jmettraux

if, in the hooks.json, I write point: "return" instead of point: return, it seems to work

Danny Fullerton

@northox

Next time, we'll do the same in quickstart to derive some specs.

John Mettraux

@jmettraux

Danny Fullerton

@northox

That's strange. All are wrote like so:

[
  { point: execute, consumed: true, nid: '0', require: 'pollen/pollen.rb', class: 'LaunchedPollenHook' },
  { point: return, consumed: true, require: 'pollen/pollen.rb', class: 'ReturnedPollenHook' },
  { point: terminated, consumed: true, require: 'pollen/pollen.rb', class: 'TerminatedPollenHook' },
  { point: failed, consumed: true, require: 'pollen/pollen.rb', class: 'FailedPollenHook' },
]

John Mettraux

@jmettraux

try to wrap return in quotes or double quotes...

Danny Fullerton

@northox

Seems like the syntax highlighter figure it for me. But I wonder what changed as it use to work.

John Mettraux

@jmettraux

test bench at: https://github.com/jmettraux/issue_flor_hook_20201126

Danny Fullerton

@northox

Will do.

John Mettraux

@jmettraux

so the error appeared with the latest version of flor?

Danny Fullerton

@northox

When we upgraded something but it's not quite clear what. We changed to many things at the same time. But hey, we won't spend more time on this. The fix is pretty simple.

John Mettraux

@jmettraux

I think I had a similar issue this morning, that's why I tried quoting

Danny Fullerton

@northox

Thanks for your help, we were getting nowhere on our end.

John Mettraux

@jmettraux

well at first I tried with point: executeand it worked as expected, then I tried point: "return"...

You're welcome, thanks for pointing at this issue! I will add a GitHub issue for it tomorrow morning

Danny Fullerton

@northox

And I'll update pollen and all.

John Mettraux

@jmettraux

If you need more help, don't hesitate

Jean-François Rioux

@jfrioux

so the error appeared with the latest version of flor?

When we moved from 0.17.0 to 0.19.0+

John Mettraux

@jmettraux

Hello @jfrioux ! Thanks for the info

Jean-François Rioux

@jfrioux

We're running our dev at the latest version since... August :)

So we can stay current and don't fall beind

Thanks for the quick fix once again!

John Mettraux

@jmettraux

You're welcome!

Hassan Gul

@hgmdesigns

Hey @jmettraux!

John Mettraux

@jmettraux

Hello @hgmdesigns !

Hassan Gul

@hgmdesigns

Looks like you are having good effort going on here.
I am new to ruby world.
I am building a marketing automation tool, where users define their workflows and that get executed based on events. I am exploring my options to find something that is going to help me.

I have looked other options, but Flor feels like to be one that is going to make my life most easier.

John Mettraux

@jmettraux

ok, if you're new to Ruby, it will be difficult :-(

Hassan Gul

@hgmdesigns

I have been working on my current project for last 2 months in RoR, so far I have been able to do more than what I would have expected myself to do. So I want to give Flor a try.

I plan to return back after trying it :)

John Mettraux

@jmettraux

OK, I'll help as best as I can

Hassan Gul

@hgmdesigns

Thank you! I would really appreciate your help.

John Mettraux

@jmettraux

Feel free to use issues as well: https://github.com/floraison/flor/issues

for asynchronous help

Hassan Gul

@hgmdesigns

thumbs up :)

Yeo Eng Guan

@egyeo-ms

where can I find flosh ? shell for flor

John Mettraux

@jmettraux

@egyeo-ms hello, you can find it in the flor repo itself bin/flosh

https://github.com/floraison/flor/tree/master/bin

it's not part of the gem, but it's easy to copy the script and use it from your environment

Yeo Eng Guan

@egyeo-ms

thanks john

John Mettraux

@jmettraux

you're welcome!

Where communities thrive

People

Repo info

Activity