Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Rick Lupton
    @ricklupton
    Welcome to the floWeaver gitter room! Don't hesitate to make the first post :smile:
    Neil Pilgrim
    @neiljp
    Hi, anything happening with the sprints yet?
    @ricklupton
    Rick Lupton
    @ricklupton
    We've had some documentation fixes and a new logo!
    Are you interested in getting involved?
    (sorry I'll be replying slowly for the next couple of hours)
    Neil Pilgrim
    @neiljp
    Apologies, I was travelling and the updates were slow coming in, and there are lots of projects to choose between!
    I'm comfortable with python so I'll download and have a look around
    Rick Lupton
    @ricklupton
    Great, let me know if you have any questions!
    Neil Pilgrim
    @neiljp
    Is anyone else actively working today, do you know?
    The no-py2 fix is in, right?
    Rick Lupton
    @ricklupton
    @apw10 and @dnuka have made some fixes to the documentation: https://github.com/ricklupton/floweaver/commits/master
    Updated the setup.py compatibility listings; there was a suggestion to actively check and give a warning if anyone tries, but I'm not sure that's worth it. There was also a request to make it Python 2 compatible (ricklupton/floweaver#23)
    But personally I'd rather focus on fixing things and adding features in Python 3
    I haven't had time to properly work on it today myself but I will be more tomorrow
    Neil Pilgrim
    @neiljp
    I've worked on type annotations on other projects; would that be of any interest? (that would rule out python2, if going for the python3-style, of course, though they can be done using comments too)
    Rick Lupton
    @ricklupton
    What kind of thing would you like to do? A simple check could be ricklupton/floweaver#25; a simple feature to add would be ricklupton/floweaver#4
    That sounds interesting, not something I'd considered. Would be benefit be in easier future development with type safety, or would it help users who are using floweaver's API?
    Another good project that I haven't actually listed as an issue would be to do some profiling/optimisation.
    Neil Pilgrim
    @neiljp
    I've used it extensively in the Zulip codebases, and somewhat elsewhere (there's a Pillow fork with some)
    The quite pleasant aspect is seeing parameter and return types documented in the code, and able to be checked statically (not normally at run-time).
    I'm just looking at the quickstart
    Rick Lupton
    @ricklupton
    :+1: I like static types :smile:
    Neil Pilgrim
    @neiljp
    Do you use pytest?
    Rick Lupton
    @ricklupton
    Yes
    Neil Pilgrim
    @neiljp
    ah right, git grep is my friend :)
    Neil Pilgrim
    @neiljp
    tests passed after manually installing pytest & matplotlib.
    Neil Pilgrim
    @neiljp
    A sample raise doesn't appear to work for detecting the version; would working in networkx be feasible/desirable?
    Rick Lupton
    @ricklupton
    Sorry, not sure what you mean?
    Rick Lupton
    @ricklupton
    I'm off now, I'll be back in the morning at the sprint :wave:
    Rick Lupton
    @ricklupton
    Thanks for getting involved and hope you enjoy the rest of your day!
    Neil Pilgrim
    @neiljp
    Re networkx, I missed 2 be feasible/explored?
    Also looking at Excel