Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Neil Pilgrim
    @neiljp
    Apologies, I was travelling and the updates were slow coming in, and there are lots of projects to choose between!
    I'm comfortable with python so I'll download and have a look around
    Rick Lupton
    @ricklupton
    Great, let me know if you have any questions!
    Neil Pilgrim
    @neiljp
    Is anyone else actively working today, do you know?
    The no-py2 fix is in, right?
    Rick Lupton
    @ricklupton
    @apw10 and @dnuka have made some fixes to the documentation: https://github.com/ricklupton/floweaver/commits/master
    Updated the setup.py compatibility listings; there was a suggestion to actively check and give a warning if anyone tries, but I'm not sure that's worth it. There was also a request to make it Python 2 compatible (ricklupton/floweaver#23)
    But personally I'd rather focus on fixing things and adding features in Python 3
    I haven't had time to properly work on it today myself but I will be more tomorrow
    Neil Pilgrim
    @neiljp
    I've worked on type annotations on other projects; would that be of any interest? (that would rule out python2, if going for the python3-style, of course, though they can be done using comments too)
    Rick Lupton
    @ricklupton
    What kind of thing would you like to do? A simple check could be ricklupton/floweaver#25; a simple feature to add would be ricklupton/floweaver#4
    That sounds interesting, not something I'd considered. Would be benefit be in easier future development with type safety, or would it help users who are using floweaver's API?
    Another good project that I haven't actually listed as an issue would be to do some profiling/optimisation.
    Neil Pilgrim
    @neiljp
    I've used it extensively in the Zulip codebases, and somewhat elsewhere (there's a Pillow fork with some)
    The quite pleasant aspect is seeing parameter and return types documented in the code, and able to be checked statically (not normally at run-time).
    I'm just looking at the quickstart
    Rick Lupton
    @ricklupton
    :+1: I like static types :smile:
    Neil Pilgrim
    @neiljp
    Do you use pytest?
    Rick Lupton
    @ricklupton
    Yes
    Neil Pilgrim
    @neiljp
    ah right, git grep is my friend :)
    Neil Pilgrim
    @neiljp
    tests passed after manually installing pytest & matplotlib.
    Neil Pilgrim
    @neiljp
    A sample raise doesn't appear to work for detecting the version; would working in networkx be feasible/desirable?
    Rick Lupton
    @ricklupton
    Sorry, not sure what you mean?
    Rick Lupton
    @ricklupton
    I'm off now, I'll be back in the morning at the sprint :wave:
    Rick Lupton
    @ricklupton
    Thanks for getting involved and hope you enjoy the rest of your day!
    Neil Pilgrim
    @neiljp
    Re networkx, I missed 2 be feasible/explored?
    Also looking at Excel
    Rick Lupton
    @ricklupton
    Ah as in upgrading to be compatible with version 2? Yes, definitely.
    Welcome back!
    Neil Pilgrim
    @neiljp
    Just heading out to it soon
    Rick Lupton
    @ricklupton
    I've added the missing developer docs about the tests now! https://github.com/ricklupton/floweaver/pull/44/files
    But I guess you've figured it out already :)
    Neil Pilgrim
    @neiljp
    For the most part :)
    Rick Lupton
    @ricklupton
    I'm heading home now, I'll check back a bit later
    Neil Pilgrim
    @neiljp
    Right, which timezo btw?
    *timezone
    Neil Pilgrim
    @neiljp
    @ricklupton #46
    Rick Lupton
    @ricklupton
    Thanks! Commented on the PR.
    I'm in Cambridge, UK, so almost finished for today
    Neil Pilgrim
    @neiljp
    Yeah, figured you might be by the timing :)
    the time/material files would go with the fruit ones?
    Rick Lupton
    @ricklupton
    Yep, that's right (corresponding id's to the material and time columns in the flows table)
    Neil Pilgrim
    @neiljp
    :thumbsup:
    Rick Lupton
    @ricklupton

    Hi MozSprint contributors!

    Thanks again for getting involved during the sprint and giving up your time to work on the project. If you have a few minutes more, it'd be really helpful to hear how you found that experience and understand what to do differently next time. If you don't mind giving some feedback, please fill out this quick form here:
    https://goo.gl/forms/XqmQ9eNNtNTEkrD93

    Thanks,
    Rick

    paantz
    @paantz
    Hi Rick, is there a way to add some kind of 'hatching' on the links with possible color mix ?
    Rick Lupton
    @ricklupton
    Although I'm not sure if you can do hatching in pure CSS -- this suggests you need to add additional elements to the SVG: https://stackoverflow.com/questions/13069446/simple-fill-pattern-in-svg-diagonal-hatching
    You can always export the Sankey diagram to SVG and edit it with something like Inkscape if you want to do fancy things @paantz
    Michael
    @yourselvs
    Hey Rick, I've gotten a lot of great results with floWeaver visualizing various flows. The GitHub page mentions embedding in web pages or interactive apps, but I didn't see anything elsewhere in the documentation. Is there any more info about embedding or interactivity somewhere?
    Rick Lupton
    @ricklupton
    Hi Michal, great to hear you've been finding it useful. There's not much documentation about that at the moment I'm afraid. The basic idea is to use the to_json method, to save the prepared data to a file, instead of the to_widget method used in the examples which shows it directly in a Jupyter notebook. Then load the data in a web page and render it using d3-sankey-diagram.
    It's on the roadmap to properly specify the JSON format -- I've not wanted to focus on docuemnting and giving examples of this until the format has stabilised. But if you want to give it a go I'm happy to answer questions and try to help.