Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:48
    marcoxa commented #1877
  • 14:47
    marcoxa commented #1877
  • 13:31
  • 13:31
    Travis carrete/flycheck (master) errored (20)
  • 13:23
    carrete synchronize #1842
  • Apr 13 23:18
    cpitclaudel commented #1877
  • Apr 13 20:38
    marcoxa commented #1877
  • Apr 13 19:57
  • Apr 13 18:56
    cpitclaudel closed #1877
  • Apr 13 18:56
    cpitclaudel commented #1877
  • Apr 13 18:11
    marcoxa opened #1877
  • Apr 13 18:11
    marcoxa labeled #1877
  • Apr 13 12:39
  • Apr 13 12:33
    Amorymeltzer opened #1876
  • Apr 13 12:07
  • Apr 13 12:03
    Amorymeltzer opened #1875
  • Apr 13 11:43
    Amorymeltzer edited #1874
  • Apr 13 11:10
    Amorymeltzer edited #1874
  • Apr 13 11:05
    Amorymeltzer labeled #1874
  • Apr 13 11:05
    Amorymeltzer opened #1874
Saša Jovanić
@Simplify
congratulations :)
Basti
@lunaryorn
@robbyoconnor Mind if I'm afk for a bit? Still at the office and would like to leave now :sunglasses:
Robby O'Connor
@robbyoconnor
:)
go home :)
Basti
@lunaryorn
word
Robby O'Connor
@robbyoconnor
nobody wants to be in work prison
i'm gonna keep going at this, don't merge it YET
It's quite annoying for myself to get these false errors
Basti
@lunaryorn
Don't worry, won't do before you ping us
Robby O'Connor
@robbyoconnor
and since im the guy writing it, well I'm gonna make it work
Robby O'Connor
@robbyoconnor
There's a blocker definitely a bug

$ pug -b /home/rob/pug/foo/bar/baz -p /home/rob/pug/foo/bar/baz < /home/rob/pug/foo/bar/baz/pug-extends.pug

it seems to assume the /home/rob/pug/foo/bar

Need to fix this before I continue

Aaron Jensen
@aaronjensen
when are predicates checked? every time before a check, right?
not just once
Robby O'Connor
@robbyoconnor
im not sure
Robby O'Connor
@robbyoconnor
Should have this done by tonight or tomorrow
I got it working
:)
Robby O'Connor
@robbyoconnor
Do you require tests for each error pattern @lunaryorn ?
So far I'm counting 3
Basti
@lunaryorn
@robbyoconnor At best, we'd have a test for each, but it's by no means mandatory… a single test is absolutely sufficient :)
@aaronjensen Predicates run each time a checker is invoked
They are supposed to be cheap and fast… if there's a more expensive check to be done for a checker that's best left to a separate extension that runs this check in a mode hook and disables the syntax checker via flycheck-disabled-checkers once
Saša Jovanić
@Simplify
than we really need place ESLint somewhere lower in whole chain
Basti
@lunaryorn
@Simplify Why?
we could run eslint --print-config in the predicate if it's not too slow
but thinking of it… why not introduce a new checker field, i.e. :enable whose value is a function which Flycheck calls the first time the checker is to be used in the current buffer. If the function returns nil the checker is put into flycheck-disabled-checkers
Basti
@lunaryorn
that'd let us automatically disable syntax checkers if the current buffer doesn't meet their requirements without running the check every time
Saša Jovanić
@Simplify
that is great idea
Basti
@lunaryorn
@Simplify Would you take a shot?
Saša Jovanić
@Simplify
yes, tomorrow I have time for that
Basti
@lunaryorn
awesome!
Saša Jovanić
@Simplify
I can check return value when running that command, it's not 0
Basti
@lunaryorn
yup
we can even discard its output to run faster
Robby O'Connor
@robbyoconnor
@lunaryorn I have a question: is it okay to take a substring of the output?
rather than the whole thing in the tests
I'm almost done :)
Robby O'Connor
@robbyoconnor
got it :)
Robby O'Connor
@robbyoconnor
@lunaryorn ready :D
and this time it works :)
I hit all error patterns
(I think)
I'm about 99% certain anyways :)
Robby O'Connor
@robbyoconnor
@lunaryorn @cpitclaudel flycheck/flycheck#1084 :) -- for some reason it doesn't linkify the flycheck/maintainers mention
Robby O'Connor
@robbyoconnor
er oops
Robby O'Connor
@robbyoconnor
@lunaryorn -- I'll address the changes later today
Robby O'Connor
@robbyoconnor
handled :) \
Tiago Sá Marques
@tsmarques
This message was deleted
Hey guys, does setting flycheck-clang-include-path work in recursive way?