Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 14:55
    theopenlab-ci[bot] commented #488
  • Jan 31 2019 14:46
    vadimstroganov starred fog/fog-openstack
  • Jan 31 2019 14:41
    vadimstroganov commented #487
  • Jan 31 2019 14:40
    vadimstroganov commented #487
  • Jan 31 2019 14:38
    vadimstroganov opened #488
  • Jan 31 2019 14:33
  • Jan 31 2019 12:24
    vadimstroganov opened #487
  • Jan 31 2019 09:36
    aufi labeled #486
  • Jan 31 2019 09:35

    aufi on master

    Created explicit mock and real … Merge pull request #486 from gi… (compare)

  • Jan 31 2019 09:35
    aufi closed #486
  • Jan 30 2019 16:38
    gildub closed #482
  • Jan 30 2019 16:38

    gildub on master

    Add multiattach parameter to vo… Merge pull request #482 from ma… (compare)

  • Jan 30 2019 16:38
    gildub commented #482
  • Jan 30 2019 16:23
    theopenlab-ci[bot] commented #486
  • Jan 30 2019 16:07
    gildub synchronize #486
  • Jan 30 2019 15:54
    gildub review_requested #486
  • Jan 30 2019 15:53
    gildub opened #486
  • Jan 30 2019 15:22

    gildub on master

    Fixed a couple of path to clear… Merge pull request #485 from gi… (compare)

  • Jan 30 2019 15:22
    gildub closed #485
  • Jan 30 2019 12:06
ioggstream
@ioggstream
so, you've plenty of work time :D
Bill Wei
@bzwei
3pm here
ioggstream
@ioggstream
Dinner time now! I have to push some C code -_- and go
C is still around
Bill Wei
@bzwei
Enjoy your dinner and evening time
ioggstream
@ioggstream
bye and thx++ again!
Bill Wei
@bzwei
@ioggstream I added a few small comments. In general it is very good now.
ioggstream
@ioggstream
@bzwei Hey! 'Morning there :D
checking
Bill Wei
@bzwei
Can you rebase and consolidate all the commits into just one?
Also you can remove [WIP] from the title.
ioggstream
@ioggstream
@bzwei 1- about deep_copy
are arrays copied or referenced in ruby?
Bill Wei
@bzwei
should be shallow, references
ioggstream
@ioggstream
otherwise I'd stick with the current implementation
which deep_copy everything != String
Bill Wei
@bzwei
why? In the get_template_contents you only allow string or hash
ioggstream
@ioggstream
it could be useful when we'll implement resource_registry
@bzwei when we'll decide to implement resource registry and environment files
we may need a deep_copy
supporting arrays
ioggstream
@ioggstream
I'm changing all your suggestions but deep_copy. if that's a game stopper I can change it too
Bill Wei
@bzwei
no. it is minor
ioggstream
@ioggstream
ok. then only the uri.encode|decode is open
I didn't find a suitable replacement because CGI & co replaces every char with %xx
not just spaces
Bill Wei
@bzwei
Can you give me an example of desired translation through encoding/decoding
ioggstream
@ioggstream
irb(main):057:0> x = URI.encode(URI.decode("http://ciao/tmp/a b.txt"))
irb(main):058:0>
instead, CGI & co replace : and / too
irb(main):061:0> x = CGI.escape(CGI.unescape("http://ciao/tmp/a b.txt"))
=> "http%3A%2F%2Fciao%2Ftmp%2Fa+b.txt"
we could even avoid supporting spaces in http uris
(which imho is just bad practice)
Jason Frey
@Fryguy
technically the + character is the accurate replacement for a space
but %20 also works
what are you trying to encode/decode @ioggstream
Bill Wei
@bzwei
can you download the file using "http%3A%2F%2Fciao%2Ftmp%2Fa+b.txt”?
Jason Frey
@Fryguy
you might be better off using CGI.escape/unescape only on the query_params part
ioggstream
@ioggstream
@bzwei not with open-uri
Jason Frey
@Fryguy
so split the URI with URI.parse, and only encode the parts you care about
ioggstream
@ioggstream
@Fryguy yes but an overkill as I'd like to delegate a lib
so that the lib will work around corner cases
Jason Frey
@Fryguy
what are you trying to solve though...like what is the actual issue?
ioggstream
@ioggstream
I want to replace spaces in http:// uris with %20
actually I wanted to retain the old
URI.encode(URI.decode()) behavior