Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 14:55
    theopenlab-ci[bot] commented #488
  • Jan 31 2019 14:46
    vadimstroganov starred fog/fog-openstack
  • Jan 31 2019 14:41
    vadimstroganov commented #487
  • Jan 31 2019 14:40
    vadimstroganov commented #487
  • Jan 31 2019 14:38
    vadimstroganov opened #488
  • Jan 31 2019 14:33
  • Jan 31 2019 12:24
    vadimstroganov opened #487
  • Jan 31 2019 09:36
    aufi labeled #486
  • Jan 31 2019 09:35

    aufi on master

    Created explicit mock and real … Merge pull request #486 from gi… (compare)

  • Jan 31 2019 09:35
    aufi closed #486
  • Jan 30 2019 16:38
    gildub closed #482
  • Jan 30 2019 16:38

    gildub on master

    Add multiattach parameter to vo… Merge pull request #482 from ma… (compare)

  • Jan 30 2019 16:38
    gildub commented #482
  • Jan 30 2019 16:23
    theopenlab-ci[bot] commented #486
  • Jan 30 2019 16:07
    gildub synchronize #486
  • Jan 30 2019 15:54
    gildub review_requested #486
  • Jan 30 2019 15:53
    gildub opened #486
  • Jan 30 2019 15:22

    gildub on master

    Fixed a couple of path to clear… Merge pull request #485 from gi… (compare)

  • Jan 30 2019 15:22
    gildub closed #485
  • Jan 30 2019 12:06
Bill Wei
@bzwei
Can you give me an example of desired translation through encoding/decoding
ioggstream
@ioggstream
irb(main):057:0> x = URI.encode(URI.decode("http://ciao/tmp/a b.txt"))
irb(main):058:0>
instead, CGI & co replace : and / too
irb(main):061:0> x = CGI.escape(CGI.unescape("http://ciao/tmp/a b.txt"))
=> "http%3A%2F%2Fciao%2Ftmp%2Fa+b.txt"
we could even avoid supporting spaces in http uris
(which imho is just bad practice)
Jason Frey
@Fryguy
technically the + character is the accurate replacement for a space
but %20 also works
what are you trying to encode/decode @ioggstream
Bill Wei
@bzwei
can you download the file using "http%3A%2F%2Fciao%2Ftmp%2Fa+b.txt”?
Jason Frey
@Fryguy
you might be better off using CGI.escape/unescape only on the query_params part
ioggstream
@ioggstream
@bzwei not with open-uri
Jason Frey
@Fryguy
so split the URI with URI.parse, and only encode the parts you care about
ioggstream
@ioggstream
@Fryguy yes but an overkill as I'd like to delegate a lib
so that the lib will work around corner cases
Jason Frey
@Fryguy
what are you trying to solve though...like what is the actual issue?
ioggstream
@ioggstream
I want to replace spaces in http:// uris with %20
actually I wanted to retain the old
URI.encode(URI.decode()) behavior
Jason Frey
@Fryguy
in any part of the URI, or only the query params or the path?
ioggstream
@ioggstream
as they are heat templates, the goal is to make it work with static files
and probably serving "foo.com/a heat template with spaces.yaml" is not a great deal too
Jason Frey
@Fryguy
i see...so there are potential spaces in the filename which you want to ensure work through a URI
if so, it sounds like the path portion of the URI...but you could just do uri.gsub(" ", "%20")
to use a library method though URI.encode/decode is what you want
ioggstream
@ioggstream
@Fryguy said you have
;)
ioggstream
@ioggstream
@bzwei @Fryguy I think we could either:
1- remove the whitespace check
2- stick with URI.encode(URI.decode(
Bill Wei
@bzwei
or simply do like @Fryguy said search/replace
ioggstream
@ioggstream
@bzwei ok for me
:D
ioggstream
@ioggstream
ok, pushing...
ioggstream
@ioggstream
I wrote a small docker-compose for developing fog-openstack
it's useful to test with different ruby versions
is it worth to be added to the project?
Bill Wei
@bzwei
@ioggstream I approved it. Thanks!
ioggstream
@ioggstream
@bzwei Great! :DDDDD
Thank you very much1
!
@bzwei should we get in touch with @Ladas or @seanhandley for the merge?
Bill Wei
@bzwei
yes
ioggstream
@ioggstream
Let me know if I should rebase everything in a single patch or if some sort of history is needed