Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 11 16:59
    aaronbell opened #507
  • May 28 08:11
    simoncozens opened #506
  • May 28 05:45
    simoncozens opened #505
  • May 28 05:37
    simoncozens opened #504
  • May 27 12:58
    jenskutilek closed #478
  • May 27 12:17
    anthrotype commented #503
  • May 27 12:17

    anthrotype on ttglyph-point-pen

    (compare)

  • May 27 12:17

    anthrotype on main

    Use new TTGlyphPointPen from fo… outlineCompiler_test: check TTG… Update FontTools dependency ver… and 1 more (compare)

  • May 27 12:17
    anthrotype closed #503
  • May 27 12:14
    google-cla[bot] commented #503
  • May 27 12:14
    jenskutilek commented #503
  • May 27 10:46
    anthrotype commented #503
  • May 27 10:45
    anthrotype commented #478
  • May 27 10:43
    anthrotype synchronize #503
  • May 27 10:43

    anthrotype on ttglyph-point-pen

    Update FontTools dependency ver… (compare)

  • May 27 10:40
    googlebot commented #503
  • May 27 10:39
    google-cla[bot] commented #503
  • May 27 10:39
    anthrotype review_requested #503
  • May 27 10:39
    anthrotype opened #503
  • May 27 10:38

    anthrotype on ttglyph-point-pen

    outlineCompiler_test: check TTG… (compare)

Cosimo Lupo
@anthrotype
but works
master_finder was a hack to begin with
convenient, though
Nikolaus Waxweiler
@madig
we hardcode ufo as the only source format then but maybe it's enough for now
Cosimo Lupo
@anthrotype
what about checking if it is not TTF or OTF ?
Nikolaus Waxweiler
@madig
woff, woff2
is there a constant of what ft can open?
Cosimo Lupo
@anthrotype
ah! we could try to load TTFont and if exception occurs, call masterfinder?
Nikolaus Waxweiler
@madig
hah :)
that could work
Cosimo Lupo
@anthrotype
use a broad except Exception:
TTLibError may not be enough..
:grin:
Nikolaus Waxweiler
@madig
:laughing:
might not be reliable if someone disabled woff(2) but eh
Cosimo Lupo
@anthrotype
they get ImportError then
Nikolaus Waxweiler
@madig
next time someone rebuilds varlib, make build accept only preloaded ds objects
oh right
ok then
Cosimo Lupo
@anthrotype
oh if you check ttFont.py and sfnt.py, it's safe to just catch TTLibError
Nikolaus Waxweiler
@madig
kay
Cosimo Lupo
@anthrotype
that's the fonttoolian way
Nikolaus Waxweiler
@madig
:grin:
every day i agree more with the view on http://joeduffyblog.com/2016/02/07/the-error-model/ that exceptions just aren't that good of an error handling mechanism
Cosimo Lupo
@anthrotype
sneaky rustacean
Nikolaus Waxweiler
@madig
:+1:
some of varlib's cryptic assertion failures give me nightmares
Cosimo Lupo
@anthrotype
can I merge to a branch upstream and pick up where you left?
@madig I meant this PR fonttools/fonttools#1416
Nikolaus Waxweiler
@madig
waaaait
Cosimo Lupo
@anthrotype
ok ok
Nikolaus Waxweiler
@madig
i'm about to green-light tox
once i find that damn bug
Cosimo Lupo
@anthrotype
take your time
Nikolaus Waxweiler
@madig
ah. TTFont(ufo) raises a IOError: [Errno 13] Permission denied... because it's a directory :grin:
Cosimo Lupo
@anthrotype
in the context of googlei18n/ufo2ft#310, I was thinking that the layerName keyword argument to compileOTF and compileTTF (which we added in the last release) doesn't make sense to be there in the public API
1) if one wants to produce a full font, but using the glyphs/metrics/etc. from a layer which is not the default, one can simply set the default layer to that layer, just before calling compile function
2) the compileInterpolatableTTFs function now treats the presence of layerName as a marker to produce a "sparse" TTF master, with only a minimal set of tables
I would like to deprecate/remove that layerName argument from compileOTF and compileTTF
Do you guys see any use of generating a complete font from a UFO using outlines/metrics (but also unicodes, all the stuff in GLIF files) from a non-default layer?
I don't.
Cosimo Lupo
@anthrotype
hm, it may be useful for debugging an intermediate "brace" master, where you need the full font to render those glyphs that are modified
i'll leave it in. I just don't like that the "compileInterpolatable*" functions return incomplete TTFonts for such layerName-sources, whereas the "compileOTF/TTF" functions return a whole TTFont.
Nikolaus Waxweiler
@madig
(currently busy with something else, will review later)
Cosimo Lupo
@anthrotype
thanks :+1:
Cosimo Lupo
@anthrotype
GitHub has built-in CI now, powered by Azure
Nikolaus Waxweiler
@madig
oho!
Cosimo Lupo
@anthrotype
wrong chat?
Nikolaus Waxweiler
@madig
yes