Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Alex Indigo
@alexindigo
time to put crazy things into our production code :)
code reviewers won't be able to test them :)
Dylan Piercey
@DylanPiercey
Lol
Dylan Piercey
@DylanPiercey
@alexindigo form-data/form-data#142 what do we need?
Alex Indigo
@alexindigo
Just trying different things that could monitor code quality on PRs.
Similar to Travis and Coveralls
But for code related things
Codacity has nice feature set, but integration is lacking
Dylan Piercey
@DylanPiercey
Previously I've used code-climate which seemed okay. Perhaps we should pick a linting tool first?
Can you link me codacity? Also I'm about to go to bed so I'll talk to you later :).
Alex Indigo
@alexindigo
Link you?
I'm getting more and more fanatical about eslint
It can check many things including jsdoc
Dylan Piercey
@DylanPiercey
Yeah eslint is good, I used it at my previous job. Also all I can find for codacity is https://www.codacity.com/ which I don't think is right?
Alex Indigo
@alexindigo
I'll check out code climate
Oh it's my internal illiterate:)
codacy.com
Got mixed with teamcity probably
Dylan Piercey
@DylanPiercey
:p thats fine. I'll check it out tomorrow :).
Alex Indigo
@alexindigo
I'm evaluating com environments at work :)
Btw, decided to go global vars for isomorphic? :)
Sweet dreams :)
Dylan Piercey
@DylanPiercey
:p Well it's suppose to be like a polyfill for node so it makes sense to me. Similar to https://github.com/matthew-andrews/isomorphic-fetch.
I really want to provide a real polyfill for ie9+ but I think it's gonna be hard :p.
Alex Indigo
@alexindigo
I'm still thinking on use case where globality would help it with isomorphism, in my view all isomorphic scripts being loaded/required via some kind load manager anyway, so all the dependencies get explicitly defined.
And nothing goes global.
Or did I miss something?
Dylan Piercey
@DylanPiercey
Well with browserify and webpack you can specify requires within the config as well, (usually a good spot for polyfills), which simply requires the file without having to do it explicitly in app code.
Since in the browser you are expecting form-data to be there it makes sense to make it global anyway since it would help people transitioning from dom code to isomorphic code.
Alex Indigo
@alexindigo
And Browserify would add it to the globsl space?
Dylan Piercey
@DylanPiercey
Yeah
Alex Indigo
@alexindigo
Didn't expect such behavior from Substack's creation :)
As for IE9 polyfill, find stream library that works there
Dylan Piercey
@DylanPiercey
:p it's not the most intuitive configuration but it works.
And the problem with IE9 is there is no fileapi / way to get file elements as blobs.
Alex Indigo
@alexindigo
and form-data itself is just thin layer on top
I see
Dylan Piercey
@DylanPiercey
form.append("myfile", document.querySelector("input[type='file']")
type thing.
Which means I will likely have to use flash or something.
Alex Indigo
@alexindigo
Understood
Or just wait for IE10-11 :)
Dylan Piercey
@DylanPiercey
:p.
Alex Indigo
@alexindigo
And I have another idea to try
Dylan Piercey
@DylanPiercey
Whats that?
Alex Indigo
@alexindigo
Automate pushes to npm via codeship or something like that
Created tag on github it pushed to npm automatically
Dylan Piercey
@DylanPiercey
That'd be cool, never thought of using tags for that.
Alex Indigo
@alexindigo
it's how many enterprises do deployment
For audit purposes and whatnot
Dylan Piercey
@DylanPiercey
Ah cool.