Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 02 19:00

    ParthS007 on gh-pages

    Travis CI Clean Deploy abad11d (compare)

  • Mar 02 18:54

    rajvaibhavdubey on development

    fixes version for marshmallow-j… (compare)

  • Mar 02 18:54
    rajvaibhavdubey closed #2186
  • Mar 02 18:54
    rajvaibhavdubey closed #2185
  • Mar 02 17:52
    gabru-md assigned #2185
  • Mar 02 17:52
    gabru-md commented #2185
  • Mar 02 17:40
    gabru-md review_requested #2186
  • Mar 02 17:40
    gabru-md opened #2186
  • Mar 02 17:39
    gabru-md closed #2077
  • Mar 02 17:39
    gabru-md commented #2077
  • Mar 02 17:30
    gabru-md opened #2185
  • Mar 02 17:21
    maze-runnar commented #2179
  • Mar 02 16:09
    Dishebh commented #2179
  • Feb 06 18:59
    iamareebjamal commented #2184
  • Feb 06 18:03
    PragatiVerma18 commented #2184
  • Feb 06 17:58
    PragatiVerma18 commented #2184
  • Feb 06 17:56
    PragatiVerma18 commented #2184
  • Feb 06 17:49
    iamareebjamal commented #2184
  • Feb 06 17:47
    PragatiVerma18 commented #2184
  • Feb 06 17:43
    PragatiVerma18 commented #2184
Rajat Verma
@rajat2502
Cool...can you please guide me from where to start to get started with the frontend using Reactjs. In which branch, etc...
Sundaram Dubey
@maze-runnar
@mariobehling @rajat2502 it was a part of the discussion https://github.com/fossasia/badgeyay/pull/2176#issuecomment-558141572
@iamareebjamal has said that we should go with Django templating as the project is not that UI intensive to use a separate frontend.
Sundaram Dubey
@maze-runnar
@mariobehling things should be start in badgeyay project but problem is the end goal of what it should look like, what are the features required, what is the roadmap is not clear . Even @codedsun also start working on that but models are not clear yet .
Mario Behling
@mariobehling
@maze-runnar The end goal is a working service that can generate badges and where people can pay for additional services.
The service should be similar to the current one but easier to maintain.
MUKESHSIHAG
@MUKESHSIHAG
Hi everyone, I am Mukesh from NIT Hamirpur. I want to contribute in badgeway project for Gsoc 2020. I have good experience in Python, Flask and web development. How can I start ?
Pragati Verma
@PragatiVerma18
Hi everyone, can someone guide me through the roadmap to v2, I want to contribute but things are quite unclear to me. Please share any screenshots or any idea of how badgeyay looked or worked because without an idea of that, I am unable to begin with.
Pragati Verma
@PragatiVerma18
The v2 backend enables login but no signup. Can I use Django rest framework to make a Users API that would allow login/signup easily? Also, do we need the token authentication or JWT authentication for badgeyay?
Areeb Jamal
@iamareebjamal
We'll be using inbuilt Django Authentication, so no need of JWT
For now, we'll be dealing with Django Templates, so no API. API will be built as/if needed by mobile clients
Pragati Verma
@PragatiVerma18
Are you going to use templating in react as well? We can have a frontend folder inside our Django project and an app for backend API such that the backend API runs on port 8000 and the frontend runs on 3000, this way you can have a uniform way for both phone and web applications and at the same time utilise the best of both Django and React?
Areeb Jamal
@iamareebjamal
No, no react. No JS needed for now. It's a pretty simple site. JS should be used for enhancements, like in github. The site you are writing this comment on is server side rendered and much better than any SPA I have used. What little enhancements they use JS for is fine. And wherever they use client-side rendering, it's always worse experience than server render. JS rendering should be used where you have highly dynamic UI and basically cannot do server render anyway - like infinite scrolling feeds in facebook/twitter with mariands of post types and dynamic media like picture albums/video. JS rendering anywhere else is not only unneeded but way poorer experience than server render. And then everyone still ends up rendering it on server using Next/Nuxt/Fastboot. Why go full circle and still do what we wanted to avoid in the first place, and in a much worse way?
utilise the best of both Django and React?
Best of Django is server rendering. Authentication and Authorization in SPA is terrible. You have separate routing in backend/frontend and leaks can happen way more easily as most people store credentials in local storage/JS readable cookies
Pragati Verma
@PragatiVerma18
Okay, I am sorry, the roadmap said react and django, so I started thinking that ways. May I fix the login/signup page existing for now?
Areeb Jamal
@iamareebjamal
Best of React is not needed in the site, as it does not have a complex UI. If needed, it can be added like it should be - in places where dynamic UI is needed. Fun fact you may know already - the company which created react, does NOT use it to create an SPA. SPAs are always worse than server rendered sites. It does not use react router/other stuff
They have server-rendered page and just use react for the dynamic feeds - as it was supposed to be used by any production-ready app.
Yes, you can. Thanks for getting involved
Pragati Verma
@PragatiVerma18
Sorry, I am a Django developer, so don't know much of React and SPAs. Thanks, I will fix the Django part.
Areeb Jamal
@iamareebjamal
Great
The article you listed is great and exactly right. If needed, we'll do the dynamic UI pasrt this way. Thanks for sharing https://hackernoon.com/reconciling-djangos-mvc-templates-with-react-components-3aa986cf510a
Pragati Verma
@PragatiVerma18
Hi, thanks...I had a question, what are the fields you need for the registration page? Can I include a profile photo option too??
Pragati Verma
@PragatiVerma18
Hi everyone, @iamareebjamal should the models be like? Is there any blueprint of the same, if there is something similar, please share, I would like to contribute and make it working again.
Sundaram Dubey
@maze-runnar
@PragatiVerma18 , the work is stuck in badgeyay due to models, as it needs involvment of one who knows models of previous projects. But currently models are not decide. It is also known that what fields of previous project we are going to use in this.
Raj Vaibhav Dubey
@rajvaibhavdubey
@maze-runnar These are the previously used models https://github.com/fossasia/badgeyay/tree/development/backend/models .
@kushthedude @iamareebjamal I think currently it's better to only implement a badge generator, no need to save the previously made badges.
  • Simple Login Signup
  • Badge Generation in the previously available badge sizes
  • Badge export as pdf
Pragati Verma
@PragatiVerma18
I would like to work for this, so, is this image what we are expecting as a badge?
badgeyay
Raj Vaibhav Dubey
@rajvaibhavdubey
Yes
For now we'll be generating badges only for Fossasia, so the top part will be fixed. Only variables in the badge are : First name, Last Name, Position Of Responsibility, Company, Github Handle
Pragati Verma
@PragatiVerma18
Okay, please review my PR ... I have implemented the login/signup for now, please guide me through the changes so that I can work for badge generation stuff
Raj Vaibhav Dubey
@rajvaibhavdubey
Okay :+1:
Pragati Verma
@PragatiVerma18
So, our basic models are going to contain these fields: Only variables in the badge are : First name, Last Name, Position Of Responsibility, Company, Github Handle
Raj Vaibhav Dubey
@rajvaibhavdubey
Yes :+1:
Pragati Verma
@PragatiVerma18
And that has to be filled through a form?
Raj Vaibhav Dubey
@rajvaibhavdubey
You can view the previous badgeyay site, it's working AFAIK.
Pragati Verma
@PragatiVerma18
It doesn't show anything beyond login/signup page.
Raj Vaibhav Dubey
@rajvaibhavdubey
Strange, It's working for me. Wait will post a screenshot of the Create badge page
Pragati Verma
@PragatiVerma18
Okay, I can see it now. I guess there have been recent changes to the codebase. It wasn't working until yesterday.
Does this 'Name your Badges' field mean - the name of organization??
Pragati Verma
@PragatiVerma18
For beginning, can I have a simple form where you have to enter details, and afterwards I will add features of uploading details from CSV??
Raj Vaibhav Dubey
@rajvaibhavdubey
Yes, would be good to begin with :+1: .
Areeb Jamal
@iamareebjamal
Why do we need to login to create badges?
Are the project requirements for badgeyay still the same? Is Badgeyay going to be a project for GSoC?
Pragati Verma
@PragatiVerma18
@iamareebjamal we would need login signup feature for user authentication etc in case we plan to go for API and also to ensure that the verified user is creating, editing the badge.
Areeb Jamal
@iamareebjamal
But it can be generated using just the browser. Why is it necessary? I get it that it might be needed for API but even that is not needed. Why can't something like https://squoosh.app can be built. It compresses images, does more intensive work than generating badges, but requires no account or server