Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Siddharth Sinha
@Sid911
I could put up a pr in next few hours.. its easy to implement 😇..
Areeb Jamal
@iamareebjamal
I think the current design is better
Siddharth Sinha
@Sid911
@iamareebjamal thanks
Siddharth Sinha
@Sid911
@iamareebjamal fossasia/open-event-attendee-android#2572 can you please tell which of the issue has this
Areeb Jamal
@iamareebjamal
search in closed issues
Siddharth Sinha
@Sid911
thanks 😇
Siddharth Sinha
@Sid911
@iamareebjamal but shouldn't clicking on profile take to different page or something... currently it asks to logout which doesn't make sense to me 😕?
is that intentional ?
Areeb Jamal
@iamareebjamal
It's mentioned in about 3-4 closed issues
Siddharth Sinha
@Sid911
ohk.. I saw that, I was just confirming 😇, thanks
Siddharth Sinha
@Sid911
fossasia/open-event-attendee-android#2565 can I work on this ? @iamareebjamal
Areeb Jamal
@iamareebjamal
yes
Siddharth Sinha
@Sid911
image.png
I think this is a problem with windows... if I try to do live editing.. the command exceeds windows maximuum limit
Areeb Jamal
@iamareebjamal
Use linux if you want to not have problems in life
Siddharth Sinha
@Sid911
sir there are obvious reasonslike adobe and many other professional tools like visual studio doesn't support linux 😅... I can't just leave windows ..
Areeb Jamal
@iamareebjamal
Well, then you'll continue seeing artificial issues like this
Siddharth Sinha
@Sid911
its fine.. I got around it 😇 but I am getting another issue... i think this is because of my old kotlin version but I can't assume this
image.png
Areeb Jamal
@iamareebjamal
Never use screenshots for showing errors
Siddharth Sinha
@Sid911
I didn't touch any file other than content_event.xml
Siddharth Sinha
@Sid911
updating kotlin fixed it
somenath sarkar
@somenath1435
Is there any way to fix this fossasia/open-event-attendee-android#1611 ?
Siddharth Sinha
@Sid911
I have actually completed this implementation of this issue..
Siddharth Sinha
@Sid911
@iamareebjamal Please merge this fast .. deadline is in few hours 😅 fossasia/open-event-attendee-android#2585
Areeb Jamal
@iamareebjamal
I'm in office. I have a job. Can't review until 9 PM
You need to learn patience in open source
Nobody is available 24x7
Areeb Jamal
@iamareebjamal
Did you read what Mario said in fossasia channel?
Siddharth Sinha
@Sid911
was open-event-attendee android converted from java or it was built with kotlin?
Siddharth Sinha
@Sid911
fossasia/open-event-attendee-android#2586 also in this pr I have no Idea why is it asking for licenses ... does licenses need to be preset locally in order to compile ? 🤷‍♀️
Siddharth Sinha
@Sid911
@iamareebjamal please close this issue too, I don't think its valid anymore fossasia/open-event-organizer-android#2024
Siddharth Sinha
@Sid911
fossasia/open-event-attendee-android#1055 about this issue... we can use Google map's geolocation api, which converts location into place names and already has level which can used to give the city's name , but that api requires an api key from google cloud
Siddharth Sinha
@Sid911
does Instagram updating doesn't doesn't work so why is it there?
    private fun updateUser() {
        val newUser = User(
            id = editProfileViewModel.getId(),
            firstName = rootView.firstName.text.toString(),
            lastName = rootView.lastName.text.toString(),
            details = rootView.details.text.toString(),
            facebookUrl = rootView.facebook.text.toString().emptyToNull(),
            twitterUrl = rootView.twitter.text.toString().emptyToNull(),
            contact = rootView.phone.text.toString().emptyToNull()
        )
        editProfileViewModel.updateProfile(newUser)
    }
this code updates the user (not really).. which doesn't have instagram in it although the object User has the property of instagramUrl
is this a bug?
Siddharth Sinha
@Sid911
There but there seems to be an issue with either the server or the android app, after adding social links once, user's are not able to remove the social media links, I tried many things in android version with no success, I think this is because of new server release version but I have no idea...
Sayantan Banerjee
@SayantanBanerjee16
Hello everyone, my name is Sayantan Banerjee, 2nd year IT undergraduate. I am pursuing Android for last one year and would like to contribute for the same in this year GSoC.
So I am querying if this project is available in this year GSoC and if I could be assigned to any issue related to this project
Ghost
@ghost~5a826f25d73408ce4f8ce425

@iamareebjamal noticed the open-event app is using KOIN but it is not like a dagger that provides compile-time injection.

can i please know why that decision is made because being an OSS it will grow every year

Areeb Jamal
@iamareebjamal
Because it takes 1 line for each 10 lines we will have to write for Dagger
Ghost
@ghost~5a826f25d73408ce4f8ce425

@iamareebjamal easiest solution may not be the best

p.s : i worked with both koin and dagger.

While dagger took days to understand koin took amount of time i read their docs

just couldn’t sleep knowing that app runs in runtime DI
Project is going to grow for sure
Areeb Jamal
@iamareebjamal
We have a test to check everything is injectable, so it can't fail on runtime if the test passes. There are many things in Koin we are doing like ViewModel injection and assisted inject which require PhD in Thermosiphon to be done in Dagger. I also will want to convert it to Dagger but only when 1. We actually have a problem in production due to Koin 2. I don't have to write a thesis in order to get one-liners of Koin like by viewModel<AViewModel>() and parameterOf(this) to work in Dagger