These are chat archives for fossasia/open-event-server

12th
May 2016
Aditya Vyas
@aditya1702
May 12 2016 00:44
@aayusharora vagrant up automatically installs all the requirements
You dont need to run the pip install requirements.txt for that
Did you install vagrant from the ubunty/trusty64 only.Because I also tried other boxes and they dont automatically install the requirements
Aayush Arora (angularboy)
@aayusharora
May 12 2016 05:29
Ok I guess there may be other box involved that is not taking requirement.txt
Justin Lee
@juslee
May 12 2016 09:11
ahhhh i broke the build
Justin Lee
@juslee
May 12 2016 10:36
ok fixed!
Avi Aryan
@aviaryan
May 12 2016 10:43
@rafalkowalski not much of an issue but there is a typo in the new branch's name 'gsoc2016' https://github.com/fossasia/open-event-orga-server/tree/gsock2016 .
:smile:
Justin Lee
@juslee
May 12 2016 10:44
i know right
Avi Aryan
@aviaryan
May 12 2016 10:44
:smile:
RafaƂ Kowalski
@rafalkowalski
May 12 2016 10:48
...
Justin Lee
@juslee
May 12 2016 10:50
i'm teasing @rafalkowalski about it right now
Avi Aryan
@aviaryan
May 12 2016 11:00
:joy:
Duke Leto
@leto
May 12 2016 17:41
lots of activity lately
Justin Lee
@juslee
May 12 2016 17:49
guilty as charged
Duke Leto
@leto
May 12 2016 17:49
indeed
Aditya Vyas
@aditya1702
May 12 2016 17:49
@juslee what are the initial milestones?
@leto I added Oauth 2.0 for Google and Facebook :smile: ..Could you look at it?
Duke Leto
@leto
May 12 2016 17:51
@juslee very nice progress. I am taking a look. What kind of testing have you done on it?
Aditya Vyas
@aditya1702
May 12 2016 17:52
I manually tested it on my browser
Creating google accounts and logging in!
Duke Leto
@leto
May 12 2016 17:52
which browser/os?
Aditya Vyas
@aditya1702
May 12 2016 17:52
Firefox
I will send you images..wait
Step 1.png
Step 2.png
Step 3.png
Justin Lee
@juslee
May 12 2016 17:55
@aditya1702 remember to create issues of your work, and assign the milestones and yourself. also remember to assign the PR to the milestones
Aditya Vyas
@aditya1702
May 12 2016 17:56
@juslee Ok
Justin Lee
@juslee
May 12 2016 17:56
@leto closed the old PRs and issues (can be reopened if required). added GSOC milestones 1 to 15.
Duke Leto
@leto
May 12 2016 17:58
sounds good
Duke Leto
@leto
May 12 2016 18:04
@aditya1702 did you do any testing to see if the tokens were still valid after a while, like 15 or 30 minutes? Last time I used this API (older version), some tokens were only valid for 1500 seconds and "refresh tokens" needed to be used/requested/etc
Justin Lee
@juslee
May 12 2016 18:04
@leto you might want to help @rafalkowalski with flask + user roles
@leto he's trying to figure it out now
Duke Leto
@leto
May 12 2016 18:04
@rafalkowalski whats up with flask+user roles?
Justin Lee
@juslee
May 12 2016 18:07
@/all every work done must have an issue, assigned milestone, assigned user. every PR must be associated with an issue, assigned to a milestone and assigned to a user. If there is no issue created, it means the work you've done for GSOC is not counted, even if there's an accepted PR. No exceptions.
Aditya Vyas
@aditya1702
May 12 2016 18:14
@leto I will check
Aditya Vyas
@aditya1702
May 12 2016 18:23
@juslee do we have to assign milestone 1 or can we assign a little later?
milestone 2 or 3?
Justin Lee
@juslee
May 12 2016 19:16
@aditya1702 sure. Go ahead.