These are chat archives for fossasia/open-event-server

11th
Jun 2016
Avi Aryan
@aviaryan
Jun 11 2016 03:04
@SaptakS We plan to start working on permissions soon enough.. @shivamMg has added the missing fields in the API (pending PRs) and after creating the Profile API, we will move to permissions
@/all @rafalkowalski Last 3 builds of travis failed .. It started from pulling #689 . See the log . https://travis-ci.org/fossasia/open-event-orga-server/builds/136831911 . It looks like {{event}} var is undefined in admin/sessions/display template
Avi Aryan
@aviaryan
Jun 11 2016 03:14
I see it was just a typo.. event.id should be event_id. sending a fix
Mario Behling
@mariobehling
Jun 11 2016 09:19
@niranjan94 Let's move the scheduler to the correct area now: Implement Schedule at /events/ID/schedule/edit(fossasia/open-event-orga-server#622) and provide a link to it at event dashboard /events/ID/ See dashboard here fossasia/open-event-orga-server#701
@niranjan94 The relevant issue is here fossasia/open-event-orga-server#326
Rafał Kowalski
@rafalkowalski
Jun 11 2016 09:22
@aviaryan sorry for my mistake
Saptak Sengupta
@SaptakS
Jun 11 2016 09:23
@mariobehling the link is already given in the dashboard.
Screenshot from 2016-06-11 14:53:04.png
As you can see on the top menu, there is options for sponsors, speakers, scheduler, session now..
I think this should work..What do you think?
And @rafalkowalski @aviaryan it was actually my PR where I made an error..
Niranjan Rajendran
@niranjan94
Jun 11 2016 09:28
@mariobehling The scheduler is now at /events/ID/scheduler/ as discussed yesterday
Saptak Sengupta
@SaptakS
Jun 11 2016 09:37
@mariobehling I have posted the dashboard prototype in the issue:
fossasia/open-event-orga-server#701
Could you please have a look?
@rafalkowalski can you have a look as well?
Rafał Kowalski
@rafalkowalski
Jun 11 2016 09:42
k
for me looks ok
Mario Behling
@mariobehling
Jun 11 2016 09:51
@SaptakS: Yes, I saw that, but we should include sponsors in the "create event wizard"
Saptak Sengupta
@SaptakS
Jun 11 2016 09:52
@mariobehling Saw that..
Mario Behling
@mariobehling
Jun 11 2016 09:52
"speakers and sessions" should go into the schedule instead of top bar
Saptak Sengupta
@SaptakS
Jun 11 2016 09:52
Once I finish the URL structure Issue, I wil do that.
Mario Behling
@mariobehling
Jun 11 2016 09:53
@SaptakS The structure had changed, please implement it the way it is on the issue now. There were a number of URLs overlapping functionality yesterday
Saptak Sengupta
@SaptakS
Jun 11 2016 09:54
But in this issue, fossasia/open-event-orga-server#701
SPeaker and session are in event dashboard itself..
And I think that makes more sense..
Niranjan Rajendran
@niranjan94
Jun 11 2016 09:54
Yes. Them being in the dashboard make more sense
Saptak Sengupta
@SaptakS
Jun 11 2016 09:54
We do have the facility of editing sessions from Schedule UI already but as such I think they should be part of the event dashboard only..
Mario Behling
@mariobehling
Jun 11 2016 09:56
The dashboard just has widgets. Each widget should have a link "more info" where more details are
e.g. each session can be viewed in detail
Saptak Sengupta
@SaptakS
Jun 11 2016 09:57
Yeah.. That is already being implemented..
Mario Behling
@mariobehling
Jun 11 2016 09:57
dashboard (with session widget data, e.g. the last submissions) -> links to session overview page - session overview page -> links to unique session
Saptak Sengupta
@SaptakS
Jun 11 2016 09:58
But wouldn't that make the UX more complicated?
Here the organizer just needs to click on sessions tab and then go to unique sessions..
Mario Behling
@mariobehling
Jun 11 2016 09:59
yes, cause the task at hand are complicated
Saptak Sengupta
@SaptakS
Jun 11 2016 09:59
Isn't that easier to work with?
Mario Behling
@mariobehling
Jun 11 2016 09:59
no
cause at fossasia we have 200 sessions
we cannot have 200 sessions in the board
how about some events that have 500 sessions
Saptak Sengupta
@SaptakS
Jun 11 2016 10:00
dashboard (with session widget data, e.g. the last submissions) -> links to session overview page - session overview page -> links to unique session
Mario Behling
@mariobehling
Jun 11 2016 10:00
also think of large concert events - festivals with 1000 sessions
Saptak Sengupta
@SaptakS
Jun 11 2016 10:00
But when you say sesson overview page, that will have all the sessions on board, right?
Mario Behling
@mariobehling
Jun 11 2016 10:00
it does not make sense to show all this in one tiny dashboard
But when you say sesson overview page, that will have all the sessions on board, right?
es
yes
Saptak Sengupta
@SaptakS
Jun 11 2016 10:01
But it isn't on a tiny dashboard, right? If you see the screenshot I have posted, its a separate tab altogether.. Where we can have the entire Table.. It can easily accomodate 1000 sessions.. No different from a different page..
The table will anyway have to have pagination..
Mario Behling
@mariobehling
Jun 11 2016 10:03
@SaptakS I am following Eventbrite
@SaptakS This is not thought through yet
we really need to think what we do with the dashboard
the only difference between your suggestion and mine is: you have a tab
I dont
your tabs are mixing different "logics" - session and sponsors
sponsors should go into the wizard
instead of top tabs, we probably need tabs within the page
Saptak Sengupta
@SaptakS
Jun 11 2016 10:05
Sponsors would be there in the wizard creation.. This is for the display purpose.. Just like your widgets, I am saying Tab representation is better.. Thats it..
You also have a sponsors widget, I have a sponsors Tab.. Thats the difference.. I think Tab will be easier to view data than widgets..
Mario Behling
@mariobehling
Jun 11 2016 10:06
@SaptakS It does not matter. This is not the final thing anyways.
Do what you want, but we need to progress faster instead of discussing too much
Saptak Sengupta
@SaptakS
Jun 11 2016 10:07
@mariobehling agreed.. Ohk I will continue with this prototype for the time then..
Mario Behling
@mariobehling
Jun 11 2016 10:07
Just follow eventbrite whereever possible. They have A/B testing and lots of people who have done UI research and we dont
Saptak Sengupta
@SaptakS
Jun 11 2016 10:07
Ohk.. great..
Will do that.. Surely..
Rafał Kowalski
@rafalkowalski
Jun 11 2016 10:48
@mariobehling @SaptakS fossasia/open-event-orga-server#707 i've added profile site
Mario Behling
@mariobehling
Jun 11 2016 10:51
@rafalkowalski Looks great! Are we able to upload images already? Or we implement it later?
Rafał Kowalski
@rafalkowalski
Jun 11 2016 11:12
currently we can put on link
only link
Mario Behling
@mariobehling
Jun 11 2016 11:12
ok
the top bar on the "home page" does not use the top the usual top bar
Mario Behling
@mariobehling
Jun 11 2016 12:44
@aditya1702 Checks are failing in your PRs. Please check fossasia/open-event-orga-server#710
@rafalkowalski If issues have checkboxes, please mark boxes (subissues) as closed before closing the issue itself, e.g. here fossasia/open-event-orga-server#679
Rafał Kowalski
@rafalkowalski
Jun 11 2016 13:15
@mariobehling k
Mario Behling
@mariobehling
Jun 11 2016 15:32
@rafalkowalski FYI "Edit Event" links to the version 1 wizard. This wizard should be out and deleted already https://github.com/fossasia/open-event-orga-server/issues/713#issuecomment-225366638
Mario Behling
@mariobehling
Jun 11 2016 16:47
@SaptakS Some checks are not successful. https://github.com/fossasia/open-event-orga-server/pull/720#issuecomment-225373835 Please review.
@SaptakS Sponsorship form is not implemented as needed. It must be possible to add more than one sponsor. The set of fields is for one sponsor only. It must be possible to have more sets.
Saptak Sengupta
@SaptakS
Jun 11 2016 17:19
Yeah.. I am working on it..
Mario Behling
@mariobehling
Jun 11 2016 17:26
@niranjan94 I have a quick issue for you. As you just implemented the mysessions link in the top dropdown, this should be easy for you fossasia/open-event-orga-server#722
Niranjan Rajendran
@niranjan94
Jun 11 2016 17:26
@mariobehling on it.
Rafał Kowalski
@rafalkowalski
Jun 11 2016 17:28
Do you have urgent tasks ? I can take it
Niranjan Rajendran
@niranjan94
Jun 11 2016 17:28
Finished it
fossasia/open-event-orga-server#723
Mario Behling
@mariobehling
Jun 11 2016 17:35
@rafalkowalski Please see here and comments on the bottom fossasia/open-event-orga-server#686
Rafał Kowalski
@rafalkowalski
Jun 11 2016 17:54
k
Mario Behling
@mariobehling
Jun 11 2016 17:55
@rafalkowalski Did you read my earlier comments? You are still linking to the wrong old wizard
Rafał Kowalski
@rafalkowalski
Jun 11 2016 17:55
do you mean edit view?
Mario Behling
@mariobehling
Jun 11 2016 17:56
Edit Event
this wizard should be out and deleted
Rafał Kowalski
@rafalkowalski
Jun 11 2016 17:56
k
ok so i will do it but instead of this we should you the lates one?
Mario Behling
@mariobehling
Jun 11 2016 17:57
what?
fossasia/open-event-orga-server#713
@rafalkowalski It looks like you dont check and test your own work. Please test more!
Rafał Kowalski
@rafalkowalski
Jun 11 2016 17:58
man it wasn't my work
i've only fixed a heroku
Mario Behling
@mariobehling
Jun 11 2016 17:58
if you fix it, you test it
Rafał Kowalski
@rafalkowalski
Jun 11 2016 17:59
it not the same
you discovered only error internal server error
so i've fixed access to this site
Mario Behling
@mariobehling
Jun 11 2016 17:59
please dont drop responsibility. even if someone else made this mistake, after you fixed it, you should have seen what is going on.
we are all in a team here and we need everyone to look out, please
Saptak Sengupta
@SaptakS
Jun 11 2016 18:00
@mariobehling @rafalkowalski no problem.. Will get the edit view removed..
:)
Rafał Kowalski
@rafalkowalski
Jun 11 2016 18:01
ok sorry that i haven't tested it
next time i will test all things which i've fixed
Mario Behling
@mariobehling
Jun 11 2016 18:02
no problem. Developers are the first testers. If it does not work for the team, it does not work for others. If you dont have time to fix, report it to others.
Rafał Kowalski
@rafalkowalski
Jun 11 2016 18:02
ok :)
sorry for mess
Mario Behling
@mariobehling
Jun 11 2016 18:57
@niranjan94 Good job!
Next we need the start home page to have the same top menu if a user is logged in
fossasia/open-event-orga-server#650
could you fix the left-over issue in the comments?
Home page does not use standard top bar and is not functional therefore.
Please add "Open Event" on the top left and make it link to / itself.
Niranjan Rajendran
@niranjan94
Jun 11 2016 18:59
Yes . I'll do that.
Mario Behling
@mariobehling
Jun 11 2016 19:00
great
Rafał Kowalski
@rafalkowalski
Jun 11 2016 19:10
currently i'm working on live draft past events fossasia/open-event-orga-server#686
Mario Behling
@mariobehling
Jun 11 2016 19:13
very good
Saptak Sengupta
@SaptakS
Jun 11 2016 19:15

I am working on adding multiple sponsors:

fossasia/open-event-orga-server#697

Mario Behling
@mariobehling
Jun 11 2016 19:19
@rafalkowalski After we have live/draft/past events we can get rid of the left side bar. All current features are in the UI then similar to Eventbrite.
Rafał Kowalski
@rafalkowalski
Jun 11 2016 19:19
yes
Saptak Sengupta
@SaptakS
Jun 11 2016 19:20
@mariobehling agreed.
Rafał Kowalski
@rafalkowalski
Jun 11 2016 19:26
@SaptakS @mariobehling are Live, Draft and Past a event state?
Saptak Sengupta
@SaptakS
Jun 11 2016 19:27
@rafalkowalski I think so... Past event can be determined from the end_Date.. live and draft can be determined from event_state..
Rafał Kowalski
@rafalkowalski
Jun 11 2016 19:27
I'm asking because we defined in Berlin different state of events
Mario Behling
@mariobehling
Jun 11 2016 19:29
@rafalkowalski No, this is not event state. This is just the view on that page.
@rafalkowalski Let's go step by step. We will probably implement an event stage viewer in the event dashboard, but at the moment this does not have priority
with the current list of issues we can build an MVP
Mario Behling
@mariobehling
Jun 11 2016 19:52
@shivamMg Please review fossasia/open-event-orga-server#718
Mario Behling
@mariobehling
Jun 11 2016 19:59
@SaptakS Your session forms do not seem to work anymore http://open-event.herokuapp.com/events/new/
Saptak Sengupta
@SaptakS
Jun 11 2016 20:02
@mariobehling I think its related to the DB in the heroku environment.. We will need to correct the migration..
The changes in the Sponsor table haven't been affected.. maybe thats why it isn't working..
Mario Behling
@mariobehling
Jun 11 2016 20:02
if i create an event, it also does not show up in the event overview
Saptak Sengupta
@SaptakS
Jun 11 2016 20:04
That is because right now the event isn't being created due to the problem in DB..
Mario Behling
@mariobehling
Jun 11 2016 20:04
ok
Mario Behling
@mariobehling
Jun 11 2016 20:21
@rafalkowalski Could you check on this, please?
Rafał Kowalski
@rafalkowalski
Jun 11 2016 20:21
i've fixed this i think
@SaptakS can you confirm?
Saptak Sengupta
@SaptakS
Jun 11 2016 20:23
@rafalkowalski its still not working.. :/
Rafał Kowalski
@rafalkowalski
Jun 11 2016 20:24
where did this bug occur?
i don't know how to reproduce it
Saptak Sengupta
@SaptakS
Jun 11 2016 20:24
If you try to create a new event, you will see that it is not possible to create an event right now..
That is the bug..
Mario Behling
@mariobehling
Jun 11 2016 20:25
also old events still send you bag to the wizard version 1
Saptak Sengupta
@SaptakS
Jun 11 2016 20:26
@mariobehling the edit view hasn't been worked on till now..
Will get that done..
Rafał Kowalski
@rafalkowalski
Jun 11 2016 20:44
@SaptakS ok i will check
Saptak Sengupta
@SaptakS
Jun 11 2016 20:45
@rafalkowalski Thanks..
Mario Behling
@mariobehling
Jun 11 2016 20:54
@rafalkowalski tests are failing
@SaptakS still merging?
Saptak Sengupta
@SaptakS
Jun 11 2016 20:55
@mariobehling codecov requires us to write tests for every return statement that we write.. So event if the functions has only a template render return statment, codecov tests fail..
So, merging PRs which do not require tests primitively..
Mario Behling
@mariobehling
Jun 11 2016 20:55
ok
good, so let's delete the left sidebar now
Saptak Sengupta
@SaptakS
Jun 11 2016 20:57
@mariobehling, Do we add the create new event link also in top menu bar?
Mario Behling
@mariobehling
Jun 11 2016 20:57
yes, lets do it
its easiest for now, i guess
Saptak Sengupta
@SaptakS
Jun 11 2016 20:58
Ohk.. Great.. Will remove the sidebar and add create new event on top menubar..
Yes..
Rafał Kowalski
@rafalkowalski
Jun 11 2016 20:59
ok i've fixed
problem with creating event
Mario Behling
@mariobehling
Jun 11 2016 21:00
@SaptakS Please look at this issue fossasia/open-event-orga-server#686
would be good to have "Create Event" on the top right
Rafał Kowalski
@rafalkowalski
Jun 11 2016 21:01
@mariobehling can i close fossasia/open-event-orga-server#688 ?
Mario Behling
@mariobehling
Jun 11 2016 21:03
@rafalkowalski lots of functionality in that issue is still missing - upload of photos, connecting with social media accounts and more
Rafał Kowalski
@rafalkowalski
Jun 11 2016 21:03
k
Mario Behling
@mariobehling
Jun 11 2016 21:04
i dont see a rich text editor and lots of other things that are missing
Saptak Sengupta
@SaptakS
Jun 11 2016 21:31
@rafalkowalski @mariobehling sidebar removed:
fossasia/open-event-orga-server#732
Mario Behling
@mariobehling
Jun 11 2016 21:32
@SaptakS did you get the "Create Event" button done on the top right?
Saptak Sengupta
@SaptakS
Jun 11 2016 21:33
Yes.. On the top right.. And home on the top left..
Screenshot from 2016-06-12 03:03:46.png
Mario Behling
@mariobehling
Jun 11 2016 21:36
@SaptakS Please move "Create Event" to the top right
  • absolute right
Saptak Sengupta
@SaptakS
Jun 11 2016 21:36
Ohk.. so right of the profile you mean?
Will do that in a minute..
Mario Behling
@mariobehling
Jun 11 2016 21:37
  • also rename point 3: to "Sessions, Tracks, Rooms"
Saptak Sengupta
@SaptakS
Jun 11 2016 21:37
Ohk..
Mario Behling
@mariobehling
Jun 11 2016 21:37
@SaptakS Let's put more attention to detail, please
I cannot do more than actually providing a screenshot
Saptak Sengupta
@SaptakS
Jun 11 2016 21:38
:+1:
Screenshot from 2016-06-12 03:09:44.png
better?
Mario Behling
@mariobehling
Jun 11 2016 21:41
@SaptakS Please look very carefully on the top right and tell me what you see https://cloud.githubusercontent.com/assets/1583873/15978994/b9e15c30-2f61-11e6-925b-361b3907a04a.png
Saptak Sengupta
@SaptakS
Jun 11 2016 21:42
While mine is same, right?
Oh shit.. I gave an outdated screenshot...
My mistake..
Screenshot from 2016-06-12 03:14:33.png
Mario Behling
@mariobehling
Jun 11 2016 21:47
ok, then
@SaptakS did you change the CSS of the top bar?
everything is smaller now
Saptak Sengupta
@SaptakS
Jun 11 2016 21:49
The text size was this much before as well.. I can increase it if you want..
The dropdown changed due to mistake.. fixed that..
topmenu.png
@mariobehling is it ok or shud I increase the size?
Mario Behling
@mariobehling
Jun 11 2016 21:53
@SaptakS Colors also changed
suddenly blue background is everywhere
please click through all functions and see for yourself
Saptak Sengupta
@SaptakS
Jun 11 2016 21:53
The backgorund had always been blue..
Mario Behling
@mariobehling
Jun 11 2016 21:53
Screenshot from 2016-06-11 23:52:31.png
maybe compare with your own former screenshots
Saptak Sengupta
@SaptakS
Jun 11 2016 21:54
The background was always blue.. But this shouldn't have happened.. will check..
Ohk.. got it.. Will fix this in a moment..
Mario Behling
@mariobehling
Jun 11 2016 21:59
@SaptakS Compare with your own previous screenshots fossasia/open-event-orga-server#701
Saptak Sengupta
@SaptakS
Jun 11 2016 22:00
@mariobehling fixed it.. The background color was there.. Some problem occured on removing the sidebar.. fixed it now..
Screenshot from 2016-06-12 03:30:18.png
topmenu.png
createEvent.png
Mario Behling
@mariobehling
Jun 11 2016 22:01
last one looks good
Saptak Sengupta
@SaptakS
Jun 11 2016 22:02
That is the one right now..
I am sending a PR..
Mario Behling
@mariobehling
Jun 11 2016 22:02
can you also change "next and previous
previous should be left
next should be right
Saptak Sengupta
@SaptakS
Jun 11 2016 22:02
Ohk..
Mario Behling
@mariobehling
Jun 11 2016 22:03
what about distance between 1-2-3-4-5
why is it different?
Saptak Sengupta
@SaptakS
Jun 11 2016 22:03
It is guided by the size of the title written below.. Since session,tracks,rooms is a bigger title than sponsors, hence the difference..
Mario Behling
@mariobehling
Jun 11 2016 22:04
thats bad
Saptak Sengupta
@SaptakS
Jun 11 2016 22:04
Hmm..
Also, the next and previous positions are also given in the smartWizard css library that is installed through bower..
I am trying to override the styling..
Saptak Sengupta
@SaptakS
Jun 11 2016 22:11
button.png
buttons looking ohk?
Mario Behling
@mariobehling
Jun 11 2016 22:11
same as before
Saptak Sengupta
@SaptakS
Jun 11 2016 22:12
Previous is on left now.. See the screenshots..
Mario Behling
@mariobehling
Jun 11 2016 22:14
yes
but "Create Event" on top is wrong again
it starts to be a bit painful
Saptak Sengupta
@SaptakS
Jun 11 2016 22:15
Oops.. Sorry for that..
To much of style override.. Sorry for that..
Rafał Kowalski
@rafalkowalski
Jun 11 2016 22:17
@SaptakS fossasia/open-event-orga-server#701
are you doing it?
Saptak Sengupta
@SaptakS
Jun 11 2016 22:19
@rafalkowalski I have implemented the thing commented, i.e. the sponsor part.. But I guess the issue is still left to be completed..
Right now working on a few UI corrections..
Mario Behling
@mariobehling
Jun 11 2016 23:05
@SaptakS publish schedule does not work atm
Rafał Kowalski
@rafalkowalski
Jun 11 2016 23:06
i'm working on rich area in profile
Mario Behling
@mariobehling
Jun 11 2016 23:06
ok, great
Rafał Kowalski
@rafalkowalski
Jun 11 2016 23:56
@mariobehling fossasia/open-event-orga-server#734