These are chat archives for fossasia/open-event-server

15th
Jun 2016
Saptak Sengupta
@SaptakS
Jun 15 2016 02:03
@mariobehling I checked it.. The error is due to the return statements which render the templates. I don't think tests for that is required.
So, it is good to merge I think..
fossasia/open-event-orga-server#793
Mario Behling
@mariobehling
Jun 15 2016 05:57
@SaptakS Ok, thanks
Rafał Kowalski
@rafalkowalski
Jun 15 2016 06:22
events/create
Niranjan Rajendran
@niranjan94
Jun 15 2016 06:24
@rafalkowalski That was in the old UI. Now it's proper
Rafał Kowalski
@rafalkowalski
Jun 15 2016 06:24
ok i see
Rafał Kowalski
@rafalkowalski
Jun 15 2016 07:37
@mariobehling fossasia/open-event-orga-server#688 can you explain me what does connecting to social media mean? Because now we have two fields facebook and twitter like in eventbrite
do we need connection with instagram?
Mario Behling
@mariobehling
Jun 15 2016 08:03
@rafalkowalski yes connecting is good. did you try out what connecting mean at eventbrite?
@rafalkowalski Iets do this later. We have lots of other things that are more important first, e.g. permissions and uploading media
I created a follow up issue here fossasia/open-event-orga-server#831
Mario Behling
@mariobehling
Jun 15 2016 08:08
you can also research then, what "connecting" means. Google is your friend here.
Avi Aryan
@aviaryan
Jun 15 2016 08:17
@rafalkowalski in user detail, are we storing twitter and facebook as link or as username ?
same goes for the speaker model
Saptak Sengupta
@SaptakS
Jun 15 2016 08:17
In the speaker model, yes we are storing the entire link..
Avi Aryan
@aviaryan
Jun 15 2016 08:18
I will vote for using links
@SaptakS :+1:
so I guess link for user_detail too.
Saptak Sengupta
@SaptakS
Jun 15 2016 08:18
I think so..
Avi Aryan
@aviaryan
Jun 15 2016 08:20
@rafalkowalski @aditya1702 there is avatar field in both user and user_detail model. I think one of them can be removed
Mario Behling
@mariobehling
Jun 15 2016 08:21
@aviaryan Whatever the user enters should work, e.g. fossasia or @fossasia or https://twitter.com/fossasia
Rafał Kowalski
@rafalkowalski
Jun 15 2016 08:22
k
Avi Aryan
@aviaryan
Jun 15 2016 08:23
@mariobehling Yes I had submitted a PR regarding that ... for speakers
Mario Behling
@mariobehling
Jun 15 2016 08:23
Screenshot from 2016-06-15 10:22:48.png
for facebook Eventbrite does this. Beginning is predefined and only need to enter what is behind .com
Saptak Sengupta
@SaptakS
Jun 15 2016 08:24
@mariobehling I think this is a better idea..
This way there won't be any confusion..
Rafał Kowalski
@rafalkowalski
Jun 15 2016 08:24
@SaptakS I agree
Avi Aryan
@aviaryan
Jun 15 2016 08:25
:+1:
Avi Aryan
@aviaryan
Jun 15 2016 08:29
@shivamMg ok, will do it today. Thanks
Rafał Kowalski
@rafalkowalski
Jun 15 2016 08:51
IOError: [Errno 2] No such file or directory: '/app/static/media/image/fossasia-300dpi.png' on Heroku
Aditya Vyas
@aditya1702
Jun 15 2016 08:55
@rafalkowalski is the folder created?
/static/media/image ?
Niranjan Rajendran
@niranjan94
Jun 15 2016 08:57
No media folder
Avi Aryan
@aviaryan
Jun 15 2016 08:58
yes, I guess you have to create media/image folder manually first
Saptak Sengupta
@SaptakS
Jun 15 2016 08:58
you can add a .gitkeep file in that folder.. Then the empty folder gets pushed to repo..
Avi Aryan
@aviaryan
Jun 15 2016 08:58
use the .gitkeep method
Avi Aryan
@aviaryan
Jun 15 2016 09:17
@rafalkowalski There are multiple heads in migrations
Multiple heads are present; please specify a single target revision
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:17
so
Avi Aryan
@aviaryan
Jun 15 2016 09:17
This is the error I get when trying to migrate
should I merge them
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:18
yes you should
Avi Aryan
@aviaryan
Jun 15 2016 09:18
?
Aditya Vyas
@aditya1702
Jun 15 2016 09:18
Merge them
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:18
python manage.py db merge first_id second_id
python manage.py db upgrade
Avi Aryan
@aviaryan
Jun 15 2016 09:18
ok
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:18
python manage.py db migrate
it should works
Avi Aryan
@aviaryan
Jun 15 2016 09:19
yes it worked
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:19
great
Avi Aryan
@aviaryan
Jun 15 2016 09:19
now I shoudl push the file
right
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:19
yes
Avi Aryan
@aviaryan
Jun 15 2016 09:19
ok
thanks done
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:22
:)
Avi Aryan
@aviaryan
Jun 15 2016 09:46
@SaptakS I am done with adding missing fields in Sessions API fossasia/open-event-orga-server#837
Rafał Kowalski
@rafalkowalski
Jun 15 2016 09:57
@/all we can't create event and edit event
Aditya Vyas
@aditya1702
Jun 15 2016 09:58
What is the error?
I also cant edit...but I can create
Rafał Kowalski
@rafalkowalski
Jun 15 2016 10:00
Aditya Vyas
@aditya1702
Jun 15 2016 10:01
@rafalkowalski did you specify the time in the Event step 1?
If we leave it blank we get this error
Saptak Sengupta
@SaptakS
Jun 15 2016 10:01
@rafalkowalski you can't keep any of the datetime fields empty.. Otherwise it will give an error..
Because an empty string can't be converted to datetime format..
Rafał Kowalski
@rafalkowalski
Jun 15 2016 10:02
so we need to display some info about error
Niranjan Rajendran
@niranjan94
Jun 15 2016 10:02
Yeo
*yes
I'm planning to add client side validation for all form fields
Saptak Sengupta
@SaptakS
Jun 15 2016 10:03
@rafalkowalski I think this should be handled by form validation where all required fields must be filled before going to next step..
@niranjan94 there is already an issue on this:
fossasia/open-event-orga-server#440
Niranjan Rajendran
@niranjan94
Jun 15 2016 10:04
Oh.. Okay... Didn't notice that
Rafał Kowalski
@rafalkowalski
Jun 15 2016 10:07
next error
during update event
Shivam Mamgain
@shivamMg
Jun 15 2016 10:15
I think I got it
look at line 64 in model_views/events.py
it's extracting the first element from list
and then passes it to edit_event
in line 670 of helpers/data.py in edit_event, it is expecting an iterable
but is actually getting an instance of CallForPaper (since we first extracted first element)
Shivam Mamgain
@shivamMg
Jun 15 2016 10:22
Here's a nice alias that tells you where you're on you revision history:
alias rev='python manage.py db history | grep --color "$(python manage.py db current 2> /dev/null)\|$(python manage.py db heads)\|$"'
run rev in terminal, where you run python manage.py
Mario Behling
@mariobehling
Jun 15 2016 10:40
@rafalkowalski @shivamMg What is the status of the permission system?
Rafał Kowalski
@rafalkowalski
Jun 15 2016 11:04
Currently i'm waiting for simple implementation
Shivam Mamgain
@shivamMg
Jun 15 2016 11:07
I'll submit a PR with basic implementation. I'm having problems with migrations, they are changing in almost every pr.
@rafalkowalski can you please review this: fossasia/open-event-orga-server#839
Rafał Kowalski
@rafalkowalski
Jun 15 2016 11:13
Ok
Rafał Kowalski
@rafalkowalski
Jun 15 2016 11:39
@shivamMg done
Shivam Mamgain
@shivamMg
Jun 15 2016 11:42
:+1:
Mario Behling
@mariobehling
Jun 15 2016 12:01
@rafalkowalski @shivamMg Internal Server Error
Mario Behling
@mariobehling
Jun 15 2016 12:08
@rafalkowalski Next big topic will be search. How to do it?
fossasia/open-event-orga-server#846
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:10
i think it can be easy
but let me think about it
Saptak Sengupta
@SaptakS
Jun 15 2016 12:12
@rafalkowalski @mariobehling I think this can be done through a simple ajax request and filter_by location of event..
Avi Aryan
@aviaryan
Jun 15 2016 12:12
yes, like for searching events -- we can first determine the search fields -- description, name, organizer, location,event type etc .. Once that is done it can be easily done from the backend
@SaptakS what when there are 100s of events.. backend will be required
Saptak Sengupta
@SaptakS
Jun 15 2016 12:13
Well I am talking about backend only.. Ajax requests are sent to the backend itself..
I never said about implementing in frontend..
Avi Aryan
@aviaryan
Jun 15 2016 12:13
lol . my bad
:smile: sorry
Saptak Sengupta
@SaptakS
Jun 15 2016 12:13
:)
Avi Aryan
@aviaryan
Jun 15 2016 12:14
@/all is there any specific reason there are 2 tables for user , user and user_detail ?
Saptak Sengupta
@SaptakS
Jun 15 2016 12:15
user stores only the authentication details.. However user_details stores all the details of the user..
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:15
Guys what do you think about elasticsearch?
Avi Aryan
@aviaryan
Jun 15 2016 12:15
but a user_detail object is created as soon as a user is created, right?
Saptak Sengupta
@SaptakS
Jun 15 2016 12:16
But no entries are made as it is not compulsory for the user to enter all other details..
Avi Aryan
@aviaryan
Jun 15 2016 12:16
ok
@rafalkowalski do you have prior knowledge on elasticsearch ?
github repo looks impressive :smile:
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:17
no
Saptak Sengupta
@SaptakS
Jun 15 2016 12:18
I have very little experience in it but have heard its real good..
Avi Aryan
@aviaryan
Jun 15 2016 12:18
it requires java :confused:
Avi Aryan
@aviaryan
Jun 15 2016 12:20
:+1:
Saptak Sengupta
@SaptakS
Jun 15 2016 12:21
Heyy.. I am facing problem with the migration.. says multiple heads...
How do I create new migration?
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:21
ok
Avi Aryan
@aviaryan
Jun 15 2016 12:21
need to merge them
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:21
you have to emrge
python manage.py db heads
python manage.py db merge first_id second_id
python manage.py db upgrade
python manage.py db migrate
Mario Behling
@mariobehling
Jun 15 2016 12:24
@rafalkowalski Elasticsearch is overkill at the moment. Basic search is already kind of working if we look for example at the filters of events. Let's keep it simple and find something that can be implemented fast.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:24
k
@aviaryan do we have paginations in REST API?
Avi Aryan
@aviaryan
Jun 15 2016 12:41
@rafalkowalski yes
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:42
@aviaryan so we don't have any problem to implement a simple search using API and backend
Avi Aryan
@aviaryan
Jun 15 2016 12:42
@rafalkowalski Is DELETE method needed for Users API ? I think it is un-neccessary .
@rafalkowalski Yes it should be easy
There is a REST api for getting event paginated
We can use query params for getting filter params.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:44
k, i don't know if we need DELETE method
Avi Aryan
@aviaryan
Jun 15 2016 12:44
like ?location=Berlin
@rafalkowalski I will leave it for now then.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:45
k
Mario Behling
@mariobehling
Jun 15 2016 12:45
@aviaryan Yes, we need to be able to delete users
Avi Aryan
@aviaryan
Jun 15 2016 12:45
What about POST api for users.
@mariobehling ok
Mario Behling
@mariobehling
Jun 15 2016 12:45
what would the post API for users do?
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:46
update profile details?
Avi Aryan
@aviaryan
Jun 15 2016 12:46
No PUT API will update details
POST API will create a new account
Rafał Kowalski
@rafalkowalski
Jun 15 2016 12:46
ok
Avi Aryan
@aviaryan
Jun 15 2016 12:46
So I think POST API is not needed as it requires email confirmation steps.
@mariobehling Should I make user account creation possible from the API ?
Mario Behling
@mariobehling
Jun 15 2016 12:56
@aviaryan Interesting question. We could potentially come up with functionalities and "mass create accounts". Sounds interesting. Yeah, let's do it, but ensure access is restricted. Or any other opinion on this?
Shivam Mamgain
@shivamMg
Jun 15 2016 13:01
We can create a /register api with POST. Instead of sending the usual 201 (created) response we can send a 202 (accepted) response, telling that the request has been accepted and is under process (giving them a msg that email verification is required). Once they confirm email they can login.
search for 202 Accepted
Avi Aryan
@aviaryan
Jun 15 2016 13:02
how do we manage the passwords in this situtation ? Should we email each of the account holders with a long random url to set their password.
Shivam Mamgain
@shivamMg
Jun 15 2016 13:03
How do we manage them now?
We don't send any emails right now, do we?
Avi Aryan
@aviaryan
Jun 15 2016 13:03
We can restrict access of users POST api to only super_admins and maybe organizers.
Yes, an email is sent to confirm the email
*email holder's identitiy
Shivam Mamgain
@shivamMg
Jun 15 2016 13:04
Then we can send them a 202 with the message that an email has been sent for verification. They can verify then.
Avi Aryan
@aviaryan
Jun 15 2016 13:06
Yes that would work...
Something like "forget password" feature. They'll go to the link and choose their passowrd
*create a new password
Mario Behling
@mariobehling
Jun 15 2016 13:10
@shivamMg @aviaryan This discussion gets very detailed and major decisions should not be made here in unstructured chats. Please open issues for specific questions.
Avi Aryan
@aviaryan
Jun 15 2016 13:16
@mariobehling ok
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:27
@/all who is responsible for removing session_id ? because my sessions doesn't work http://open-event.herokuapp.com/events/mysessions/
Mario Behling
@mariobehling
Jun 15 2016 13:29
@rafalkowalski it does not work for anyone. Internal Error for lots of things atm
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:29
k
Mario Behling
@mariobehling
Jun 15 2016 13:32
@shivamMg What about this PR? fossasia/open-event-orga-server#794
Niranjan Rajendran
@niranjan94
Jun 15 2016 13:32
@rafalkowalski seems to be a migration issue
@rafalkowalski Multiple heads. Could you merge and make a PR ?
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:33
ok i will check
Shivam Mamgain
@shivamMg
Jun 15 2016 13:36
@mariobehling It was for the first approach we thought of implementing fossasia/open-event-orga-server#795, we are working on the second one. I've removed it now :sweat_smile:
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:41
@niranjan94 i've added migrations but it doesn't work
Niranjan Rajendran
@niranjan94
Jun 15 2016 13:43
Error in migration 3c88cd5a4967_.py ... Caused by commit
fossasia/open-event-orga-server@d1d0f64
Avi Aryan
@aviaryan
Jun 15 2016 13:44
@rafalkowalski I think you will need to drop db
I just remember that formats table was removed which was linked with sessions
when running migrations, I got the problem of not being able to drop formats table as it was still linked to session.
If no formats were created on the server, then this might not be an issue
Mario Behling
@mariobehling
Jun 15 2016 13:47
@SaptakS Please help with your commit.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:51
@/all we can't drop db if we have a problem we need to learn how to solve these problems
Avi Aryan
@aviaryan
Jun 15 2016 13:52
@rafalkowalski did you get the exact reason for this issue ?
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:54
no
Niranjan Rajendran
@niranjan94
Jun 15 2016 13:54
Rafał Kowalski
@rafalkowalski
Jun 15 2016 13:56
@niranjan94 any ideas :D?
Avi Aryan
@aviaryan
Jun 15 2016 13:57
see pr #793
00ea66754d06 -> 3c88cd5a4967
@niranjan94 did you find anything ?
Niranjan Rajendran
@niranjan94
Jun 15 2016 13:58
Checking
The file needs to be changed. I'll send a PR
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:03
k
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:06
fossasia/open-event-orga-server#857
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:08
'sqlalchemy.exc.InternalError: (psycopg2.InternalError) cannot drop table format because other objects depend on it
DETAIL: constraint session_format_id_fkey on table session depends on table format
HINT: Use DROP ... CASCADE to drop the dependent objects too.
[SQL: '\nDROP TABLE format']'
this error locally occured
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:10
That's okay ... We have progressed forward ... Now due to
ffb21f7a6e61_.py by commit fossasia/open-event-orga-server@a950b7f
:sweat_smile:
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:10
ok :D
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:10
This is the one @aviaryan was talking about . Where the formats table has been drop
I think dropping the constraints inside track before dropping the table should do the trick
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:13
can you send a PR?
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:13
I will
fossasia/open-event-orga-server#858
I'm not sure if it'll work or not. Can't test it locally.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:18
we will see
works
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:19
@/all next time any model is removed, please make sure all the relations/constraints are properly taken care of. :sweat_smile:
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:21
i've pushed migrations
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:22
Yep. Works
:D
Mario Behling
@mariobehling
Jun 15 2016 14:28
@rafalkowalski @niranjan94 Good team work! We are starting to be a world-class team! Awesome.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:29
hah @mariobehling
Niranjan Rajendran
@niranjan94
Jun 15 2016 14:29
:sweat_smile:
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:32
@/all I've added events admin page
but i need to change a tabs names for admin events
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:49
@shivamMg can you send a migrations also?
i forgot to write it before merge
Shivam Mamgain
@shivamMg
Jun 15 2016 14:51
@rafalkowalski I actually didn't want to send migrations, with everyone updating migrations it became nasty to keep up. I thought you would wait to first test the code :P So I was actually writing a brief working description.
You can test it locally first and then push the migrations file.
Rafał Kowalski
@rafalkowalski
Jun 15 2016 14:52
ok
Shivam Mamgain
@shivamMg
Jun 15 2016 14:52
I updated the description a bit.
fossasia/open-event-orga-server#861
@rafalkowalski Also, I've only included Track and Sponsor as services for this example
Shivam Mamgain
@shivamMg
Jun 15 2016 15:05
@rafalkowalski I just realized a small mistake. How can a user create an already defined service : P
I'll send a pr with a patch
Alright I didn't see your comment
Rafał Kowalski
@rafalkowalski
Jun 15 2016 15:07
ok :D
Mario Behling
@mariobehling
Jun 15 2016 15:21
@shivamMg @aviaryan As you are continuously updating the APIs please make it a habit to update the documentation as well: https://github.com/fossasia/open-event-orga-server/blob/development/docs/API.md Thank you
Avi Aryan
@aviaryan
Jun 15 2016 15:25
:+1:
Avi Aryan
@aviaryan
Jun 15 2016 15:41
@shivamMg I will remove format from API.md
Mario Behling
@mariobehling
Jun 15 2016 15:49
@rafalkowalski Editing/Updating information of events still gives Internal Server Error
Rafał Kowalski
@rafalkowalski
Jun 15 2016 15:59
i see where is a problem
Rafał Kowalski
@rafalkowalski
Jun 15 2016 16:40
i've pushed fix but something is wrong
because i'm not able to click save button
Niranjan Rajendran
@niranjan94
Jun 15 2016 16:41
I'll check
Where ?
Edit or create ?
Rafał Kowalski
@rafalkowalski
Jun 15 2016 16:48
create
and edit
Niranjan Rajendran
@niranjan94
Jun 15 2016 16:48
Which stage where you in when you pressed save ?
Were all the required fields filled ?
Mario Behling
@mariobehling
Jun 15 2016 17:08
@niranjan94 none of the stages seems to work
required stages is just name and time of event
Niranjan Rajendran
@niranjan94
Jun 15 2016 17:27
I'll check it right away...
Rafał Kowalski
@rafalkowalski
Jun 15 2016 17:28
ok in inincognito it's working
Niranjan Rajendran
@niranjan94
Jun 15 2016 17:29
Then it might be a cache issue
Rafał Kowalski
@rafalkowalski
Jun 15 2016 17:30
exactly
Mario Behling
@mariobehling
Jun 15 2016 18:23
@niranjan94 Internal Server Error after your PR
Niranjan Rajendran
@niranjan94
Jun 15 2016 18:24
Just a sec
Fixed
Had to run migrations