These are chat archives for fossasia/open-event-server

17th
Jun 2016
Avi Aryan
@aviaryan
Jun 17 2016 02:47
"Import does not work" @mariobehling - If you are using old data, this might be because of recent changes in sponsors API (removal of sponsor_types api) and removal of level and format.
Avi Aryan
@aviaryan
Jun 17 2016 02:53
#917
Avi Aryan
@aviaryan
Jun 17 2016 05:03
Login on server looks to be down again
Aditya Vyas
@aditya1702
Jun 17 2016 05:03
Whats the error?
Avi Aryan
@aviaryan
Jun 17 2016 05:03
let me see
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:05
column user.is_super_admin does not exist
Aditya Vyas
@aditya1702
Jun 17 2016 05:05
Migration problem I think
We have to recreate the db tables
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:06
Yep. Multiple heads.
Avi Aryan
@aviaryan
Jun 17 2016 05:06
dont re-create. let's fix the migrations.
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:06
Yep. No recreate
Aditya Vyas
@aditya1702
Jun 17 2016 05:07
No we will have to create I think
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:07
Why ?
Aditya Vyas
@aditya1702
Jun 17 2016 05:07
Because I got this error before..'Column does not exist' and I had to recreate
But lets see
Avi Aryan
@aviaryan
Jun 17 2016 05:08
as many as 3 heads we have
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:08
Ok. Merge them all.
Aditya Vyas
@aditya1702
Jun 17 2016 05:08
If it gets solved with the migration then nice :)
Avi Aryan
@aviaryan
Jun 17 2016 05:09
merged and upgraded locally, no problems :smile:
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:09
Okay ! :) .. Push ... Let's see what happens
Avi Aryan
@aviaryan
Jun 17 2016 05:10
there might still be data on the server that causes the conflict.. like last time
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:10
Hmmm ...
sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) relation "service" already exists
 [SQL: '\nCREATE TABLE service (\n\tid SERIAL NOT NULL, \n\tname VARCHAR NOT NULL, \n\tPRIMARY KEY (id), \n\tUNIQUE (name)\n)\n\n']
in file d40a49824b53_.py
Avi Aryan
@aviaryan
Jun 17 2016 05:14
there is ed4b4ba3274e too
which creates the same table
@niranjan94 any ideas ?
Avi Aryan
@aviaryan
Jun 17 2016 05:20
I think we can remove steps of ed4b4 from d40a49 and that should fix the problem
Avi Aryan
@aviaryan
Jun 17 2016 05:40
@/all when sending a PR, make sure that the migrations added in your PR matches the model change in your PR.
@niranjan94 I will proceed with editing d40a49 . I am sure it will give us some progress.
Niranjan Rajendran
@niranjan94
Jun 17 2016 05:44
Okay...
Avi Aryan
@aviaryan
Jun 17 2016 05:51
db upgrade was successful
but there is still problem with some data on server
ProgrammingError: (psycopg2.ProgrammingError) column user.is_super_admin does not exist
fixing it ..
Avi Aryan
@aviaryan
Jun 17 2016 06:08
gone past through that error
ProgrammingError: (psycopg2.ProgrammingError) column user.is_admin does not exist
Niranjan Rajendran
@niranjan94
Jun 17 2016 06:11
Whoever added that column, forgot to add migrations for it
Avi Aryan
@aviaryan
Jun 17 2016 06:12
@niranjan94 yes
tested locally this time and login works. hopefully will work on the server
:fingers_crossed:
Niranjan Rajendran
@niranjan94
Jun 17 2016 06:13
Okay ... :sweat_smile:
Let's see
Avi Aryan
@aviaryan
Jun 17 2016 06:14
pushed
Niranjan Rajendran
@niranjan94
Jun 17 2016 06:16
Works ! :)
Avi Aryan
@aviaryan
Jun 17 2016 06:17
damn
Mario Behling
@mariobehling
Jun 17 2016 08:35
@rafalkowalski @SaptakS @shivamMg We need to progress on our high priority tasks. Are you taking notice? https://github.com/fossasia/open-event-orga-server/labels/Priority%3A%20High
Shivam Mamgain
@shivamMg
Jun 17 2016 08:35
@/all Just to be clear the permissions system is ready to use. You can see basic example here: fossasia/open-event-orga-server#885. We can start using these to restrict access to pages (views).
@mariobehling Yes
Mario Behling
@mariobehling
Jun 17 2016 08:36
The examples in the PR should be in the md file. So, we can direct devs there.
Shivam Mamgain
@shivamMg
Jun 17 2016 08:37
@mariobehling I've described how to use them in the link above.
Alright
Saptak Sengupta
@SaptakS
Jun 17 2016 08:38
@mariobehling I am just completing the session_wizard part.. Then I will pick up the login work. fossasia/open-event-orga-server#639
Mario Behling
@mariobehling
Jun 17 2016 08:38
I am not going to bookmark a pull request. Documentation is for "documentation". Not sure, what is the question.
@SaptakS That is good, but it does not say that in your daily scrum.
Saptak Sengupta
@SaptakS
Jun 17 2016 08:39
I saw that after writing the Scrum..
sorry..
Mario Behling
@mariobehling
Jun 17 2016 08:41
@SaptakS There are other priority tasks. Ok, so maybe people did not see that kind of tag yet. But, I think it is time to introduce priority tasks, that are kind of blockers for developments in other parts.
Saptak Sengupta
@SaptakS
Jun 17 2016 08:41
Yes.. Will check those out for sure..
Shivam Mamgain
@shivamMg
Jun 17 2016 09:00
@mariobehling fossasia/open-event-orga-server#925
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:12
@shivamMg can we use this permissions system ?
Shivam Mamgain
@shivamMg
Jun 17 2016 10:13
@rafalkowalski Yes
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:13
cool
Aditya Vyas
@aditya1702
Jun 17 2016 10:14
@rafalkowalski I am trying to create decorators for the permissions right now
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:15
@aditya1702 it would be nice
Shivam Mamgain
@shivamMg
Jun 17 2016 10:15
@aditya1702 :+1:
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:16
I cannn write tests to decorators
Aditya Vyas
@aditya1702
Jun 17 2016 10:23
Can anyone write tests for decorators?
@shivamMg ?
Shivam Mamgain
@shivamMg
Jun 17 2016 10:24
Or uhhh.... @rafalkowalski maybe
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:24
Yes
Shivam Mamgain
@shivamMg
Jun 17 2016 10:24
: P
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:24
I can
Shivam Mamgain
@shivamMg
Jun 17 2016 10:24
:+1:
Aditya Vyas
@aditya1702
Jun 17 2016 10:25
This message was deleted
@rafalkowalski Here :p
Wait not this
Rafał Kowalski
@rafalkowalski
Jun 17 2016 10:39
@aditya1702 are decorators ready?
Aditya Vyas
@aditya1702
Jun 17 2016 10:40
No I have started right now.
Mario Behling
@mariobehling
Jun 17 2016 11:32
@rafalkowalski After your merge http://open-event.herokuapp.com/admin/
Server Error
Rafał Kowalski
@rafalkowalski
Jun 17 2016 11:32
i will check
Shivam Mamgain
@shivamMg
Jun 17 2016 11:44
@mariobehling If the user does not have access to a certain page where should he be redirected to?
To a 403 forbidden page?
or just to the index page
Rafał Kowalski
@rafalkowalski
Jun 17 2016 11:47
maybe we can send a notification?
Niranjan Rajendran
@niranjan94
Jun 17 2016 11:49
We'll send to a 403 page and tell the user he/she doesn''t have accesss to that page
Mario Behling
@mariobehling
Jun 17 2016 13:41
@shivamMg @niranjan94 Agree. Thanks
Aditya Vyas
@aditya1702
Jun 17 2016 13:42
I have created the template for the page in my PR...
forbidden.png
fossasia/open-event-orga-server#944
Mario Behling
@mariobehling
Jun 17 2016 13:52
@shivamMg Which issue is this related to? Each PR should be matched with an issue: https://github.com/fossasia/open-event-orga-server/pull/941#event-695920026
@aditya1702 Please also keep the top menu and the bottom in that page
Aditya Vyas
@aditya1702
Jun 17 2016 14:00
@mariobehling I was creating the decorators and found a small bug and we quickly coordinated and merged it. Will make an issue from now on
Mario Behling
@mariobehling
Jun 17 2016 14:06
@aditya1702 If this is related to an existing issue (even if it was closed, you can reopen it and comment). No need to make new issues for smallest things. Just use existing issues or if it is a bigger thing, please make a new issue. Thanks.
Aditya Vyas
@aditya1702
Jun 17 2016 14:08
Ok
Mario Behling
@mariobehling
Jun 17 2016 14:18
@shivamMg https://github.com/fossasia/open-event-orga-server/pull/927#event-695719214 Don't know which issue is this related to. Please point us to the documentation of this feature.
@niranjan94 Don't know where/when it happened, but the "View" option in the Event Dashboard is disappeared. Any ideas?
Niranjan Rajendran
@niranjan94
Jun 17 2016 14:26
@mariobehling Oh ... I'll check it
@mariobehling I think I accidentally removed it when adding publish/unpublish/copy/delete
Will fix it
Rafał Kowalski
@rafalkowalski
Jun 17 2016 19:48
@aviaryan how can i filter events by locations in api?