These are chat archives for fossasia/open-event-server

19th
Jun 2016
Mario Behling
@mariobehling
Jun 19 2016 00:37
I am not sure about the question
now you dont have to click next
other things stay the same
Saptak Sengupta
@SaptakS
Jun 19 2016 00:38
Yeah.. So I guess, the only thing to do here is if the speaker isn't logged in and enters email, we send him an email verification..
And since email is always included and required in the speaker form so it has to be filled anyhow.. Right?
Mario Behling
@mariobehling
Jun 19 2016 00:39
guess so. How about you implement what you understand first and we see
Saptak Sengupta
@SaptakS
Jun 19 2016 00:39
Great..
Will do that then..
And sorry for the delay in work by me.. Had a 5-6 hour powercut yesterday... Really sorry..
Mario Behling
@mariobehling
Jun 19 2016 00:40
by the way, upload of files does not work in that form yet, correct?
Saptak Sengupta
@SaptakS
Jun 19 2016 00:40
Yes.. Aditya was writing all the upload file codes, so didn't work on that..
If he doesn't do that, I will get it done..
I will talk to him..
Mario Behling
@mariobehling
Jun 19 2016 00:41
ok
Saptak Sengupta
@SaptakS
Jun 19 2016 00:41
:+1:
And I have sent a PR to add a Save Draft button and showing email if the speaker is already logged in.
Mario Behling
@mariobehling
Jun 19 2016 00:46
"Speaker and Session forms have been incorrectly configured for this event. Session creation has been disabled"
What is it?
Saptak Sengupta
@SaptakS
Jun 19 2016 00:47
I don't understand..
What?
Mario Behling
@mariobehling
Jun 19 2016 00:48
Screenshot from 2016-06-19 02:48:06.png
Saptak Sengupta
@SaptakS
Jun 19 2016 00:49
I didn't add that.
I think what that means is the JSON stored in this event was according to some previous rules which don't match now..
Because previously we didn't have these pre-includes, etc..
But I am not sure.. I will have to check..
Mario Behling
@mariobehling
Jun 19 2016 00:51
I just created the event now
Saptak Sengupta
@SaptakS
Jun 19 2016 00:51
Then I don't know..
I will check..
Can you tell me what options you selected because it works fine for me..
The event you have opened in your screenshot, I am not allowed to create session in that event.. Says forbidden access.
Mario Behling
@mariobehling
Jun 19 2016 00:57
Just create your own event.
It seems it does not work with any event
Saptak Sengupta
@SaptakS
Jun 19 2016 00:58
Yeah did that.. Its working fine for me..
This error is given after the creation of event right?
Mario Behling
@mariobehling
Jun 19 2016 00:58
yes
in the live system
Saptak Sengupta
@SaptakS
Jun 19 2016 00:59
Yeah.. Works fine for me in the live system.. Just checked it..
Mario Behling
@mariobehling
Jun 19 2016 00:59
ok, works
Saptak Sengupta
@SaptakS
Jun 19 2016 01:00
Cool..
Mario Behling
@mariobehling
Jun 19 2016 01:03
If I save fields as include e.g. "Github, Linkedin" it does not show up in the form
and I seem not to be able to save some of them as "Include" or "Required"
Saptak Sengupta
@SaptakS
Jun 19 2016 01:04
Works fine for me..
FireShot Capture 29 - Create Session -_ - http___open-event.herokuapp.com_events_71_sessions_create_.png
Only the "session_type" and "tracks" won't work until they are filled in Step-3. If they are left unfilled in step-3 then u can't include them.
I checked all the other switches just now. Works exactly fine..
Mario Behling
@mariobehling
Jun 19 2016 01:07
if you go back after creating the event and edit it and add new fields?
does it work then?
if you change the form?
Saptak Sengupta
@SaptakS
Jun 19 2016 01:07
That I didn't check..
Mario Behling
@mariobehling
Jun 19 2016 01:07
also please show a start * if fields are required
Saptak Sengupta
@SaptakS
Jun 19 2016 01:08
That I will have to check. Because didn't work on that view.. It was created by someone else..
  • is shown in the session form if they are required.
Mario Behling
@mariobehling
Jun 19 2016 01:08
well, you are working on this now. So, if you implement a feature in that area, that was not there before, please test everything in detail
Saptak Sengupta
@SaptakS
Jun 19 2016 01:08
Yeah.. i will check that..
But * is there in the session form if required I think..
It works on editing as well... Just checked..
Mario Behling
@mariobehling
Jun 19 2016 01:10
well, please go back and forth and try with different events and set ups. I do not understand why issues are appearing with me
Saptak Sengupta
@SaptakS
Jun 19 2016 01:11
Hmm.. will do a complete check right away..
Mario Behling
@mariobehling
Jun 19 2016 01:11
When I change the form, github and linkedin do not show up at all
Saptak Sengupta
@SaptakS
Jun 19 2016 01:12
I just edited an event and added github and linkedin in step-5. Worked for me.
Mario Behling
@mariobehling
Jun 19 2016 01:12
Now when I go back a number of items are set on required, but not included. That should not even be possible.
Screenshot from 2016-06-19 03:12:18.png
Saptak Sengupta
@SaptakS
Jun 19 2016 01:14
That is definitely not possible... It is not allowed to be done in either create/edit events..
Anyways.. i will do a complete check and fix any bugs I find related to this.
Mario Behling
@mariobehling
Jun 19 2016 01:15
ok, thanks. Please also try to make the form into one column
and add --Event Name-- | Create Session on the top
Saptak Sengupta
@SaptakS
Jun 19 2016 01:16
The session creation form into one column?
Mario Behling
@mariobehling
Jun 19 2016 01:16
yes
Saptak Sengupta
@SaptakS
Jun 19 2016 01:16
I thought this would look better.. Less scrolling.. thats why did this. Ohk.. I will change that to a single column..
Mario Behling
@mariobehling
Jun 19 2016 01:17
we should be optimizing for mobile
just keep it simple
distance would be too big between columns otherwise as well.
Saptak Sengupta
@SaptakS
Jun 19 2016 01:18
Ohk.. Will make it into a single column..
But in some cases it could be a really long form to be scrolled.. :D
Mario Behling
@mariobehling
Jun 19 2016 01:20
ok
at the moment, it is too much work for me to continuously test if mobile works
the mobile version of this page is not working well at the moment
let's keep it simple and make it one column
Saptak Sengupta
@SaptakS
Jun 19 2016 01:20
ohk..
Mario Behling
@mariobehling
Jun 19 2016 01:20
we also need to optimize the wizard
keep it simple for now
also make comments into paragraph
well, i mentioned these things on tracker and pr comments before
Saptak Sengupta
@SaptakS
Jun 19 2016 01:22
FireShot Capture 30 - Create Session -_ - http___open-event.herokuapp.com_events_68_sessions_create_.png
Yeah.. will make comments into paragraph..
Btw I get the mobile version like this.. Is it appearing the same in your case?
Mario Behling
@mariobehling
Jun 19 2016 01:22
speaker details should be on the bottom
too many details to go through
Saptak Sengupta
@SaptakS
Jun 19 2016 01:23
hmm.. ohk.. No problem..
Mario Behling
@mariobehling
Jun 19 2016 01:23
keep it simple to reduce work, please
Saptak Sengupta
@SaptakS
Jun 19 2016 01:23
Will get it done..
Don't worry... :D
Mario Behling
@mariobehling
Jun 19 2016 01:23
ok, so lets keep things simple
and always test in mobile
Saptak Sengupta
@SaptakS
Jun 19 2016 01:23
Sure.. will do that from now on..
Mario Behling
@mariobehling
Jun 19 2016 01:24
we also need more form validation in this form
e.g. URL should be a real URL
also photos should not show up in full size when uploaded and file formats need to be specified for slides
there are a lot of small issues that still need to be taken care of and we need you to think things through more and get them done pro-actively instead of waiting for issues and definitions.
Saptak Sengupta
@SaptakS
Jun 19 2016 01:27
Great.. Will get them done..
Mario Behling
@mariobehling
Jun 19 2016 01:28
Also, we need you to look more what others are doing and everyone needs to understand more about the standards we are implementing, e.g. if the save buttons are on the bottom left, then in a new form they should be on the bottom left.
Saptak Sengupta
@SaptakS
Jun 19 2016 01:28
Hmm.. True.. Will keep that in mind..
Mario Behling
@mariobehling
Jun 19 2016 01:29
Otherwise it will take us a long time to make issues for everything and explain. If we need to explain everything, we could just do it ourselves faster. We need everyone to think this more through and test all kind of scenarios. Can you do that?
Saptak Sengupta
@SaptakS
Jun 19 2016 01:31
Yeah.. Sure..
Shivam Mamgain
@shivamMg
Jun 19 2016 04:18
@mariobehling fossasia/open-event-orga-server#998
@rafalkowalski fossasia/open-event-orga-server#996 Please review
Mario Behling
@mariobehling
Jun 19 2016 05:56
@shivamMg Please learn how to upload an image to a Github issue or PR. It is really not so difficult.
Mario Behling
@mariobehling
Jun 19 2016 06:34
@niranjan94 Please review the PRs at https://github.com/fossasia/open-event-orga-server/pulls
Niranjan Rajendran
@niranjan94
Jun 19 2016 07:00
@mariobehling on it
Mario Behling
@mariobehling
Jun 19 2016 08:11
@aditya1702 I am adding "High Priority" to this issue fossasia/open-event-orga-server#1003 It is kind of a blocker for separating user and admin spaces.
Aditya Vyas
@aditya1702
Jun 19 2016 08:18
Ok
Mario Behling
@mariobehling
Jun 19 2016 08:30
@aditya1702 https://open-event.herokuapp.com/admin/permissions/ Gives internal server error
Aditya Vyas
@aditya1702
Jun 19 2016 08:39
@mariobehling its working locally for me. wait i will check
Mario Behling
@mariobehling
Jun 19 2016 08:41
@aditya1702 I wonder if we should cancel the sentence "It is working for me locally." from our vocabulary. It does not matter if it is working locally. If it does not work on the live system, it does not work.
Aditya Vyas
@aditya1702
Jun 19 2016 08:42
Sorry. will check whats the problem
Saptak Sengupta
@SaptakS
Jun 19 2016 08:46
@mariobehling fixed the editing of custom forms while editing the Event..
fossasia/open-event-orga-server#1018
Please review.
Aditya Vyas
@aditya1702
Jun 19 2016 09:11
@mariobehling The error is due to code for the footer committed by Rafal. Niranjan is fixing it
Saptak Sengupta
@SaptakS
Jun 19 2016 09:18
@mariobehling making the session form into a single column doesn't change much in the mobile view
These are the UIs with single column and double column
sessionform_modified.png
session form_now.png
Niranjan Rajendran
@niranjan94
Jun 19 2016 09:22
@mariobehling @aditya1702 the error has been fixed
Aditya Vyas
@aditya1702
Jun 19 2016 09:24
@niranjan94 :+1: working
Saptak Sengupta
@SaptakS
Jun 19 2016 09:29
@mariobehling this is the mobile version:
session_mobile.png
Mario Behling
@mariobehling
Jun 19 2016 09:57
@SaptakS nice. We need to think which rich-text functions we really need. Also we need to improve the top bar. Do you see it?
Saptak Sengupta
@SaptakS
Jun 19 2016 09:57
Yeah.. I will create an issue on that..
Mario Behling
@mariobehling
Jun 19 2016 09:57
:+1:
Saptak Sengupta
@SaptakS
Jun 19 2016 09:58
The top bar is the problem in every page.. So will need to modify that for mobile..
Mario Behling
@mariobehling
Jun 19 2016 09:58
yep
Saptak Sengupta
@SaptakS
Jun 19 2016 09:58
Will get that done.. Presently working on fossasia/open-event-orga-server#639
Mario Behling
@mariobehling
Jun 19 2016 09:59
@aditya1702 Thanks for identifying it. @rafalkowalski Please talk to @niranjan94 What went wrong. So, we can avoid those kind of issues. Currently I still get server errors.
Niranjan Rajendran
@niranjan94
Jun 19 2016 09:59

@mariobehling yes. I have already spoken to @rafalkowalski about this.

Where do you get the server error now ?

Mario Behling
@mariobehling
Jun 19 2016 10:00
all pages
Niranjan Rajendran
@niranjan94
Jun 19 2016 10:01
Fixed.
Rafał Kowalski
@rafalkowalski
Jun 19 2016 10:04
@niranjan94 thanks
Mario Behling
@mariobehling
Jun 19 2016 10:06
We really need the permissions working and the separation of user and admin section. The "Admin" link on the dropdown menu should only show up, when the user is a super admin. If we have that, we can start to invite some testers to give feedback.
Rafał Kowalski
@rafalkowalski
Jun 19 2016 10:18
@mariobehling i will do it
Niranjan Rajendran
@niranjan94
Jun 19 2016 10:20

@/all if your PR has new migrations, please run them as soon as they're deployed.

Migrations can be run by making a GET/POST request to http://open-event.herokuapp.com/migrate/

Rafał Kowalski
@rafalkowalski
Jun 19 2016 10:20
cool !
Saptak Sengupta
@SaptakS
Jun 19 2016 10:20
@niranjan94 :+1:
Mario Behling
@mariobehling
Jun 19 2016 10:21
thank you
Aditya Vyas
@aditya1702
Jun 19 2016 11:07
@mariobehling super_admin is created when one creates the app. So presently we just need a view where the super_admin makes others users admins
Mario Behling
@mariobehling
Jun 19 2016 11:31
@aditya1702 Which account is super admin at the moment then?
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:38
@mariobehling i'm working to display all sessions right now
in admin panel
Mario Behling
@mariobehling
Jun 19 2016 11:39
ok, good.
As we did not have this feature at the beginning, it seems there is no super admin at the moment.
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:40
we can add him manually
i will try something wait a second
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:48
unfortunately it's not so easy as i thought
Niranjan Rajendran
@niranjan94
Jun 19 2016 11:48
I'll try
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:48
I've tried added super admin from command line
Niranjan Rajendran
@niranjan94
Jun 19 2016 11:49
And what happened ?
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:49
but it doesn't displays in admin panel ;p
u = User.query.filter_by(email='rafal.arte@gmail.com')[0]
Niranjan Rajendran
@niranjan94
Jun 19 2016 11:49
What email did you add ?
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:49
u.is_super_admin = True
Niranjan Rajendran
@niranjan94
Jun 19 2016 11:52
I don't think super_admin state is showed in the role field
Rafał Kowalski
@rafalkowalski
Jun 19 2016 11:52
exactly
Mario Behling
@mariobehling
Jun 19 2016 12:23
@SaptakS Let's not submit all design issues now. There are too many and we will change the design of some areas. Just make the most prominent areas work, e.g. top menu bar. That is sufficient. We need to work on the flow and feature set first.
Saptak Sengupta
@SaptakS
Jun 19 2016 12:24
Ohk.. And I have mentioned the flow of this issue: fossasia/open-event-orga-server#639
Can you please check and let me know?
Mario Behling
@mariobehling
Jun 19 2016 12:25
Most of your questions are already outlined fossasia/open-event-orga-server#965
If not, maybe follow common sense, e.g. if a user tries to use an existing email - put out a message: "email already in use, please sign in"
and document what you do
Mario Behling
@mariobehling
Jun 19 2016 12:42
Internal server error
Niranjan Rajendran
@niranjan94
Jun 19 2016 12:43
One sec. Multiple heads. The last two PRs both had migrations. I'll fix
@mariobehling fixed
Mario Behling
@mariobehling
Jun 19 2016 12:50
@niranjan94 How can a speaker submit a session? is there already a way?
Saptak Sengupta
@SaptakS
Jun 19 2016 12:51
@mariobehling that needs to be implemented.
We need to create a way of providing the session creation URL to the speakers.
Niranjan Rajendran
@niranjan94
Jun 19 2016 12:52
Yes. needs to be implemented.
Mario Behling
@mariobehling
Jun 19 2016 12:53
@SaptakS If you want to do this, then I do not understand why you add the organizer menu to the top.
Niranjan Rajendran
@niranjan94
Jun 19 2016 12:54
@mariobehling I was the one who added the organizer menu when I added the event name to it.
In this issue fossasia/open-event-orga-server#1002
Mario Behling
@mariobehling
Jun 19 2016 12:55
@niranjan94 ok, so the logic is not implemented here and we might be able to use this form in different areas as an overlay/lightbox.
best would be, we show it without the menu and open from the call for speakers
Niranjan Rajendran
@niranjan94
Jun 19 2016 12:57
okay ... So, we can remove the organizer menu and make the session form generic such that it can be used anywhere
Mario Behling
@mariobehling
Jun 19 2016 12:59
@niranjan94 fossasia/open-event-orga-server#1030
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:00
I'm already working on Add button "Submit Proposal" to page "Call for Speakers" (/e/ID/cfs/) and open form as Lightbox. as a part of issue fossasia/open-event-orga-server#782
Mario Behling
@mariobehling
Jun 19 2016 13:01
ok, great
@niranjan94 There is a potential conflict to consider: 1. Speakers can only submit sessions, when the call for papers is open. 2. Organizers can submit at any time they want. - Just to keep in mind.
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:03
Yes. I'll keep that in mind. Thanks .... :)
Mario Behling
@mariobehling
Jun 19 2016 13:07
We have events listed in the admin section, but all people have roles "none" https://open-event.herokuapp.com/admin/users/
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:08
I think that occured after fossasia/open-event-orga-server#1028
Mario Behling
@mariobehling
Jun 19 2016 13:09
should we delete all events? Older events have a number of problems anyways.
@niranjan94 could you wipe them, please/
?
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:10
yes. will do it now.
Just the events or users too ?
Mario Behling
@mariobehling
Jun 19 2016 13:10
what do you think?
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:10
I think we can clean the database ...
Saptak Sengupta
@SaptakS
Jun 19 2016 13:11
I think that is a good idea..
Mario Behling
@mariobehling
Jun 19 2016 13:11
ok, good
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:11
there has been a lot of changes
Mario Behling
@mariobehling
Jun 19 2016 13:11
how can we get a user as super admin?
maybe you can check out if it works
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:11
I can do it while creating
Mario Behling
@mariobehling
Jun 19 2016 13:11
ok, please make everyone in the team super admins
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:11
Will do
Rafał Kowalski
@rafalkowalski
Jun 19 2016 13:12
@niranjan94 drop database
yupi
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:13
Done.
Super admin email: admin@open-event.herokuapp.com
Password: fossasia
Rafał Kowalski
@rafalkowalski
Jun 19 2016 13:13
is it posible to change a password :D?
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:13
Sure.
Drop -> recreate
or login and change
You wanna change ?
Rafał Kowalski
@rafalkowalski
Jun 19 2016 13:15
admin panel it's working :)
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:15
Great ! :)
Rafał Kowalski
@rafalkowalski
Jun 19 2016 13:15
but we need to validate it
if we put link /admin we have access
so we need to add a condition where we check if user is also super admin
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:16
yes. in all the super admin views
Rafał Kowalski
@rafalkowalski
Jun 19 2016 13:16
yes :)
def is_accessible(self):
    return login.current_user.is_authenticated and login.current_user.is_super_admin
something like this
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:19
Yep. simple and it'll work :+1:
Rafał Kowalski
@rafalkowalski
Jun 19 2016 13:20
can you add it :D?
Saptak Sengupta
@SaptakS
Jun 19 2016 13:20
Yeah.. this should solve the purpose..
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:20
Sure
Mario Behling
@mariobehling
Jun 19 2016 13:24
I can create events now without login
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:25
Are you sure ? I'm being taken to the login page
Mario Behling
@mariobehling
Jun 19 2016 13:27
ah ok. no, works fine
Mario Behling
@mariobehling
Jun 19 2016 13:33
I created an issue to distinguish system roles from event roles in the admin overview: fossasia/open-event-orga-server#1033
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:35
  • If a non-admin user is logged in and tried to access the admin panel, he/she is shown a forbidden page.
  • If a not logged in user tries to access the admin panel, he/she is redirected to the login page
    fossasia/open-event-orga-server#1034
Mario Behling
@mariobehling
Jun 19 2016 13:36
yes
@niranjan94 the schedule shows that some events are taking place at 1am in the morning. Not sure, where this comes from: https://open-event.herokuapp.com/e/1/schedule/
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:37
Yep. That's accurate. I have put the sessions there
I have been testing it.
Mario Behling
@mariobehling
Jun 19 2016 13:38
ah ok
Mario Behling
@mariobehling
Jun 19 2016 13:53
@niranjan94 How can you make me super admin?
Niranjan Rajendran
@niranjan94
Jun 19 2016 13:54
You're super admin now.
As of now, I can access the db and change it.
Mario Behling
@mariobehling
Jun 19 2016 13:54
ah ok
Niranjan Rajendran
@niranjan94
Jun 19 2016 16:13

@/all I just noticed that all the sessions get deleted if the event is edited.

In the current implementation of the event-edit functionality, all the tracks, session_types, microlocations are cleared and recreated again.

This causes all the linked sessions to be removed as well.

I have opened an issue @ fossasia/open-event-orga-server#1040 .. Could someone take it up ?