These are chat archives for fossasia/open-event-server

25th
Jun 2016
Shivam Mamgain
@shivamMg
Jun 25 2016 05:44
@mariobehling Can we have the excel sheet that was used to scrape data for fossasia'16. Regarding: fossasia/open-event-orga-server#1187
Mario Behling
@mariobehling
Jun 25 2016 06:19
@shivamMg Shared it with you in google drive
Mario Behling
@mariobehling
Jun 25 2016 07:41
@aviaryan I merged the PR and added the keys in the settings. Seems to work mostly, but I get "Internal Server Error" when I create an event.
Rafał Kowalski
@rafalkowalski
Jun 25 2016 07:46
@mariobehling i will check
can you tell me when this bug occured?
Mario Behling
@mariobehling
Jun 25 2016 07:51
when creating an event and saving it
Rafał Kowalski
@rafalkowalski
Jun 25 2016 07:54
did you change something in params? because on my side it's working
Avi Aryan
@aviaryan
Jun 25 2016 08:16
@mariobehling The first time I created event with minimal options and it worked fine.
But when I enabled more options and added more details, I too get 500 error
I will check.
Opening this event gives 500 http://open-event.herokuapp.com/events/24/
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:19
pc13:open-event-orga-server rafal$ heroku logs
▸ Response code 500 (Internal Server Error)
it's weird
Avi Aryan
@aviaryan
Jun 25 2016 08:20
no real error message. will have to run locally
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:24
BuildError: Could not build url for endpoint 'event_sponsors.delete_view' with values ['event_id', 'sponsor_id']. Did you mean 'events.delete_view' instead?
Avi Aryan
@aviaryan
Jun 25 2016 08:24
werkzeug.routing.BuildError
BuildError: Could not build url for endpoint 'event_sponsors.delete_view' with values ['event_id', 'sponsor_id']. Did you mean 'events.delete_view' instead?
this is the error I get
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:24
i was first
xD
Avi Aryan
@aviaryan
Jun 25 2016 08:24
:smile: same time
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:24
ok so will you solve it?
Aditya Vyas
@aditya1702
Jun 25 2016 08:24
But event_sponsors.delete_view isdefined
Y th error
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:25
wait a second
Avi Aryan
@aviaryan
Jun 25 2016 08:26
something to do with params, I suppose
Aditya Vyas
@aditya1702
Jun 25 2016 08:26
No I made a PR regarding sponsors widget and I had defined it properly in it
It was working
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:26
I think I removed it yesterday. 😐
Check my test suit PR
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:26
event_sponsors.delete_view
it's not defined
Aditya Vyas
@aditya1702
Jun 25 2016 08:27
@rafalkowalski niranjan removed it yesterday
:sweat_smile:
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:27
k
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:27
Sorry... Sorry... I thought it wasn't used since we have sponsors in the event wizard
:sweat_smile:
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:27
lol
Aditya Vyas
@aditya1702
Jun 25 2016 08:27
Hehe
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:27
can you fix it?
Aditya Vyas
@aditya1702
Jun 25 2016 08:27
No prob
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:27
Yep. Will do it now.
Aditya Vyas
@aditya1702
Jun 25 2016 08:27
I will do it
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:28
Okay... Do it
Aditya Vyas
@aditya1702
Jun 25 2016 08:28
Ok do it
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:28
please one person to one issue :D
Avi Aryan
@aviaryan
Jun 25 2016 08:28
#1208 is because of it I think
Saptak Sengupta
@SaptakS
Jun 25 2016 08:28
lol
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:28
@aditya1702 Okay.. You or me?
:P
Aditya Vyas
@aditya1702
Jun 25 2016 08:28
Hehe u removed it...u do it
:p
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:29
Alright!
Avi Aryan
@aviaryan
Jun 25 2016 08:29
:smile:
Saptak Sengupta
@SaptakS
Jun 25 2016 08:29
:P
Niranjan Rajendran
@niranjan94
Jun 25 2016 08:33
fossasia/open-event-orga-server#1215
Please review and merge
I have added these links as guides to get API keys for google and fb oauth. Please see
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:37
@aviaryan do you know why when I'm filtering by location_name i don't get any results from API?
Avi Aryan
@aviaryan
Jun 25 2016 08:38
It should work. I'll check
Rafał Kowalski
@rafalkowalski
Jun 25 2016 08:38
please check browse.py
Avi Aryan
@aviaryan
Jun 25 2016 08:42
it could be because of other params privacy and state
when state=Published and privacy=Public, then search is working as expected for me
Aditya Vyas
@aditya1702
Jun 25 2016 08:46
@aviaryan :+1:
Avi Aryan
@aviaryan
Jun 25 2016 08:48
@aditya1702 the links are ok ? feel free to change them if needed in settings.html
Aditya Vyas
@aditya1702
Jun 25 2016 08:53
Ok
I havent looked yet will do so in a few mins
Saptak Sengupta
@SaptakS
Jun 25 2016 11:27
@aviaryan @mariobehling in fossasia/open-event-orga-server#989 I have made the form validation but the problem is in API documentation and in Swagger we show the fields to be optional or required but while validating, we validate according to the custom_forms.. This seems wrong..
And without getting the event_id, it isn't possible to show in Swagger the fields to be optional or required based on custom _forms..
What do you suggest?
Mario Behling
@mariobehling
Jun 25 2016 12:19
@SaptakS I do not have a clear idea. Please add a comment in the issue and others can get back on that.
Saptak Sengupta
@SaptakS
Jun 25 2016 12:20
ohk.. Will do that.
Avi Aryan
@aviaryan
Jun 25 2016 12:20
@SaptakS We can't ignore the custom forms when validating the payloads OR store data not according to the custom form selected by the organizer. That would be just wrong. So what do you suggest ? I think we have no choice but to let the documentation show all fields optional. and then validate according to custom forms. Maybe we can show a different type of error in such a situation. @shivamMg views ?
Mario Behling
@mariobehling
Jun 25 2016 12:20
@aditya1702 It looks like a lot of your issues miss description and it is often difficult to understand which part/feature/function you are specifically talking about. Please actually tell us what the problem is in detail: fossasia/open-event-orga-server#1221
Saptak Sengupta
@SaptakS
Jun 25 2016 12:21
I have done the validation part already.. sending a PR..
Mario Behling
@mariobehling
Jun 25 2016 12:21
@aviaryan That does not work if we access the system through the API from another service, does it?
Saptak Sengupta
@SaptakS
Jun 25 2016 12:21
@aviaryan @shivamMg please do check it because I am not very accustomed with API validation code.. But as far as I tested, its working..
Avi Aryan
@aviaryan
Jun 25 2016 12:22
@SaptakS ok
@mariobehling sorry but I don't understand what you mean by "that" in your question
Mario Behling
@mariobehling
Jun 25 2016 12:28
@aviaryan we need to think through which api functionality we need to be accessible from outside. What comes to my mind is read only at the moment, but maybe more. In howfar is this related to the issue?
Avi Aryan
@aviaryan
Jun 25 2016 12:35
@mariobehling that is not related to the issue
Mario Behling
@mariobehling
Jun 25 2016 12:55
:+1:
Shivam Mamgain
@shivamMg
Jun 25 2016 13:26
@aviaryan +1 for showing fields optional and then validating according to custom forms, doesn't seem we've a lot many options. About the different error for this, we can create a 'CUSTOM_FORM_ERROR', displaying that the error occurred bz data is not consistent with custom forms (which will be different from 'INVALID_FIELD').
Aditya Vyas
@aditya1702
Jun 25 2016 14:16
@mariobehling I will add the description
Avi Aryan
@aviaryan
Jun 25 2016 14:28
@/all Just a friendly note, please don't set s3 credentials when working locally. It affects the data of the main (heroku) server.
Aditya Vyas
@aditya1702
Jun 25 2016 14:28
:+1:
Rafał Kowalski
@rafalkowalski
Jun 25 2016 15:01
k
Rafał Kowalski
@rafalkowalski
Jun 25 2016 15:42
Poland won!
Saptak Sengupta
@SaptakS
Jun 25 2016 16:22
@rafalkowalski congrats...