These are chat archives for fossasia/open-event-server

29th
Jun 2016
Saptak Sengupta
@SaptakS
Jun 29 2016 11:58

@/all if you are designing something and feel like that a component should be shown in large resolution but not in medium resolution or small resolution, I have created 3 css classes for that :- hide-small, hide-medium, hide-large

hide-small: To hide in small resolution
hide-medium: To hide in medium resolution
hide-large: To hide in large resolution

I feel this classes will help in making a lot of the UI responsive..
Niranjan Rajendran
@niranjan94
Jun 29 2016 11:59
Don't we already have hidden-xs , hidden-sm, hidden-lg, hidden-md ?
Saptak Sengupta
@SaptakS
Jun 29 2016 11:59
Those aren't always being responsive with the components as they are created..
So I made these 3..
If hidden-xs, hidden-sm, etc. solves the problem, then its cool.. Otherwise you may try these as well..
Niranjan Rajendran
@niranjan94
Jun 29 2016 12:00
Okay ...
Saptak Sengupta
@SaptakS
Jun 29 2016 12:00
:+1:
Rafał Kowalski
@rafalkowalski
Jun 29 2016 12:01
@/all internal servver error http://open-event.herokuapp.com/
i wil take a look on this
Niranjan Rajendran
@niranjan94
Jun 29 2016 12:02
Multiple heads :)
Mario Behling
@mariobehling
Jun 29 2016 12:03
@SaptakS I am worried about fragmentation. The goal of using the same css everywhere is that if something changes it changes everywhere. So, now we add more classes even increasing complexity, whereas it is really important to keep things simple.
Saptak Sengupta
@SaptakS
Jun 29 2016 12:04
That is the purpose of this classes... On changing it, it will get changed everywhere..
Mario Behling
@mariobehling
Jun 29 2016 12:04
Also we chose genetella, because it seemed to offer all what we need to cover. We are loosing compatibility to later versions, if we do not follow the theme guidelines. I think it is clear that this will happen at one point, but I think it is too early to make this split.
Rafał Kowalski
@rafalkowalski
Jun 29 2016 13:16
ProgrammingError: (psycopg2.ProgrammingError) column settings.storage_place does not exist
I will take care of it
Rafał Kowalski
@rafalkowalski
Jun 29 2016 13:40
fixed
Aditya Vyas
@aditya1702
Jun 29 2016 14:16
@mariobehling Could you please check this. fossasia/open-event-orga-server#1268 :)
Mario Behling
@mariobehling
Jun 29 2016 14:20
@aditya1702 left a comment
Aditya Vyas
@aditya1702
Jun 29 2016 14:21
Ok.will fix it and update the PR
@shivamMg Could you point me to where the text for notifications and mail texts is saved in the code, please?
Shivam Mamgain
@shivamMg
Jun 29 2016 14:47

@mariobehling https://github.com/fossasia/open-event-orga-server/blob/development/open_event/helpers/system_mails.py

Every mail sent is either of these. But for user notifications I haven't created such structures because right now there is only Event-role invitations that are being sent through notifications. Shall I create a system_notifications.pyas well, which will store notifications sent to the user?

Will create an issue for /admin/messages :+1:
Mario Behling
@mariobehling
Jun 29 2016 14:48
Yes, please. Please open an issue for this.
@shivamMg What happened with the sample JSON files?
Why is there a session_types JSON and a social_links JSON again?
Shivam Mamgain
@shivamMg
Jun 29 2016 14:49
The ots16 sample set had that too
so I didn't think and extracted them as well
Mario Behling
@mariobehling
Jun 29 2016 14:49
when did we define an api for that?
we already discussed this long ago and now you just add it back
Shivam Mamgain
@shivamMg
Jun 29 2016 14:49
We don't have apis for that
Mario Behling
@mariobehling
Jun 29 2016 14:50
of course you need to adapt this info to work with the apis
if this is not in the APIs, then it needs to be added
you cannot simply add new JSON structures without discussing
it was a long discussion that we had before and now we start again from scratch
what is going on with you?
Shivam Mamgain
@shivamMg
Jun 29 2016 14:50
The ots sample set was already there
Mario Behling
@mariobehling
Jun 29 2016 14:51
the OTS sample was work in progress
everything derives from our APIs
Shivam Mamgain
@shivamMg
Jun 29 2016 14:51
I did not know
Ok I'll remove them
Mario Behling
@mariobehling
Jun 29 2016 14:51
didnt know the APIs?
Shivam Mamgain
@shivamMg
Jun 29 2016 14:51
Not the APIs
Mario Behling
@mariobehling
Jun 29 2016 14:51
if this information is not in the APIs, then discuss where to add it
Shivam Mamgain
@shivamMg
Jun 29 2016 14:51
I didn't know ots set was being worked on
Mario Behling
@mariobehling
Jun 29 2016 14:52
our reference is the API and the JSON files reflect the APIs. why dont you know that?
Shivam Mamgain
@shivamMg
Jun 29 2016 14:52
Ok shall remove them from ots set as well?
Mario Behling
@mariobehling
Jun 29 2016 14:53
You know, now Jigyasa follows your example and you create more work for other people
that is my real problem
Shivam Mamgain
@shivamMg
Jun 29 2016 14:53
Alright I remove them and give an update here.
Mario Behling
@mariobehling
Jun 29 2016 14:53
if there is no good reason all session information goes into -> session JSON
If there is a good reason, tell us the reason
all event information -> including social goes into events.JSON
Shivam Mamgain
@shivamMg
Jun 29 2016 14:54
OK let me check something first
Mario Behling
@mariobehling
Jun 29 2016 14:54
this needs to be reflected in the API
if there are good reasons to do things differently, then make us aware of them. if not, please do not just change basic stuff of the project
we already defined all APIs and JSON files. There should not be more.
except if there as a reason and all are up to date about this
Shivam Mamgain
@shivamMg
Jun 29 2016 14:56
Ok I'm working on the previous issue and will remove those files.
Mario Behling
@mariobehling
Jun 29 2016 14:56
Please open an issue to update all import/export files and ensure that all data including session types (sessions.JSON) and social links (in events.JSON) are reflected in the existing JSON structure.
Shivam Mamgain
@shivamMg
Jun 29 2016 14:56
:+1:
Mario Behling
@mariobehling
Jun 29 2016 14:58
and please ensure, that all of this is reflected in the APIs
maybe this is again another issue
Shivam Mamgain
@shivamMg
Jun 29 2016 15:01
Ok, I've created a new issue and updated the previous one.
Mario Behling
@mariobehling
Jun 29 2016 15:03
:+1:
link?
Shivam Mamgain
@shivamMg
Jun 29 2016 15:03
fossasia/open-event-orga-server#1187 and fossasia/open-event-orga-server#1327
Mario Behling
@mariobehling
Jun 29 2016 15:24
@shivamMg Other projects are implementing their features to be based on the JSON files. So, it is important that it works. Also see https://gitter.im/fossasia/open-event-android
Shivam Mamgain
@shivamMg
Jun 29 2016 15:24
Yup read that
I'm confirming with avi if we need apis for those two
  • session_types and social_links
Mario Behling
@mariobehling
Jun 29 2016 15:31
@shivamMg no other APIs please
We got rid of the sessions_type API
Do not start it again
integrate this information in the sessions API
and social_links in events API
not sure, how I can make it clear / what I can do to make this clear
except if you have an amazingly convincing reason
which I do not see looking at the data
Shivam Mamgain
@shivamMg
Jun 29 2016 15:34
Alright I just confirmed with Avi, we won't be creating those APIs.
And I'll start working on the issue to remove the samples.
Aditya Vyas
@aditya1702
Jun 29 2016 16:40
@mariobehling fossasia/open-event-orga-server#1268. Modified the screenshot and the PR
@aditya1702 Thanks. Ok, let's test this on the system. Please also test this in detail on the live system and write tests. Thank you
Aditya Vyas
@aditya1702
Jun 29 2016 16:46
Ok :+1:
Mario Behling
@mariobehling
Jun 29 2016 17:07
@aditya1702 Internal server error after last commit or because of sth. else.
Aditya Vyas
@aditya1702
Jun 29 2016 17:09
Will look at it...where did u get it?
Mario Behling
@mariobehling
Jun 29 2016 17:09
everywhere
Aditya Vyas
@aditya1702
Jun 29 2016 17:09
I will check
Aditya Vyas
@aditya1702
Jun 29 2016 19:14
@mariobehling error is fixed
Mario Behling
@mariobehling
Jun 29 2016 20:04
Thanks