These are chat archives for fossasia/open-event-server

8th
Jul 2016
Saptak Sengupta
@SaptakS
Jul 08 2016 08:52
@/all I think we should all squash commits before sending or merging Pull Requests as much as possible.. I know there are more important things in hand but this helps to maintain the history log better and also considered a standard practice.. I find commits like "Merged branch....." in PRs which doesn't make any sense... So I think it is a good practice to squash the commits.. Everyone in the web team and app team does..
Harshit Dwivedi
@the-dagger
Jul 08 2016 08:54
Hm, yeah good point @SaptakS :+1:
Aditya Vyas
@aditya1702
Jul 08 2016 09:08
I too agree @SaptakS :+1:
Mario Behling
@mariobehling
Jul 08 2016 12:19
@SaptakS What are you thoughts about the footer? Do you think, we could have a suitable footer before the end of GSoC?
Saptak Sengupta
@SaptakS
Jul 08 2016 13:14
I will complete it with high priority right away.. Making the footer size equivalent to the above area creates problem with responsiveness..
So I increased the size... I will make the necessary adjustments and try to get it completed ASAP..
Mario Behling
@mariobehling
Jul 08 2016 13:41
@SaptakS I think, it should be possible, what is possible at eventbrite
the whole page it centered and suddenly the footer is left-aligned
I am sure, there are html/css pros somewhere around you, who can help you to solve this
I just wish, we could close this issue at one point
Saptak Sengupta
@SaptakS
Jul 08 2016 13:44
I will get it completed by tomorrow..
Surely
Rafał Kowalski
@rafalkowalski
Jul 08 2016 13:50
@/all where can i store images from instagram?
Saptak Sengupta
@SaptakS
Jul 08 2016 13:56
We can use S3 like all other images, right?
Rafał Kowalski
@rafalkowalski
Jul 08 2016 14:24
k
Saptak Sengupta
@SaptakS
Jul 08 2016 16:18
@mariobehling can you please check the footer and let me know if any other improvement is required?
Mario Behling
@mariobehling
Jul 08 2016 16:27
@SaptakS Please also reduce the height of the country box and align the text in the country to the left.
Saptak Sengupta
@SaptakS
Jul 08 2016 16:27
Ok.. will get it done..
Saptak Sengupta
@SaptakS
Jul 08 2016 16:27
Anything else?
Saptak Sengupta
@SaptakS
Jul 08 2016 18:19
@mariobehling done.. Can you check?
Saptak Sengupta
@SaptakS
Jul 08 2016 18:26
This message was deleted
Mario Behling
@mariobehling
Jul 08 2016 18:57
@SaptakS very good. Thanks
Saptak Sengupta
@SaptakS
Jul 08 2016 18:57
Thanks..
Please let me know if there is anything more to fix..
I have kept the sizes close to eventbrite as well..
Also I am writing a blog on responsive testing.. So that others can also test for responsiveness and report issues..
Mario Behling
@mariobehling
Jul 08 2016 19:18
very good
@SaptakS especially the top bar is not as smooth as eventbrite yet, but it is working ok
Saptak Sengupta
@SaptakS
Jul 08 2016 19:20
Ok.. Will check that as well.. I have checked it in all standard device resolutions.. works fine in them.. Will check thoroughly as well..
Mario Behling
@mariobehling
Jul 08 2016 19:22
don't just check in fixed resolutions
@SaptakS I tried to explain lots of times: Move the sidebar of your browser and check in - All - resolutions
Saptak Sengupta
@SaptakS
Jul 08 2016 19:22
Yeah..
Mario Behling
@mariobehling
Jul 08 2016 19:22
people keep their browser window open in different sizes
Saptak Sengupta
@SaptakS
Jul 08 2016 19:22
I am doing that...
Don't worry...
What I mean't is I haven't done that thoroughly for top bar..
Will do that..
Mario Behling
@mariobehling
Jul 08 2016 19:37
:+1: