These are chat archives for fossasia/open-event-server

17th
Jul 2016
Shivam Mamgain
@shivamMg
Jul 17 2016 09:25
@mariobehling I'm working on to remove invalid data from sample set so the import works. the rest has been done: fossasia/open-event-orga-server#1685
Niranjan Rajendran
@niranjan94
Jul 17 2016 09:26
@mariobehling should these samples along with so many media files be on the repository ? So many media files also increases the repository size. I think it's better to have the sample sets outside of the project repository. We could have jsons here if needed. But the sample media should be outside the repo.
Saptak Sengupta
@SaptakS
Jul 17 2016 09:27
I agree with @niranjan94 ... This increases the project size to a huge amount..
Instead if needed we can create maybe a separate repo where samples are stored..
Manan Wason
@mananwason
Jul 17 2016 09:30
@niranjan94 @SaptakS I suggest using the Open event repo for this. We have other samples there as well https://github.com/fossasia/open-event
Saptak Sengupta
@SaptakS
Jul 17 2016 09:30
@mananwason I agree..
Niranjan Rajendran
@niranjan94
Jul 17 2016 09:31
Good idea @mananwason
Shivam Mamgain
@shivamMg
Jul 17 2016 10:18
OK, We should wait for @mariobehling first
Mario Behling
@mariobehling
Jul 17 2016 11:12
This message was deleted
Ah, yeah. Great use the Open Event repository.
Shivam Mamgain
@shivamMg
Jul 17 2016 11:56
ok i'll submit a pr there.
Shivam Mamgain
@shivamMg
Jul 17 2016 18:08
Can we set the default branch to development. every time someone opens a pr it starts comparing it with master (which usually has very large difference in commits).
Saptak Sengupta
@SaptakS
Jul 17 2016 18:08
I don't see how that is a problem..
Manan Wason
@mananwason
Jul 17 2016 18:09
You can always check the Pr against development also
Saptak Sengupta
@SaptakS
Jul 17 2016 18:10
Thats my point..
Manan Wason
@mananwason
Jul 17 2016 18:10
:+1:
Screen Shot 2016-07-17 at 11.40.15 PM.png
You just need to change the base here by clicking on it
Saptak Sengupta
@SaptakS
Jul 17 2016 18:11
:+1:
Aditya Vyas
@aditya1702
Jul 17 2016 18:11
Abe itna toh kon lazy banta hai @shivamMg :p
Shivam Mamgain
@shivamMg
Jul 17 2016 18:33
lol man I know how to compare branches, how do you think I've been sending prs all this time. I'm just saying if every time you need to change the base to development why not just keep it to development.
@aditya1702 dude, aaj kal sab aatumatic ho gaya he. to ye kyu nhi : P
?
Shivam Mamgain
@shivamMg
Jul 17 2016 18:42
@mariobehling directly from the urls (many of which were google drive and one-drive links).
Mario Behling
@mariobehling
Jul 17 2016 18:43
what is the structure this file event/1
how did you come up with it?
Shivam Mamgain
@shivamMg
Jul 17 2016 18:45
I did not. The ots sample at orga server had the same structure. The images (with speaker and sponsor) and event dir at the root, and json files inside event/1.
Mario Behling
@mariobehling
Jul 17 2016 18:46
Who came up with it? What is the goal to make a subfolder?
The ots sample at orga server had the same structure.
Where is that sample?
Shivam Mamgain
@shivamMg
Jul 17 2016 18:47
let me check history
Where is that sample?
You mean the ots one?
Mario Behling
@mariobehling
Jul 17 2016 18:48
ok, i found it
Mario Behling
@mariobehling
Jul 17 2016 18:48
@mananwason Why did you make the JSON in that way?
@mananwason This merge was not peer-reviewed and you did not answer the questions of @aviaryan. Whast is going on here? fossasia/open-event-orga-server#1681
I am reverting this change.
Mario Behling
@mariobehling
Jul 17 2016 18:55
@shivamMg We need to re-confirm how we build this file. Probably the JSON files can go just go into /event. We also need /audio, /video (even though there stay empty at some events) and the main event picture could go to /images/event/.
What do you think?
Aditya Vyas
@aditya1702
Jul 17 2016 18:58
@mariobehling fossasia/open-event-orga-server#1700
Added the audio files
Saptak Sengupta
@SaptakS
Jul 17 2016 19:02
@aditya1702 please push this into the open event repo rather than this repo..
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:03
@mariobehling Why not let the json files contain the full url to speaker and event images?
Right now, we need to provide the link to folder containing the image like this :
https://raw.githubusercontent.com/fossasia/open-event-orga-server/development/samples/ots16
Now as this might vary from user to user, while making calls to the API, we won't know the exact location where user has uploaded his images.
Mario Behling
@mariobehling
Jul 17 2016 19:09
@the-dagger there are two ways images should be defined in the JSON a) inside the zip folder and b) as a referenced link
@the-dagger there were some earlier discussions here fossasia/open-event-orga-server#1449 and on this chat
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:10
Ok, thanks.
I might've missed it
Mario Behling
@mariobehling
Jul 17 2016 19:15
@SaptakS I have removed the sample files from the repo now. We should work on them in the open-event repo
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:15
@shivamMg https://github.com/fossasia/open-event/tree/master/sample/FOSSASIA16/event/1 here we also need a version.json to verify the data stored in the android app
I will send a PR for it
Saptak Sengupta
@SaptakS
Jul 17 2016 19:15
@mariobehling Thats what I was suggesting as well..
Mario Behling
@mariobehling
Jul 17 2016 19:15
@the-dagger would not it be enough to keep the version info in the event.json?
Saptak Sengupta
@SaptakS
Jul 17 2016 19:15
Because downloading a project with sample files which are of huge size doesn't seem feasible..
Mario Behling
@mariobehling
Jul 17 2016 19:16
:+1:
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:16
@mariobehling in the android app, we first fetch the version.json and then according to its contents, other parts like the speakers,tracks,sessions etc are fetched
Saptak Sengupta
@SaptakS
Jul 17 2016 19:16
Screenshot from 2016-07-18 00:40:43.png
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:17
Sure it can be placed in events but keeping it separately will keep the modularity and reusability of the code intact
Saptak Sengupta
@SaptakS
Jul 17 2016 19:17
btw @mariobehling I worked on the location in Event Step-1 and came up with this:
Please have a look ^^
It functions in the same way as eventbrite..
Mario Behling
@mariobehling
Jul 17 2016 19:23
@the-dagger Please add your thoughts in this issue fossasia/open-event-orga-server#1702
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:28
@mariobehling added my thoughts
But for the meantime, can we have a placeholder version.json in the open-event repo.
As I was working on the App right now.
Parsing of data is done but few app crashes are left to be fixed.
Mario Behling
@mariobehling
Jul 17 2016 19:29
@the-dagger yes, of course, but we need to confirm the final implementation with the orga team
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:29
Sure, I understand.
Mario Behling
@mariobehling
Jul 17 2016 19:29
@aditya1702 Regarding fossasia/open-event-orga-server#1700 Please make changes to the sample JSON to https://github.com/fossasia/open-event/tree/master/sample
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:32
@mariobehling can I merge this for now?
fossasia/open-event#38
Mario Behling
@mariobehling
Jul 17 2016 19:37
Merges should not be done by people themeselves
every PR needs an issue
@the-dagger where is the issue?
why the structure is /event/1/?
these kind of questions should be followed up in issues.
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:38
The 1 here refers to the API version
It is hardcoded for now
@mananwason can answer it better
Mario Behling
@mariobehling
Jul 17 2016 19:38
@the-dagger which API version? where is the issue discussing this?
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:39
I'll create an issue right now
Mario Behling
@mariobehling
Jul 17 2016 19:41
@the-dagger I dont find any issue mentioning why we need empty folders that have subfolders. For now please look at the repo what is the structure of the sample folders. Please do not merge your PRs without someone from the orga-server team.
Saptak Sengupta
@SaptakS
Jul 17 2016 19:41
@the-dagger please create an issue and we will follow it up over there.. I will review the code after that.. :+1:
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:42
Understood.
I am creating an issue in the open-event repository and will ask manan to explain about the structure of the repo.
Mario Behling
@mariobehling
Jul 17 2016 19:42
@the-dagger @mananwason Do not merge yourself anything in the orga-server repo neither without confirming with the orga-team. There are often reasons why things are the way they are and you have not been part of all discussions.
@the-dagger @mananwason Please follow the peer-review practice always. Thanks
Harshit Dwivedi
@the-dagger
Jul 17 2016 19:42
:+1:
Saptak Sengupta
@SaptakS
Jul 17 2016 19:58
@mariobehling the OTS folder that is there in the Open Event repo is an old version I think.. I will fix it up..
Harshit Dwivedi
@the-dagger
Jul 17 2016 20:06
@SaptakS better idea is to remove the OTS folder and rename FOSSASIA2016 to OTS2016
Saptak Sengupta
@SaptakS
Jul 17 2016 20:06
Those are 2 different Events..
LOL
We can't do that...
Harshit Dwivedi
@the-dagger
Jul 17 2016 20:07
This message was deleted
This message was deleted
nvm, my bad
Saptak Sengupta
@SaptakS
Jul 17 2016 20:09
:+1:
Saptak Sengupta
@SaptakS
Jul 17 2016 20:19
@mariobehling I have a confusion..
Which API structure are we following??
Because the OTS16 and FOSSASIA16 have different structures..
Saptak Sengupta
@SaptakS
Jul 17 2016 20:30
@mariobehling can you please have a look at this:
fossasia/open-event#39
I changed the OTS sample data structure to match FOSSASIA16 sample data structure as it was missing some keys in the JSON..
Mario Behling
@mariobehling
Jul 17 2016 20:31
@niranjan94 There were PR from you to master, that should have gone to development. We now have code in master, that does not seem to be in development. https://github.com/fossasia/open-event-orga-server/tree/master
Saptak Sengupta
@SaptakS
Jul 17 2016 20:32
I will check this out and try to merge it from Command Line..
Mario Behling
@mariobehling
Jul 17 2016 20:34
thanks
Saptak Sengupta
@SaptakS
Jul 17 2016 20:34
:+1:
Saptak Sengupta
@SaptakS
Jul 17 2016 22:22
@mariobehling merged commits of master to development branch
fossasia/open-event-orga-server#1704
Mario Behling
@mariobehling
Jul 17 2016 22:22
thanks
Saptak Sengupta
@SaptakS
Jul 17 2016 22:23
@/all I would request everyone to please check that all the changes that have made previously are still working. There were a lot number of conflicts and I hope haven't messed up anything.. :) As far as I have tested everything is working..
But still its better if everyone could test there features again..
RafaƂ Kowalski
@rafalkowalski
Jul 17 2016 22:26
ok