These are chat archives for fossasia/open-event-server

18th
Jul 2016
Niranjan Rajendran
@niranjan94
Jul 18 2016 01:24
@mariobehling that commit is present in development too. The reason it was made to master too was, there was a bug in settings that causes a system wide internal server error everytime settings was changed. No clash because of that.
Manan Wason
@mananwason
Jul 18 2016 01:36

@mariobehling Sorry for the late reply. Since we are trying to emulate the api via these json files, I added this directory to make it look like an endpoint.

@mananwason Why did you make the JSON in that way?

Internally this will be one directory but it emulates the files such that it looks like they're coming from an api.
Shivam Mamgain
@shivamMg
Jul 18 2016 04:55
@mariobehling we can go with this https://i.imgur.com/sRY77FC.png what do you think.
@the-dagger I've posted a comment at the version issue on how caching can be implemented without downloading similar data, and without the version api. fossasia/open-event-orga-server#1702
Mario Behling
@mariobehling
Jul 18 2016 07:24
@shivamMg Please post the structure in the issue and change audios -> audio, videos -> video
Mario Behling
@mariobehling
Jul 18 2016 08:13
@niranjan94 in our application structure, we have our code in the folder "open_event". When we change the name, this folder does not have the right name. The question is anyways, why a folder with an application should have the name of the project. Are these standard naming conventions? Or is the folder with app code named differently usually? Maybe "app"?
Niranjan Rajendran
@niranjan94
Jul 18 2016 08:14
Usually sometimes like 'app' is used since it's generic.
We could do the same here.
Mario Behling
@mariobehling
Jul 18 2016 08:19
Ok, agree. Generic is better.
Please make the required changes.
Niranjan Rajendran
@niranjan94
Jul 18 2016 08:20
Will do.
Aditya Vyas
@aditya1702
Jul 18 2016 08:34
@mariobehling fossasia/open-event#40
Mario Behling
@mariobehling
Jul 18 2016 08:46
@aviaryan We talked last week about how to implement both internal links and external links to images in the JSON files. What is the progress here?
Aditya Vyas
@aditya1702
Jul 18 2016 08:49
@mariobehling The .idea folder was already there when I cloned the repo
It is hidden
I did not add it
@aditya1702 A question in the issue tracker -> should be answered in the issue tracker. I am getting confused answering one thing and one thing there.
in any case idea/ should not be in there.
Aditya Vyas
@aditya1702
Jul 18 2016 08:53
@mariobehling Sorry for that. And will remove it immediately
Mario Behling
@mariobehling
Jul 18 2016 08:55
I will take care of this with @aviaryan
@aditya1702 Please help us to solve some real coding issues.
Aditya Vyas
@aditya1702
Jul 18 2016 08:56
Ok.
Mario Behling
@mariobehling
Jul 18 2016 10:40
@rafalkowalski Please make the weekly merge from development to master
Rafał Kowalski
@rafalkowalski
Jul 18 2016 10:43
ok
Mario Behling
@mariobehling
Jul 18 2016 10:47
@SaptakS please resolve the errors in your last PR
Mario Behling
@mariobehling
Jul 18 2016 11:02
@rafalkowalski What is the reason codacy finds issues. I wonder why they did not come up earlier.
fossasia/open-event-orga-server#1708
Aditya Vyas
@aditya1702
Jul 18 2016 11:04
@mariobehling I think because we dont have codacy in development branch
Rafał Kowalski
@rafalkowalski
Jul 18 2016 11:05
@aditya1702 i think also that itis the reason
Mario Behling
@mariobehling
Jul 18 2016 11:06
@rafalkowalski please add codacy in dev branch and fix issues
open an issue for it in the tracker please
Rafał Kowalski
@rafalkowalski
Jul 18 2016 11:08
ok :)
there are a few bugs which are related with libraries so i will try to exclude this bugs in codacy
Saptak Sengupta
@SaptakS
Jul 18 2016 11:24
I will get I done in a moment
Mario Behling
@mariobehling
Jul 18 2016 19:38
@rafalkowalski Looks like you commited again to master instead of development. Am I missing sth?
Ankit Saini
@sainiak009
Jul 18 2016 19:41
Hello, I am Ankit
Undergraduate student from IIT KGP and I want to contribute in API
I forked the repo
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:42
again? @mariobehling
i don't understand, i've only merged development with master
Mario Behling
@mariobehling
Jul 18 2016 19:43
dev is 2 commits behind master.
Why did not you merge from development to master, but from your personal repo?
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:44
it was more comfortable for me
Mario Behling
@mariobehling
Jul 18 2016 19:45
it creates issues
the flow is development to master
I dont know what else to say or how could I formulate it differently? Where is the difficulty?
We need to merge development to master. What else to explain?
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:48
in next weekend i will merge it correctly
sorry
Mario Behling
@mariobehling
Jul 18 2016 19:48
@rafalkowalski Please revert and fix the issue.
@rafalkowalski Did you set up the codacy bot for the dev branch as discussed earlier?
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:49
i can't because account belows to Justin
Mario Behling
@mariobehling
Jul 18 2016 19:49
@rafalkowalski It is easy to register an account.
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:50
maybe i will change settings to my account
Mario Behling
@mariobehling
Jul 18 2016 19:50
@rafalkowalski We talked about this earlier and you did not get back about this, why not?
we apparently have quality issues and they need to be solved
Please 1. Revert master 2. Set up codacy on dev branch 3. fix issues on dev branch 4. merge to master
Ankit Saini
@sainiak009
Jul 18 2016 19:53
Okay I think I can talk now.I am facing an issue while installing locally
While installing dev requirements by "npm install" I am getting this error in the middle error : "Command "python setup.py egg_info" failed with error code 1"
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:54
@sainiak009 have you tried installation by vagrant?
Ankit Saini
@sainiak009
Jul 18 2016 19:55
No
Okay. I will try by vagrant.
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:55
ok cool
Mario Behling
@mariobehling
Jul 18 2016 19:56
@sainiak009 Please report this issue on the issue tracker.
Ankit Saini
@sainiak009
Jul 18 2016 19:57
Okay @mariobehling
Rafał Kowalski
@rafalkowalski
Jul 18 2016 19:57
@sainiak009 but write good description how can we achieve this bug
Ankit Saini
@sainiak009
Jul 18 2016 19:57
Okay. I will @rafalkowalski
@aviaryan
Any response on that?
Rafał Kowalski
@rafalkowalski
Jul 18 2016 20:08
@mariobehling do we need revert ? i think merge dev with master will solve problem
Mario Behling
@mariobehling
Jul 18 2016 20:09
you can try but there is a conflict at the moment
in any case before the merge please ensure the codacy issues are solved. today you just merged the code and did not solve the issues. we need to have quality code.
Saptak Sengupta
@SaptakS
Jul 18 2016 20:19
@mariobehling solving all the codacy issues are unrealistic because there are certain issues solving which might result in the breaking of code..
Most of them can be solved but getting a PR without any codacy issues can be little difficult..
Mario Behling
@mariobehling
Jul 18 2016 20:20
@SaptakS solve what is possible and open an issue to look into more details with a link to the PR.
Saptak Sengupta
@SaptakS
Jul 18 2016 20:21
Yeah.. Sure..
Will do that..
And I will fix the commit difference in dev..
No need to revert..
Its better to merge the 2 commits to dev from master..
Rafał Kowalski
@rafalkowalski
Jul 18 2016 20:26
do you know which commits?
Saptak Sengupta
@SaptakS
Jul 18 2016 20:26
Yup..
I will do it in a moment..
Saptak Sengupta
@SaptakS
Jul 18 2016 21:16
@mariobehling branches fixed... Now dev branches is 0 commits behind master..