These are chat archives for fossasia/open-event-server

23rd
Jul 2016
Niranjan Rajendran
@niranjan94
Jul 23 2016 02:51
Yes. That's already possible.
You can use the session, micro locations, tracks specific endpoint and get individual data for each too
Mario Behling
@mariobehling
Jul 23 2016 03:27
@niranjan94 Internal Server Error
Could you have a look, please?
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:28
I'm looking at it right now... Will fix it.
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:38
@mariobehling This fossasia/open-event-orga-server#1804 fixes it
Mario Behling
@mariobehling
Jul 23 2016 03:50
Merge attempt failed
Merge commits are not allowed on this repository.
@niranjan94 What message is this? Never seen it.
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:52
We got the same error yesterday... Then it disappeared after a while... We assumed it was a github internal error
Mario Behling
@mariobehling
Jul 23 2016 03:52
hm
Somebody changed this branch to a protected branch
who was it?
Disables force-pushes to this branch and prevents it from being deleted.
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:55
Myself. Had done it a few weeks ago. To prevent force pushes.
Mario Behling
@mariobehling
Jul 23 2016 03:55
well, not sure what are force-pushes, but we definitely do not want the branch to get deleted. so that is ok.
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:56
Okay :+1:
Manan Wason
@mananwason
Jul 23 2016 03:56
@niranjan94 @mariobehling Force pushes are required
If you want to rebase and squash or for deleting a errored commit, force pushes are required.
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:56
Only during certain special cases. We can always unprotect the branches temporarily.
Mario Behling
@mariobehling
Jul 23 2016 03:56
hm. so, i temporarily deactivated protected branch, but it still does not merge
activated it again
Manan Wason
@mananwason
Jul 23 2016 03:57
Let me check @mariobehling
Niranjan Rajendran
@niranjan94
Jul 23 2016 03:59
@mariobehling the merge error is unrelated to
This.
@mariobehling I was able to merge now
Manan Wason
@mananwason
Jul 23 2016 03:59
What was it @niranjan94
I was also not able to merge
Niranjan Rajendran
@niranjan94
Jul 23 2016 04:00
I'm not sure... I just pressed merge as usual :sweat_smile:
And it worked.
Manan Wason
@mananwason
Jul 23 2016 04:00
:confused:
Niranjan Rajendran
@niranjan94
Jul 23 2016 04:01
Now when I try to merge another PR... Same error.
:/
Manan Wason
@mananwason
Jul 23 2016 04:02
That is strange. What is the link to this PR?
Niranjan Rajendran
@niranjan94
Jul 23 2016 04:04
fossasia/open-event-orga-server#1802
Manan Wason
@mananwason
Jul 23 2016 04:04
It's merging :confused:
Is it fine that it's merged or should we revert @niranjan94 ?
Niranjan Rajendran
@niranjan94
Jul 23 2016 04:05
Brilliant!... This is confusing...
It's fine... No need to revert
Manan Wason
@mananwason
Jul 23 2016 04:05
This is really weird. I have never encountered anything like this :worried:
Next time anyone sees it. Please file a bug with Github @/all
Niranjan Rajendran
@niranjan94
Jul 23 2016 04:07
:+1:
Mario Behling
@mariobehling
Jul 23 2016 04:14
@niranjan94 Server error still persists
Niranjan Rajendran
@niranjan94
Jul 23 2016 04:27
@mariobehling migrations issue. Fixed.
Saptak Sengupta
@SaptakS
Jul 23 2016 05:09
The same error happened with me yesterday.. I tried 5 minutes later.. it worked..
Mario Behling
@mariobehling
Jul 23 2016 09:02
@aviaryan @niranjan94 Right now if I use the API with all info I get one big JSON, is that correct? http://open-event-dev.herokuapp.com/api/v2/events/9?include=sessions,microlocations,tracks,speakers,sponsors
Mario Behling
@mariobehling
Jul 23 2016 09:06
Is that, what the app folks need? Can they handle one big JSON?
Niranjan Rajendran
@niranjan94
Jul 23 2016 09:06
It's upto them to choose what they want to use ... They have both options ... They can either get one big json or get smaller ones
Mario Behling
@mariobehling
Jul 23 2016 09:06
If not, would it be possible to provide the links to the single files in the meta.json?
Niranjan Rajendran
@niranjan94
Jul 23 2016 09:07
@mariobehling the links need not be provided anywhere ... They are simple and generatable based on event ID
Saptak Sengupta
@SaptakS
Jul 23 2016 09:07
And they are already available in the swagger info..
The links are generic so I think they won't have any trouble..
Mario Behling
@mariobehling
Jul 23 2016 09:09
We need to think this through. We have not achieved the final goal yet. For example, if there is an open event installation with many events, we cannot just make the API openly available and potentially get a large number of requests.
The API should be limited by adding a hash key for example.
Saptak Sengupta
@SaptakS
Jul 23 2016 09:10
Yes.. We need to think through the API authentication system.
Right now except for the GET request, one needs to be logged in to the open event server to make other requests like POST, PUT, etc.
Mario Behling
@mariobehling
Jul 23 2016 09:10
Also, if all of the swagger info should be public. I am not clear about that. We also have internal APIs documented there, right?
Saptak Sengupta
@SaptakS
Jul 23 2016 09:11
I don't understand what do you mean by internal APIs..
Swagger page has all the APIs info I think..
Niranjan Rajendran
@niranjan94
Jul 23 2016 09:12
Swagger page has tracks, sessions, speakers, microlocations, sponsors, events, users ... I think that correct
Saptak Sengupta
@SaptakS
Jul 23 2016 09:13
Yeah..
Mario Behling
@mariobehling
Jul 23 2016 09:15
we also need to integrate the app generators. The app generator should be able to get the private data e.g. email of organizer and potentially access to other features of the system, e.g. use the email system of the orga server.
best would be to make this accessible through APIs as well
we dont want to integrate those app completely
Saptak Sengupta
@SaptakS
Jul 23 2016 09:16
We can restrict the access level by assigning roles just like we do normally I think..
What do you say @niranjan94 ?
Niranjan Rajendran
@niranjan94
Jul 23 2016 09:17
Yes. Sounds good.
Mario Behling
@mariobehling
Jul 23 2016 09:18
@SaptakS @niranjan94 How do others implement such microservices?
Saptak Sengupta
@SaptakS
Jul 23 2016 09:19
Generally in API people are allowed to generate hash according to the level of permission and roles..
And using this hash they can authorize and get access to the APIs based on the hash generated..
Mario Behling
@mariobehling
Jul 23 2016 09:22
@SaptakS So, it would be suitable for the Android app, right?
And in regards to the app generators, we make them "users" in the system and assign "roles".
Saptak Sengupta
@SaptakS
Jul 23 2016 09:22
All google APIs, facebook APIs use that.. So I think it will be suitable..
However I will discuss with them once..
Yes.. that's what I was saying..
Mario Behling
@mariobehling
Jul 23 2016 09:23
@SaptakS Please open an issue for the hash, but do not make it a priority. It can also work without hashes for now. We need to solve more bugs in the system first.
Saptak Sengupta
@SaptakS
Jul 23 2016 09:23
Yes..
Mario Behling
@mariobehling
Jul 23 2016 09:23
Regarding the apps, this has higher priority though.
Saptak Sengupta
@SaptakS
Jul 23 2016 09:23
I will open an issue right away and assign it the next milestone?
Mario Behling
@mariobehling
Jul 23 2016 09:23
ok
or one later
Saptak Sengupta
@SaptakS
Jul 23 2016 09:24
Ok.. Great..
Mario Behling
@mariobehling
Jul 23 2016 09:24
How can apps easily use the mailing system of open event?
Saptak Sengupta
@SaptakS
Jul 23 2016 09:25
Hmm.. I have to look into that.. Right now I don't think they can..
Actually on a second thought, if they make a POST or PUT request through the API, we can implement the mailing system in the APIs...
Mario Behling
@mariobehling
Jul 23 2016 09:25
Remember, we don't want to integrate the apps. It is also much easier to maintain them separately. Yes, right now they cannot, but could we give them an internal API for that? This would be nice. It would also be possible that they use sendgrid directly, but then we do not see the apps activity in our logs.
Saptak Sengupta
@SaptakS
Jul 23 2016 09:26
So when they make an API request, the mail is sent..
However for the user_control settings, we need to think something..
I will think it through and let you know..
Mario Behling
@mariobehling
Jul 23 2016 09:27
@SaptakS Sounds good. Please open an issue as well. Thanks
Saptak Sengupta
@SaptakS
Jul 23 2016 09:27
Ok great..
Mario Behling
@mariobehling
Jul 23 2016 09:33
@niranjan94 So in the API list, did we include all APIs that are relevant? I see more APIs in the example exports e.g. https://github.com/fossasia/open-event/tree/master/sample/EhealthAfrica
Saptak Sengupta
@SaptakS
Jul 23 2016 09:34
@mariobehling Issue for hash: fossasia/open-event-orga-server#1806
Mailing issue: fossasia/open-event-orga-server#1807
@mariobehling all these APIs are present..
Some of them are bundled together..
For example you can find the session_type APIs in the list of Session APIs..
Mario Behling
@mariobehling
Jul 23 2016 09:37
@SaptakS So, why are not they bundled together in the export?
Saptak Sengupta
@SaptakS
Jul 23 2016 10:07
Not sure about that...
Mario Behling
@mariobehling
Jul 23 2016 10:19
@aviaryan @niranjan94 Any idea?
Niranjan Rajendran
@niranjan94
Jul 23 2016 10:22
Actually , the social_links are bundled inside event.json ... So, I guess social_links.json could be removed
custom_form.json and social_links.json can be removed and provided inside event.json
session_types json can also be remove as it's already provided for each session inside sessions.json
Mario Behling
@mariobehling
Jul 23 2016 16:24
@aditya1702 @shivamMg Inhowfar can the ticketing functions be tested already? Can we switch them on the modules page?
Aditya Vyas
@aditya1702
Jul 23 2016 16:36
@mariobehling Yes the modules page works
Mario Behling
@mariobehling
Jul 23 2016 16:50
ok, good, but where can i see visual features of the ticketing system already?
Aditya Vyas
@aditya1702
Jul 23 2016 17:00
Right now..on switching on/off the ticketing on modules the ticket url gets enabled/disabled on the event page
Rafał Kowalski
@rafalkowalski
Jul 23 2016 17:01
can you provide tickets urls
?
Mario Behling
@mariobehling
Jul 23 2016 17:02
@aditya1702 Which issue is describing this? Which is the relevant issue?
Aditya Vyas
@aditya1702
Jul 23 2016 17:02
@mariobehling I am talking about this issue. fossasia/open-event-orga-server#1674
I have implemented the modules page and on enabling or disabling the ticketing the admin can change whether ticket url is displayed during event creation or not
Mario Behling
@mariobehling
Jul 23 2016 17:04
I think this is a misunderstanding and I dont find any info about this in the issue.
Rafał Kowalski
@rafalkowalski
Jul 23 2016 17:05
i can help you @aditya1702
Mario Behling
@mariobehling
Jul 23 2016 17:06
If ticketing system is switched on we should get a ticket service like eventbrite or eventnook as a module. The module is switched on: A) The user has the possibility to use the URL or switch to ticket module (like eventbrite). B) If the module is switched off the user can enter an URL (just like it was before).
Aditya Vyas
@aditya1702
Jul 23 2016 17:06
Actually that was to be implemented by shivam...I will talk with him and implement the part of the module
Mario Behling
@mariobehling
Jul 23 2016 17:07
@aditya1702 It should all be discussed on the issues not in your private chat, where we are all shut down and then see the result at some point.
Aditya Vyas
@aditya1702
Jul 23 2016 17:07
Yes @mariobehling Will follow on it asap and show you the system
The ticketing system
Rafał Kowalski
@rafalkowalski
Jul 23 2016 17:08
i think we can divide this huge task to smaller issues
Aditya Vyas
@aditya1702
Jul 23 2016 17:09
Yes @rafalkowalski
Mario Behling
@mariobehling
Jul 23 2016 17:12
@rafalkowalski @aditya1702 Please tag all "Ticketing" https://github.com/fossasia/open-event-orga-server/labels/Ticketing
Rafał Kowalski
@rafalkowalski
Jul 23 2016 17:12
ok
Mario Behling
@mariobehling
Jul 23 2016 17:16
@rafalkowalski @aditya1702 A sample of the form is here fossasia/open-event-orga-server#1112
Aditya Vyas
@aditya1702
Jul 23 2016 17:16
Yes
Ok
Mario Behling
@mariobehling
Jul 23 2016 17:48
@aviaryan Please let us know the details about the export files and the differences to the API. I have added a comment here fossasia/open-event-orga-server#1786
Mario Behling
@mariobehling
Jul 23 2016 19:50
@niranjan94 internal server error
could you check, pleasE?
Saptak Sengupta
@SaptakS
Jul 23 2016 19:51
I will check..
Saptak Sengupta
@SaptakS
Jul 23 2016 19:52
let me see..
Saptak Sengupta
@SaptakS
Jul 23 2016 20:03
Its a migration error..
I will try to get it fixed..
Mario Behling
@mariobehling
Jul 23 2016 20:05
thanks
Saptak Sengupta
@SaptakS
Jul 23 2016 20:13
@mariobehling fossasia/open-event-orga-server#1816 this should fix it..
Shivam Mamgain
@shivamMg
Jul 23 2016 20:36
@mariobehling Sorry, the notifications websockets feature is taking more time than I had imagined: fossasia/open-event-orga-server#1772. I'm using flask-socketio library and it requires a change to our dependenices to work properly. I'll complete adding ticketing to form before sunday evening. My college is opening on monday and I'll be busy with registration and room allocation on that day.
@/all regarding the notification websocket feature ^, it isn't working properly with the development flask server, it needs gunicorn. On flask dev server it fallsback to long polling and then starts hanging up page loads between requests. It works well with gunicorn, but it means shifting gunicorn on development phase (shifting it to common.txt).
Mario Behling
@mariobehling
Jul 23 2016 20:42
@shivamMg Thanks for the info. Do we have any other dependent components that need to be changed because of that?
Saptak Sengupta
@SaptakS
Jul 23 2016 20:44
@mariobehling the internal server has been fixed..
Mario Behling
@mariobehling
Jul 23 2016 20:48
great. working now. thanks
Saptak Sengupta
@SaptakS
Jul 23 2016 20:48
:+1:
Saptak Sengupta
@SaptakS
Jul 23 2016 21:36
@mariobehling in this issue: fossasia/open-event-orga-server#1413
One already gets emails on accept or reject based on the email settings and admin settings..
So do we need to implement this again?
Mario Behling
@mariobehling
Jul 23 2016 21:42
@SaptakS Ok, help me out please. Which email settings exactly. Sample link?
This is where we set up the email preferences..
For all individual event, if you are an organizer, you get the option to turn on/off accept/reject session..
Mario Behling
@mariobehling
Jul 23 2016 21:44
Dont see it
Screenshot from 2016-07-23 23:44:26.png
Saptak Sengupta
@SaptakS
Jul 23 2016 21:45
Yeah.. There is a bug in admin message tab..
I will fix that..
@mariobehling check once more now..
If you are a speaker in any of the event, that option will appear..
Mario Behling
@mariobehling
Jul 23 2016 21:48
Screenshot from 2016-07-23 23:48:07.png
what is the exact name of the option?
Saptak Sengupta
@SaptakS
Jul 23 2016 21:48
You need to be a speaker in some event..
Screenshot from 2016-07-24 03:18:20.png
For example I am a speaker in this "Scheduler Test Event". So I get the "Your Session is Accepted or Rejected" option..
Mario Behling
@mariobehling
Jul 23 2016 21:53
The speaker should not have the option to switch this on/off
I changed the setting in the admin page
But you are referring to the wrong end.
Saptak Sengupta
@SaptakS
Jul 23 2016 21:53
Yeah.. Now there is no option to switch on/off..
Mario Behling
@mariobehling
Jul 23 2016 21:53
The question of that issue is: If the organizer wants to send out the email in that moment or not.
I forgot who implemented that page http://open-event-dev.herokuapp.com/admin/messages/
?
Saptak Sengupta
@SaptakS
Jul 23 2016 21:54
I improved the page..
Don't know who implemented the page initially..
Why?
Mario Behling
@mariobehling
Jul 23 2016 21:55
Ok, so please improve it more. The size of the table header is different to the standard design of the other tabs. "Update Settings" should be on the bottom right.
Saptak Sengupta
@SaptakS
Jul 23 2016 21:55
Ok..
Cool..
Will get that done..
Mario Behling
@mariobehling
Jul 23 2016 21:55
Previous/Next should only show up if there are entries to show a previous / next page
please open an issue for these thing
s
Saptak Sengupta
@SaptakS
Jul 23 2016 21:56
And as of the email setting.. In that case it is not adding a feature.. Because it is already added by default right now... So we need to modify that.. And I haven't seen into how that is implemented..
Yeah.. I will open an issue..
Mario Behling
@mariobehling
Jul 23 2016 21:57
"Reset Password option" should not have the possibility to switch it off by the user
Saptak Sengupta
@SaptakS
Jul 23 2016 21:57
Yeah.. This I wanted to ask.. Should we have user-control for reset password, user registration and stuff?
Mario Behling
@mariobehling
Jul 23 2016 21:58
Email Confirmation to Create Account for Open-Event
Saptak Sengupta
@SaptakS
Jul 23 2016 21:58
Ok..
Mario Behling
@mariobehling
Jul 23 2016 21:58
also should not be possible to configure it switch off.
Saptak Sengupta
@SaptakS
Jul 23 2016 21:58
Yeah..
There won't be a checkbox at all..
got it..
Mario Behling
@mariobehling
Jul 23 2016 21:58
please take out these options to configure it even for the admin. There is not logic in switching it off.
Saptak Sengupta
@SaptakS
Jul 23 2016 21:58
yeah.. Great...
will do that right away..
Mario Behling
@mariobehling
Jul 23 2016 22:00
After Event should have notification option
Saptak Sengupta
@SaptakS
Jul 23 2016 22:00
Should I make a separate issue or point it here:
fossasia/open-event-orga-server#1665
Mario Behling
@mariobehling
Jul 23 2016 22:00
Event Published - notification option
Saptak Sengupta
@SaptakS
Jul 23 2016 22:01
Well, the notification system hasn't been made for it.. So it isn't there..
Notification option is there only for those notification is added in backend.. So once those notifications are added, it will get updated..
Mario Behling
@mariobehling
Jul 23 2016 22:01
made for it?
Saptak Sengupta
@SaptakS
Jul 23 2016 22:01
I will make the changes..
Mario Behling
@mariobehling
Jul 23 2016 22:01
ahh ok
Saptak Sengupta
@SaptakS
Jul 23 2016 22:02
I will create issues and start solving them..
Mario Behling
@mariobehling
Jul 23 2016 22:02
but I think this feature looks good already. Just, stick to standards please
Saptak Sengupta
@SaptakS
Jul 23 2016 22:02
yes.. this is how it will stay..
What I am saying is right now the code for sending notification on "After Event" is not there.. Once I add that, it will automatically show up in this page..
I will take care of it right away..
Mario Behling
@mariobehling
Jul 23 2016 22:04
ok, good
so, are you clear about this issue? fossasia/open-event-orga-server#1413
give the organizer to send out the email right at that time or later.
Saptak Sengupta
@SaptakS
Jul 23 2016 22:05
Yes... we need to give the organizer option to send email or later..
Mario Behling
@mariobehling
Jul 23 2016 22:05
and mark if it has been send in the table
Saptak Sengupta
@SaptakS
Jul 23 2016 22:05
Yeah..
Will have to make too many modifications in the way emails are handled...
:)
Mario Behling
@mariobehling
Jul 23 2016 22:06
cause the organizers sometimes want to add an additional text and they might need time.
Saptak Sengupta
@SaptakS
Jul 23 2016 22:06
Yeah true.. got the use case..
Will have to check how I can implement..
Mario Behling
@mariobehling
Jul 23 2016 22:06
just split it into several issues if necessary
Saptak Sengupta
@SaptakS
Jul 23 2016 22:06
Meanwhile I will solve these other enhancement issues..
Ok.. Will do that..
Mario Behling
@mariobehling
Jul 23 2016 22:06
great
Saptak Sengupta
@SaptakS
Jul 23 2016 22:06
:+1:
Saptak Sengupta
@SaptakS
Jul 23 2016 22:31
Screenshot from 2016-07-24 03:59:56.png
@mariobehling when we have the previous/next button, I think this will look a little weird..
Should we move it to the left of the page or left of the previous/next button?
I personally think left of page will be better