These are chat archives for fossasia/open-event-server

24th
Jul 2016
Shivam Mamgain
@shivamMg
Jul 24 2016 05:38 UTC

Do we have any other dependent components that need to be changed because of that?

@mariobehling No, other components do not require any changes.
The feature is working, I've it on my branch: https://github.com/shivamMg/open-event-orga-server/tree/notifs/websockets . I'll submit a pr with some minor changes after I reach college so if something goes wrong on heroku I'll be available.

Mario Behling
@mariobehling
Jul 24 2016 06:40 UTC
@SaptakS Actually, best would be to apply the changes without the need for a save/update button. Please move to the bottom right and I will create a follow up issue. So, we dont clutter this chat with too much detail.
Mario Behling
@mariobehling
Jul 24 2016 06:57 UTC
@aviaryan What is your idea about the APIs and export files? https://github.com/fossasia/open-event-orga-server/issues/1786#issuecomment-234731001
Saptak Sengupta
@SaptakS
Jul 24 2016 07:40 UTC
Ok..
Avi Aryan
@aviaryan
Jul 24 2016 10:06 UTC
@mariobehling sorry for the delay. I have posted a comment https://github.com/fossasia/open-event-orga-server/issues/1786#issuecomment-234768569
Actually , the social_links are bundled inside event.json ... So, I guess social_links.json could be removed
Yes social_links can be removed but not session_types. (see the above comment link)
custom_form.json and social_links.json can be removed and provided inside event.json
@niranjan94 @mariobehling @shivamMg currently custom_forms data are not part of any API. If we are to move it to event.json, then event.json will not match with the Event API. So should we add custom_forms data to Event API ? or just let it be as a separate file as it is now.
Mario Behling
@mariobehling
Jul 24 2016 10:16 UTC
Yes, I think forms is a different area and we could have another API "Forms"
make it short. No need for "Custom_"
@aviaryan This topic is getting bigger and new questions are coming up. Please try to close some issues today.
Avi Aryan
@aviaryan
Jul 24 2016 12:22 UTC
@mariobehling :+1:
Shivam Mamgain
@shivamMg
Jul 24 2016 12:24 UTC
@aditya1702 @mariobehling fossasia/open-event-orga-server#1829
Avi Aryan
@aviaryan
Jul 24 2016 13:04 UTC
@niranjan94 Do you any idea about errors like
DETAIL:  Key (transaction_id)=(3551) already exists.
 [SQL: 'INSERT INTO speakers_sessions_version (speaker_id, session_id, transaction_id, operation_type) VALUES (%(speaker_id)s, %(session_id)s, %(transaction_id)s, %(operation_type)s)'] [parameters: {'operation_type': 0, 'session_id': 79, 'transaction_id': 3551L, 'speaker_id': 76}]
2016-07-24 18:25:58,130: ERROR/Worker-1] DB Exception! (psycopg2.IntegrityError) duplicate key value violates unique constraint "speakers_sessions_version_pkey"
@niranjan94 Is there a way to turn off sqlalchemy continuum ?
these errors happen all the time when importing ots sample. I think this is because in ots sample the relation betn sessions and speakers is not one-one. It is many-many.
Mario Behling
@mariobehling
Jul 24 2016 13:14 UTC
@rafalkowalski Could you check, please. there is an internal server error.
Niranjan Rajendran
@niranjan94
Jul 24 2016 13:20 UTC
@aviaryan no... It's not because of that.. It's because of transactions... Do a db commit after adding each relation. It'll fix it.
Avi Aryan
@aviaryan
Jul 24 2016 13:23 UTC
@niranjan94 ok. will see. right now I temporary disabled revisioning on sessions table and succeeded on importing the ots sample correctly.
Niranjan Rajendran
@niranjan94
Jul 24 2016 13:31 UTC
@aviaryan has the same error before over here fossasia/open-event-orga-server#1784 You can see how that was resolved
@mariobehling I'll fix the Internal server error
Avi Aryan
@aviaryan
Jul 24 2016 13:33 UTC
@niranjan94 thanks. If I get it right, the key part is making a commit after changing sessions.speakers , like https://github.com/fossasia/open-event-orga-server/pull/1785/files#diff-aa9d7cf132920541a1c3195a7c7961fbR549
Niranjan Rajendran
@niranjan94
Jul 24 2016 13:34 UTC
Yep. Exactly :)
Avi Aryan
@aviaryan
Jul 24 2016 13:36 UTC
@niranjan94 cool. I will try to fix it.
Niranjan Rajendran
@niranjan94
Jul 24 2016 13:45 UTC
@mariobehling the errors have been resolved
Mario Behling
@mariobehling
Jul 24 2016 14:11 UTC
@niranjan94 http://open-event-dev.herokuapp.com/events/85/edit/ click save -> bad request
Niranjan Rajendran
@niranjan94
Jul 24 2016 14:12 UTC
I'll check
@mariobehling no error. Could you try once again ?
Mario Behling
@mariobehling
Jul 24 2016 14:14 UTC
Internal Server Error
Niranjan Rajendran
@niranjan94
Jul 24 2016 14:14 UTC
Mario Behling
@mariobehling
Jul 24 2016 14:16 UTC
great. working now
@niranjan94 please go with your cursor over the "private link"
what do you see?
Niranjan Rajendran
@niranjan94
Jul 24 2016 14:17 UTC
I see a :no_entry_sign: symbol ...
It's because the input is marked as disabled.
I can override and remove it if required
Mario Behling
@mariobehling
Jul 24 2016 14:18 UTC
yeah. can we have a better solution, eg. like a box at youtube when you copy a link
Niranjan Rajendran
@niranjan94
Jul 24 2016 14:18 UTC
Sure ... I'll implement it
Mario Behling
@mariobehling
Jul 24 2016 14:18 UTC
so, i just made the call for papers private. in this case the link does not work for me anymore
Niranjan Rajendran
@niranjan94
Jul 24 2016 14:19 UTC
Oh :sweat: ... forgot to remove the private/public check for that ...
will do it right away
Mario Behling
@mariobehling
Jul 24 2016 14:23 UTC
thanks
Mario Behling
@mariobehling
Jul 24 2016 14:32 UTC
@niranjan94 also added two details about the public cfs option fossasia/open-event-orga-server#1835
Shivam Mamgain
@shivamMg
Jul 24 2016 14:48 UTC
@mariobehling @aditya1702 fossasia/open-event-orga-server#1829
please review
Mario Behling
@mariobehling
Jul 24 2016 15:06 UTC
@shivamMg Internal Server error after merge
Niranjan Rajendran
@niranjan94
Jul 24 2016 15:37 UTC
@mariobehling it's a migration error. Multiple heads. will fix it right away
Niranjan Rajendran
@niranjan94
Jul 24 2016 15:42 UTC
@mariobehling fixed.
click save -> still internal error
Mario Behling
@mariobehling
Jul 24 2016 16:17 UTC
@SaptakS @niranjan94 @aviaryan Could you check please?
Niranjan Rajendran
@niranjan94
Jul 24 2016 16:22 UTC
Checking
Multiple heads.
Fixing
Niranjan Rajendran
@niranjan94
Jul 24 2016 16:39 UTC
@mariobehling it has been fixed
Mario Behling
@mariobehling
Jul 24 2016 16:46 UTC
thank you!