These are chat archives for fossasia/open-event-server

27th
Jul 2016
Manan Wason
@mananwason
Jul 27 2016 00:53
Okay I'm sorry. I meant what @the-dagger said. So of anything changes the event_ver should change. Then we can just check if the event ver is didderenr, then make requests for other jsons
Shivam Mamgain
@shivamMg
Jul 27 2016 08:54
can someone help me with this, travis is taking ProductionConfig, while it should be using TestingConfig. I tried setting APP_CONFIG to "config.TestingConfig", both in the repo settings and by committing it to the repo (travis.yml).
Avi Aryan
@aviaryan
Jul 27 2016 13:45
@shivamMg It is not taking ProductionConfig. ProductionConfig code is ran automatically when the config module is imported. This is how Python works.. All static code (like the static vars in the config classes) are executed when the module is imported. Since that assert in ProductionConfig is in line of execution, it is executed and thus fails.
Shivam Mamgain
@shivamMg
Jul 27 2016 14:44
@aviaryan figured that later, I feel stupid :sob:
Shivam Mamgain
@shivamMg
Jul 27 2016 18:13
@niranjan94 fossasia/open-event-orga-server#1902
Niranjan Rajendran
@niranjan94
Jul 27 2016 18:15
:+1:
Avi Aryan
@aviaryan
Jul 27 2016 18:22
@/all what is the max no of characters in a line that we should keep for orga-server python code . 80 (pep8) , 120 or something else ?
Niranjan Rajendran
@niranjan94
Jul 27 2016 18:23
120 I think
I have been following 120
I feel 80 is too less . What do you think ?
Avi Aryan
@aviaryan
Jul 27 2016 18:34
yes. I too think 80 is less but I still try to follow it.
@SaptakS Is there a max line length setting in Codacy and Codeclimate ? I think we should follow that.