These are chat archives for fossasia/open-event-server

28th
Jul 2016
Saptak Sengupta
@SaptakS
Jul 28 2016 00:17
Yes.. There is already a max line length set in codacy.. I think its 150.
Saptak Sengupta
@SaptakS
Jul 28 2016 02:53

@rafalkowalski @aditya1702 @niranjan94 @aviaryan @shivamMg can you please have a look in this issue:fossasia/open-event-orga-server#1915

Event edit gives a 400 bad request in live system but works fine in my local system. The heroku log doesn't give any such error except for a 400 status. Can you please have a look?

Aditya Vyas
@aditya1702
Jul 28 2016 03:13
@SaptakS Sure
Avi Aryan
@aviaryan
Jul 28 2016 06:20
@SaptakS 150 is too high I think. We can reduce it to 100 or 120 if possible.
Saptak Sengupta
@SaptakS
Jul 28 2016 06:22
@aviaryan I agree but there are many of the sentences where reducing the line size was becoming difficult..
So I thought about 150..
Avi Aryan
@aviaryan
Jul 28 2016 06:24
regarding 400 error, here is the traceback.
2016-07-28T06:23:59.606046+00:00 app[web.1]: [u'slides', u'title', u'short_abstract', u'comments', u'position', u'short_biography', u'country', u'website', u'photo', u'organisation', u'name', u'twitter', u'email']
2016-07-28T06:23:59.842502+00:00 heroku[router]: at=info method=POST path="/events/24/edit/" host=open-event-dev.herokuapp.com request_id=d43ebb6f-924a-42aa-bf58-81625459503c fwd="14.194.238.52" dyno=web.1 connect=0ms service=270ms status=400 bytes=413
2016-07-28T06:24:00.202837+00:00 heroku[router]: at=info method=GET path="/socket.io/?EIO=3&transport=websocket&sid=29c7745633b04a4ebddec0afb226c5d5" host=open-event-dev.herokuapp.com request_id=e886a292-2310-4bbe-8ad1-4115ee579ba0 fwd="14.194.238.52" dyno=web.1 connect=0ms service=24029ms status=101 bytes=129
2016-07-28T06:24:00.205497+00:00 app[web.1]: [2016-07-28 06:24:00 +0000] [17] [ERROR] Error handling request /socket.io/?EIO=3&transport=websocket&sid=29c7745633b04a4ebddec0afb226c5d5
2016-07-28T06:24:00.205508+00:00 app[web.1]: Traceback (most recent call last):
2016-07-28T06:24:00.205516+00:00 app[web.1]:   File "/app/.heroku/python/lib/python2.7/site-packages/gunicorn/http/wsgi.py", line 315, in default_headers
2016-07-28T06:24:00.205516+00:00 app[web.1]:     elif self.should_close():
2016-07-28T06:24:06.814183+00:00 heroku[router]: at=error code=H12 desc="Request timeout" method=GET path="/socket.io/?EIO=3&transport=polling&t=LOmB2wK&sid=29c7745633b04a4ebddec0afb226c5d5" host=open-event-dev.herokuapp.com request_id=8ed56b91-f6e8-4403-9dc9-d4bbbb127429 fwd="14.194.238.52" dyno=web.1 connect=0ms service=30000ms status=503 bytes=0
Saptak Sengupta
@SaptakS
Jul 28 2016 06:25
Yes.. I saw this..
But this is a gunicorn server file error.. But if the server setup was wrong how did it work before?
And @aviaryan do you know how to fix this?
Avi Aryan
@aviaryan
Jul 28 2016 06:27
No. I am not sure about the socket.io in that either. It can have something to do with the error. Maybe @shivamMg will know.
[ERROR] Error handling request /socket.io/?EIO=3&transport=websocket&sid=29c7745633b04a4ebddec0afb226c5d5
Shivam Mamgain
@shivamMg
Jul 28 2016 07:23
is it your local installation. Make sure you have APP_CONFIG set as "config.DevelopmentConfig" there , vagrant or anything.
On heroku..
Shivam Mamgain
@shivamMg
Jul 28 2016 07:28
If it's regarding response status code not being recognized then it shouldn't be a problem miguelgrinberg/Flask-SocketIO#223
I'll check the logs it's something else. I'm not in my room right now
Shivam Mamgain
@shivamMg
Jul 28 2016 13:18
my previous commit broke the app, fixing it...
done
Shivam Mamgain
@shivamMg
Jul 28 2016 13:38
can't seem to find it in the logs anymore.
tried editing event, it seems to be working fine and without the mentioned error in the logs
Saptak Sengupta
@SaptakS
Jul 28 2016 16:34
Great... I will check and close the issue asap...
Saptak Sengupta
@SaptakS
Jul 28 2016 23:32
@aviaryan @aditya1702 @niranjan94 @rafalkowalski @shivamMg I just fixed this issue day before yesterday, and the code is broken again.. I am not sure which PR caused this but since its the same missing codes I would guess some just force pushed.. Please check a little before force pushing in case of conflicts..
Saptak Sengupta
@SaptakS
Jul 28 2016 23:59
Also, @mariobehling someone pointed out to me that in our README we have open-event.herokuapp.com instead of open-event-dev.herokuapp.com. Should we change that or keep it as it is?