These are chat archives for fossasia/open-event-server

29th
Jul 2016
Niranjan Rajendran
@niranjan94
Jul 29 2016 01:09
@SaptakS the repository is locked. Force push shouldn't be possible. Perhaps @mariobehling you could check the Github organization audit logs to see if anyone recently unlocked the repo. (I'm not sure if that info is part of the logs)
Saptak Sengupta
@SaptakS
Jul 29 2016 02:17
@shivamMg did you try it in the live system?
It still gives a 400 bad request in this:
http://open-event-dev.herokuapp.com/events/97/edit/
However it works in some events like:
http://open-event-dev.herokuapp.com/events/9/edit/
Niranjan Rajendran
@niranjan94
Jul 29 2016 02:22
What are the differences between those two events? What all parts of the steps are on and which all are off?
Saptak Sengupta
@SaptakS
Jul 29 2016 02:28
@aditya1702 I think this is an error because of your PR on ticketing URL.. How to include ticketing URL?
Because I can't see the option for that in either event create or event edit.. And in code I see a line
 {% if event.ticket_include or 'ticketing' in included_items %}
Aditya Vyas
@aditya1702
Jul 29 2016 03:45
This message was deleted
Saptak Sengupta
@SaptakS
Jul 29 2016 03:45
@aditya1702 fixed it..
Aditya Vyas
@aditya1702
Jul 29 2016 03:45
@SaptakS I had written the code for it
And I had included it in create as well as edit functions
Saptak Sengupta
@SaptakS
Jul 29 2016 03:46
You didn't put a check while saving whether the module was turned on... So it was saving event.tickets even when the module wasn't on..
Aditya Vyas
@aditya1702
Jul 29 2016 03:46
I put a check
Saptak Sengupta
@SaptakS
Jul 29 2016 03:46
Nopes.. Check my PR..
fossasia/open-event-orga-server#1930
Aditya Vyas
@aditya1702
Jul 29 2016 03:47
1.png
See this
Saptak Sengupta
@SaptakS
Jul 29 2016 03:48
This is in view... You didn't put a check in create_event() function in data.py..
as a result of which even though there is no switch present, but the edit event expects data..
Aditya Vyas
@aditya1702
Jul 29 2016 03:48
Oh
Saptak Sengupta
@SaptakS
Jul 29 2016 03:48
check my PR.. I think it will make clear what you did wrong..
Aditya Vyas
@aditya1702
Jul 29 2016 03:48
Ok got it
Thanks :)
Sorry for the trouble :sweat_smile:
Saptak Sengupta
@SaptakS
Jul 29 2016 03:57
Its cool.. :)
Shivam Mamgain
@shivamMg
Jul 29 2016 05:37
@SaptakS I checked the logs on the live system while editing event. It didn't show any such error then.
Saptak Sengupta
@SaptakS
Jul 29 2016 05:38
@shivamMg 400 error just shows bad request.. It doesn't show which field is missing that should have been submitted..
The backend expected ticket fields to be there.. But there wasn't.. So it gave bad request..
Shivam Mamgain
@shivamMg
Jul 29 2016 05:40
Thats more likely and not related to socket io . Ok I'm in class right now will come back and see.
Saptak Sengupta
@SaptakS
Jul 29 2016 05:40
That was the reason... See the conversation above..
It wasn't the problem of socket io..
Mario Behling
@mariobehling
Jul 29 2016 12:12
@aditya1702 fossasia/open-event-orga-server#1932 is not peer-reviewed and there should not be a standard ticket price. Unfortunately it has to be reverted therefore.
Aditya Vyas
@aditya1702
Jul 29 2016 12:42
@mariobehling although I have set a value to it, afterwards I added "required" field to it, which makes it impossible for the user to save it without setting his/her choice of price to it
Mario Behling
@mariobehling
Jul 29 2016 13:49
@aditya1702 There was not any info in your issue, no screenshot or description in your PR and you merged it yourself without peer-review. After working together for over two months full-time on this project it is sad to see, that you are still not following our workflow.
@aditya1702 Please provide the required info and make a new PR, that can be peer-reviewed.
Aditya Vyas
@aditya1702
Jul 29 2016 14:57
@mariobehling Yes. I wont repeat it again. I have added some screenshots regarding tax forms. Could you check please fossasia/open-event-orga-server#1924
Rafał Kowalski
@rafalkowalski
Jul 29 2016 21:36
@/all do you know how can i get more logs from heroku?