These are chat archives for fossasia/open-event-server

20th
Aug 2016
Shivam Mamgain
@shivamMg
Aug 20 2016 09:33
ok I read about it, SERVER_NAME must not be taken from the request. It is required in application context when request information is not possible. http://flask.pocoo.org/docs/0.11/config Taking it from the environment variable seems correct. I'll open an issue.
Mario Behling
@mariobehling
Aug 20 2016 11:45
@niranjan94 Regarding tests with the robotframework, what options are there to run tests on the heroku deployment and integrate it with selenium?
Niranjan Rajendran
@niranjan94
Aug 20 2016 11:46
The tests are already executed on Travis.
With selenium.
We already have a basic login test where the page is opened in firefox and the login page is tested
Niranjan Rajendran
@niranjan94
Aug 20 2016 11:52
@mariobehling
Mario Behling
@mariobehling
Aug 20 2016 12:39
ok, the documentation added is mainly about how to run on a local machine. what would be really interesting: a guide how to add new tests
then we could get gci students to write new tests
Niranjan Rajendran
@niranjan94
Aug 20 2016 12:40
@mariobehling That's a wonderful idea ... I'll add a documentation on that and add tasks to the GCI spreadsheet too
Mario Behling
@mariobehling
Aug 20 2016 12:44
:+1:
@obnoxious23 had the idea with the robotframework and is also looking at test cases. So, I think this could save us a lot of time. Until now we often had some features implemented and they initially work, but as other parts of the system are changing some functions stop working. We need to ensure this does not happen as we progress and move to production.
Mario Behling
@mariobehling
Aug 20 2016 12:53
@niranjan94 after the last merges, it seems like the events disappeared
Niranjan Rajendran
@niranjan94
Aug 20 2016 12:53
Hold on .... I'll check
Mario Behling
@mariobehling
Aug 20 2016 12:53
actually the events are still there, but they dont show up in the event and admin dashboards
Niranjan Rajendran
@niranjan94
Aug 20 2016 12:54
Found it. Made a small error in the query. Will fix in a min
Sorry about that ...
Mario Behling
@mariobehling
Aug 20 2016 12:58
:+1:
Niranjan Rajendran
@niranjan94
Aug 20 2016 12:58
Fixed fossasia/open-event-orga-server#2322
Mario Behling
@mariobehling
Aug 20 2016 13:20
thanks. working again.
Mario Behling
@mariobehling
Aug 20 2016 13:43
@shivamMg Could you please have a look here on this issue. Not sure, why it got closed, but we are still away from a similar implementation fossasia/open-event-orga-server#1862
Shivam Mamgain
@shivamMg
Aug 20 2016 14:41
ok, i'll make ui close to the eventbrite implementation
Mario Behling
@mariobehling
Aug 20 2016 14:49
@shivamMg Unfortunately we are not the first ones building a system like that. In order to make it easier for people to use Open Event it would be good to stick in some main features to the existing industry standards.
Mario Behling
@mariobehling
Aug 20 2016 15:08
@SaptakS I am not sure, if you understood all areas involved to get the image implementation working. You are already working on this for a few weeks and this is a blocker for release. Having images that are several MB big is not suitable for a live system. I added some information and outlined details for the image system in additional issues in order to help all of us understand better. Unfortunately no-one of us can help you with Internet issues though and you need to find a solution yourself. Please help to speed things up and solve the image topic, so we can make the first release next week hopefully.
Saptak Sengupta
@SaptakS
Aug 20 2016 15:11
Yes sure.. I will try to get it done tonight... I have already implemented resizing codes and storing the options...
I just need to integrate both...
Will try to get it done tonight...