These are chat archives for fossasia/open-event-server

31st
Jan 2017
Rafał Kowalski
@rafalkowalski
Jan 31 2017 07:26
@SaptakS on this stage of project Ui and unittests are required, so pull requests without tests shouldn't be merged. I know that testing is boring but to increase code quality it's necessary
Saptak Sengupta
@SaptakS
Jan 31 2017 07:28
@rafalkowalski I do agree with you. But there are sometimes high-priority issues that need to be merged as soon as possible so we avoid unittest. Also there are many parts where unittests need to be written which is pending. But you are right. We should prefer that people send pull requests with unittests to avoid breaking of solved stuff and features
Rafał Kowalski
@rafalkowalski
Jan 31 2017 07:33
It's not good to merge high piority tasks if they dont have tests. More Bugs will be created.
Saptak Sengupta
@SaptakS
Jan 31 2017 07:35
:+1:
Rafał Kowalski
@rafalkowalski
Jan 31 2017 07:37
IF we will have tests we are able to predict the result of tests
Saptak Sengupta
@SaptakS
Jan 31 2017 07:39
@rafalkowalski I understand what you are saying... One of the biggest problems is we don't have enough unittests for the already prevailing code... And sometimes it becomes emergency to change some codes immediately as eventyay is now being used in production for FOSSASIA 2017 summit. That time it might not be always feasible to write unittests...
But I do agree with you...
In fact there is an issue open for writing unittests for all the parts, as there are not many sufficient unittests written to verify whether the system works...
I will start working on that myself soon..
Mario Behling
@mariobehling
Jan 31 2017 08:14
@rafalkowalski Yes, we need to get the system running for the event. There are a number of areas where we cannot wait a few weeks before they are fixed. So, it is a bit risky if there are no unit tests, but looks like we do not always have a choice and we need to push ahead a bit and get tests implemented afterwards.