These are chat archives for fossasia/open-event-server

17th
May 2017
Saptak Sengupta
@SaptakS
May 17 2017 00:59
@mariobehling I tried doing login and then adding speaker details and then submitting session. Also I tried signing up as a completely new user and then adding speaker details and then submitting session in the eventyay deployment itself. You can check the sessions here: https://eventyay.com/events/184/sessions/
@niranjan94 @magdalenesuo @shubham-padia can you please check if you people get any error?
From my side I am unable to reproduce any error.
@mariobehling can you ask someone who has faced this error to document the steps to reproduce the error in an issue so that we can fix it?
Mario Behling
@mariobehling
May 17 2017 04:52
I have faced this error.
@SaptakS There is an event worse bug now: The tickets people order show the name of another person.
This is really urgent.
Pretty bad we now have these bugs.
fossasia/open-event-orga-server#3601
Mario Behling
@mariobehling
May 17 2017 04:58
@shubham-padia @magdalenesuo @enigmaeth @poush @LuD1161 @niranjan94 Who can help?
It means we don't have a proper ticketing at the moment.
Medo
@magdalenesuo
May 17 2017 08:11
@mariobehling done
Mario Behling
@mariobehling
May 17 2017 09:04
ok cool
@SaptakS @shubham-padia Can we and deploy it to the live server?
Hope there are no other bugs in the recent commits
Mario Behling
@mariobehling
May 17 2017 11:36
@magdalenesuo Good job. What about the QR code? Seems to be identical for different tickets in one order
Saptak Sengupta
@SaptakS
May 17 2017 11:37
@mariobehling merging the PR for QR code fix sent by @magdalenesuo . Will push to master after that.
Saptak Sengupta
@SaptakS
May 17 2017 11:43
fossasia/open-event-orga-server#3605
@mariobehling merging to master
Mario Behling
@mariobehling
May 17 2017 11:51
very good
Saptak Sengupta
@SaptakS
May 17 2017 11:53
all credit to @magdalenesuo @shubham-padia
@mariobehling pushed to master... Should be deployed in some minutes...
Shubham Padia
@shubham-padia
May 17 2017 12:09
@niranjan94 Can you please have a look at https://github.com/fossasia/open-event-orga-server/issues/3299#issuecomment-301812954 and provide your opinions.
Amol Mejari
@mejariamol
May 17 2017 12:50
@shubham-padia @SaptakS @magdalenesuo please take a look at this PR's travis build error. https://github.com/fossasia/open-event-orga-server/pull/3580#issuecomment-302065280
Mario Behling
@mariobehling
May 17 2017 13:14
Good job!
Niranjan Rajendran
@niranjan94
May 17 2017 13:56
@shubham-padia will check in sometimes.
Shubham Padia
@shubham-padia
May 17 2017 13:57
Thanks !!
Niranjan Rajendran
@niranjan94
May 17 2017 13:59

@SaptakS @LuD1161 @magdalenesuo @enigmaeth @poush @shubham-padia from now-onwards, every time you make a PR to the orga-sever repo, you'll see a checklist pre-filled in the PR description box along with a few placeholders.

  • Ensure you go through them all and fill in the necessary details.
  • Don't make a PR unless all the items of the checklist are checked.

This will make reviews much faster and easier.

Shubham Padia
@shubham-padia
May 17 2017 13:59
:+1:
Saptak Sengupta
@SaptakS
May 17 2017 13:59
@niranjan94 this was really really necessary. I guess you have done the same for the issues as well?? This should help in reviewing a lot
Niranjan Rajendran
@niranjan94
May 17 2017 14:00
Yep. Has been done for issues too.
Medo
@magdalenesuo
May 17 2017 14:19
:+1:
Shubham Padia
@shubham-padia
May 17 2017 14:30
I had a small query, In helpers.py:L438, the import has been made inside the function definition. Importing it at the start of the file gives an import error (most probably circular dependency). I was wondering how putting it this way avoids the error. Anybody know the reason behind this ?
Piyush Agrawal
@poush
May 17 2017 14:43
👍
Saptak Sengupta
@SaptakS
May 17 2017 15:04
So @shubham-padia what happens is this particular function doesn't have a dependency on that particular function of task module. So it can import that particular function of task. But if we do the same think outside, the entire file actually has a circular dependency on the task file.
This answer might help you to understand it better
Shubham Padia
@shubham-padia
May 17 2017 15:04
Cool !! Thanks !!
Saptak Sengupta
@SaptakS
May 17 2017 15:05
@shubham-padia :+1:
Afroz Ahamad
@enigmaeth
May 17 2017 15:20
In admin account, under settings what should microservices offer?
It displays the same settings for payment gateways.
Afroz Ahamad
@enigmaeth
May 17 2017 15:37
Is it a bug?
Mahika Wason
@mahikaw
May 17 2017 20:01
Hi, I have been trying to setup the app generator but I'm continuously facing this error:-
File "/usr/local/lib/python2.7/dist-packages/flask/json.py", line 22, in <module>
from itsdangerous import json as _json
ImportError: cannot import name json
Also, I get the exact same error when I try to install server. Any help will be great. Thanks.
Mario Behling
@mariobehling
May 17 2017 21:34
@mahikaw Please follow up on the dedicated channels for the web or Android app generator.