These are chat archives for fossasia/open-event-server

24th
May 2017
Aseem Shrey
@LuD1161
May 24 2017 01:00
@mariobehling :+1:
Saptak Sengupta
@SaptakS
May 24 2017 05:12
Can anyone please review fossasia/open-event-orga-server#3649 and tell me what am I doing wrong? I am unable to figure out and opening the task url that I am printing from browser gives a 500 internal server error. Though I see no error in celery log. @niranjan94 help?
Nguyễn Hồng Quân
@hongquan
May 24 2017 06:17
Hi, I have suggestion about how to maintain environment variables: fossasia/open-event-orga-server#3651
Niranjan Rajendran
@niranjan94
May 24 2017 06:22
@hongquan good idea ... :) thanks
@SaptakS have added a comment and sent a DM
Nguyễn Hồng Quân
@hongquan
May 24 2017 06:47
@SaptakS I've just explained what you did wrong with Celery in that PR.
Mario Behling
@mariobehling
May 24 2017 06:48
@SaptakS @SaptakS We need a print-out schedule for the OpenTechSummit. Not possible to get it right now: fossasia/open-event-orga-server#3615
Mario Behling
@mariobehling
May 24 2017 07:04
@shubham-padia @magdalenesuo
Piyush Agrawal
@poush
May 24 2017 07:35
Can anyone please provide suggestions on #3629? . Please read the first comment on the PR.
Saptak Sengupta
@SaptakS
May 24 2017 07:41
@niranjan94 @hongquan thanks for your comments...
Niranjan Rajendran
@niranjan94
May 24 2017 08:14
@enigmaeth also please add it to the spreadsheet shared by mario
Afroz Ahamad
@enigmaeth
May 24 2017 08:20
Added
I have added Week 2's too (It was deleted previously). Please review both. Thanks.
Mario Behling
@mariobehling
May 24 2017 08:29
@niranjan94 Who can take care of the print out schedule?
Niranjan Rajendran
@niranjan94
May 24 2017 08:30
@mariobehling @SaptakS has self-assigned it to himself just now. So he'll be doing it
Saptak Sengupta
@SaptakS
May 24 2017 08:30
@niranjan94 @mariobehling I will start working on it as soon as I complete the export csv work...
Mario Behling
@mariobehling
May 24 2017 08:33
thanks
Nguyễn Hồng Quân
@hongquan
May 24 2017 09:42
@poush Replied you in #3629 .
Nguyễn Hồng Quân
@hongquan
May 24 2017 09:57

Guys, there are some problems about coding that I found in recent PRs.

  1. You are importing Flask plugins by flask.ext. Stop doing so. This way is deprecated. Just import original module name, like from flask_scrypt import generate_password_hash.

  2. Your use of python-requests is weird:

        response = instagram.get(
            'https://api.instagram.com/v1/users/self/media/recent/?access_token=' + token.get('access_token',
'')).json()

Please use the API get(url, params), where url is just base URL without query string, params is the dict of queries. The above code should be written as:

url = 'https://api.instagram.com/v1/users/self/media/recent/'
params = {'access_token': token.get('access_token', '')}

try:
    response = instagram.get(url, params=params)
except HttpError:
    # Do something. Try to log error for easy debug later.
    return

if response.ok:
    data = response.json()
else:
    # Do something. Try to log error for easy debug later. 
    return
Mario Behling
@mariobehling
May 24 2017 13:12
@SaptakS Any update on the printable schedule?
Saptak Sengupta
@SaptakS
May 24 2017 13:13
@mariobehling I was solving another issue... I will start looking into it right now...
Mario Behling
@mariobehling
May 24 2017 13:14
People are calling me by phone now for this. It was solved long ago and the bug is back.
Saptak Sengupta
@SaptakS
May 24 2017 13:14
Ok... I am checking right away.
Yes I remember I myself solved it.
Cecking
Saptak Sengupta
@SaptakS
May 24 2017 17:42
@mariobehling fossasia/open-event-orga-server#3660
done
Mario Behling
@mariobehling
May 24 2017 17:45
ok, thanks.
Saptak Sengupta
@SaptakS
May 24 2017 17:45
Once reviewed and travis passes I will merge to master
Mario Behling
@mariobehling
May 24 2017 17:45
Can we deploy this to master? Is there any potential issue?
Saptak Sengupta
@SaptakS
May 24 2017 17:46
Yes it can be deployed to master
In fact there have been other important changes as well like adding session and speaker state in API. those will also get deployed.
Mario Behling
@mariobehling
May 24 2017 18:55
@SaptakS I cannot access the event dashboard anymore
Screenshot from 2017-05-24 20-55-39.png
Niranjan Rajendran
@niranjan94
May 24 2017 18:58
@mariobehling checking.
Saptak Sengupta
@SaptakS
May 24 2017 18:58
@mariobehling checking
Niranjan Rajendran
@niranjan94
May 24 2017 19:02
@mariobehling we found the issue. It's due to the new ticket stats widget on the dashboard. We're fixing it.
Mario Behling
@mariobehling
May 24 2017 19:02
thanks
Saptak Sengupta
@SaptakS
May 24 2017 19:03
@mariobehling will fix this ASAP
Mario Behling
@mariobehling
May 24 2017 19:03
:+1:
Saptak Sengupta
@SaptakS
May 24 2017 20:23
@mariobehling fixed
It is working now... You can check and let me know
Mario Behling
@mariobehling
May 24 2017 20:41
Very good job!
Thank you
Saptak Sengupta
@SaptakS
May 24 2017 20:43
:+1:
Mario Behling
@mariobehling
May 24 2017 21:14
Export of attendees is not working.
"We seem to be having some issues on our side."