These are chat archives for fossasia/open-event-server

15th
Jun 2017
Niranjan Rajendran
@niranjan94
Jun 15 2017 04:51
@mejariamol commented.
Mario Behling
@mariobehling
Jun 15 2017 13:24
@LuD1161 @magdalenesuo @SaptakS @enigmaeth @poush @shubham-padia We are approaching the first evaluations soon. It is great to see your continuous contributions to the project. To pass the evaluations please ensure you have followed the guidelines and submitted all that is required. Most importantly ensure you have substantial daily quality code contributions. Regarding the blog posts. Many of you see already feedback of different mentors on the posts. Please ensure your posts are up to expectations and continue to share them on the Google doc on time. Submission to the FOSSASIA blog will happen step by step. Please help to increase the speed by peer-reviewing posts (just as we do it with code). We are at the moment going through the work of students and will get back to you, if there are questions.
Mario Behling
@mariobehling
Jun 15 2017 13:36
@LuD1161 I got feedback from different mentors already who reviewed your contributions and unfortunately they have been very low. In order to pass the first evaluations, we would need to see a steep increase in quality commits now and I am not sure, if that would be possible. We saw a number of PRs from you, that are of low quality. For example the fossasia/open-event-orga-server#3708 PR was open for 11 days and that PR had about 190 comments before it was mergable. Finally the scope of the PR had to be reduced to the bare minimum to get it merged more quickly. We had hoped you contribute to the project during GSoC and we can progress faster with you, but I am seeing that it actually takes a lot of resources to bring your PRs up to expectations. Your Scrums also show not much more than things like 'Get the PR merged. Do changes to PR.'. You only submitted one blog post so far. Or am I missing something? At the beginning of GSoC you promised to follow the guidelines, make substantial daily code commits and contribute to bring this project forward. I am sad that it looks like you are not keeping your promise. We want every student to pass, but I don't know how you plan to pass the first evaluations. What do you want to tell your co-developers and mentors now?
Aseem Shrey
@LuD1161
Jun 15 2017 17:35
@mariobehling
Sorry if I haven't been able to be upto the expectations.
I will try to make up for it from now on.
However I can assure you I had tried hard , but was facing difficulties in the project .
Mario Behling
@mariobehling
Jun 15 2017 17:58
@LuD1161 Sounds good. I hope you can fulfill the expectations in the project. It took you a long time to respond to the message here as well. We are happy to help, but when there are so many comments necessary in your PRs something is wrong. As Hong Phuc mentioned to you before GSoC, please do not regard co-developers and mentors as your private teachers. We don't have resources to be substitutes for teachers or tutors in your university and as a student of the program you are expected to submit quality code daily. Please use online channels e.g. slack etc. to get your quality up as well.
@LuD1161 Have you submitted code today?
Aseem Shrey
@LuD1161
Jun 15 2017 18:02
No
Mario Behling
@mariobehling
Jun 15 2017 18:03
Hm. Hope we will see a good code commit tomorrow then.
Aseem Shrey
@LuD1161
Jun 15 2017 18:04
I am working on it currently on fossasia/open-event-orga-server#3771
Mario Behling
@mariobehling
Jun 15 2017 18:04
Ok, great. Hope to see code now. We need to see quality code.
Aseem Shrey
@LuD1161
Jun 15 2017 18:05
Ok
Mario Behling
@mariobehling
Jun 15 2017 18:05
I am also wondering how you will submit your missing blog posts in good quality until the evaluation. Well, I leave it to you.
Mario Behling
@mariobehling
Jun 15 2017 21:10
@enigmaeth Looking at your contributions we also see that you are very low on contributions too and some commits are very simple. You are not following the program guidelines as promised. What is your plan now?