These are chat archives for fossasia/open-event-server

18th
Jun 2017
Avi Aryan
@aviaryan
Jun 18 2017 04:22
@LuD1161 Nice blog post. Good content. However, I see some grammatical and semantic issues. You can use the free tool grammarly to view and fix them.
Aseem Shrey
@LuD1161
Jun 18 2017 05:04
@aviaryan Thanks a lot :smile:
Shailesh Baldaniya
@Shailesh351
Jun 18 2017 07:03
@niranjan94 Attribute keys in some model are not matching from https://github.com/fossasia/open-event/wiki/%5BNextgen%5D-Open-Event-Universal-Format-Specification and https://api.eventyay.com. Please have a look. What attribute keys we should use for jsonapi client for android app ?
example In session model Open-Event-Universal-Format has video attribute and in nextGen api it is video-url.
Areeb Jamal
@iamareebjamal
Jun 18 2017 07:06
Yes, attributes will change, that's why we'll write annotation processor to match these @Shailesh351
Shailesh Baldaniya
@Shailesh351
Jun 18 2017 07:08
Okay :+1: But still it will be good and helpful to have same attribute key everywhere.
Areeb Jamal
@iamareebjamal
Jun 18 2017 07:09
It is defined according to JSONAPI specs as previous API had inconsistent naming schemes, so that won't be possible always
Saptak Sengupta
@SaptakS
Jun 18 2017 08:00
@shubham-padia @magdalenesuo @LuD1161 @enigmaeth @poush I think we should all add the necessary docs as well to the api blueprint whenever we are making any changes in the API or adding new API endpoints. That way it will help in maintaining a good documentation rather than leaving it for later. @niranjan94 what do you think?
Shubham Padia
@shubham-padia
Jun 18 2017 08:08
@SaptakS Great idea :smile:
Saptak Sengupta
@SaptakS
Jun 18 2017 08:13
Once we have the unittests and integration tests, I think we should follow the same flow there as well.
Mario Behling
@mariobehling
Jun 18 2017 08:14
:+1:
Aseem Shrey
@LuD1161
Jun 18 2017 08:26
:+1:
Afroz Ahamad
@enigmaeth
Jun 18 2017 10:03
:+1:
Afroz Ahamad
@enigmaeth
Jun 18 2017 10:15
@LuD1161 Added comments to the blog post. Please check.
Afroz Ahamad
@enigmaeth
Jun 18 2017 10:22
What are you using to add code in Google Docs? I am using Code-Pretty addon, not very good but sort of does the job. Anything else someone uses which works well?
Aseem Shrey
@LuD1161
Jun 18 2017 10:28
I didn't use any plugin just formatting and format copying to all the code snippets :smile:
Afroz Ahamad
@enigmaeth
Jun 18 2017 10:28
:+1:
Niranjan Rajendran
@niranjan94
Jun 18 2017 14:58
@Shailesh351 thanks for pointing that out ... Both of the docs are currently WIP. Both will change.
And in 99% of the cases, the keys of the Open Event Universal format will be the same as the json-api ...