These are chat archives for fossasia/open-event-server

27th
Jun 2017
Afroz Ahamad
@enigmaeth
Jun 27 2017 09:55
@poush @magdalenesuo @SaptakS @LuD1161 Has anyone of you started with dredd testing? It takes a lot of time on my local run( ~20 minutes for one run) . @shubham-padia has it done in 7-8 mins. On Travis CI in 2 minutes. So just wanted to ask what time are you guys getting?
Shubham Padia
@shubham-padia
Jun 27 2017 11:18
Afroz Ahamad
@enigmaeth
Jun 27 2017 11:19
I ran one other test on travis: 01 min 21 sec.
I compared local and CI tests: for some request travis time is 71 ms, while local run time is 800 ms
Shubham Padia
@shubham-padia
Jun 27 2017 11:20
:+1:
Afroz Ahamad
@enigmaeth
Jun 27 2017 11:45
Please review fossasia/open-event-orga-server#3884 !
Mario Behling
@mariobehling
Jun 27 2017 18:24
Students who are already published their blog post on the FOSSASIA blog, please add the link to your post into the spreadsheet.
Mario Behling
@mariobehling
Jun 27 2017 18:37
@LuD1161 Please ensure you have 3 quality blog posts linked on the spreadsheet. So mentors can evaluate your contributions in all areas for the evaluations.
Aseem Shrey
@LuD1161
Jun 27 2017 18:38
Sure :+1:
Aseem Shrey
@LuD1161
Jun 27 2017 19:04
@mariobehling
My second blog post has been reviewed by one of the mentors but hasn't been published as there hasn't been any review on the spreadsheet. Can you review that ?
Mario Behling
@mariobehling
Jun 27 2017 19:04
@LuD1161 Please see my comment in your second blog post. Does not seem to be from you entirely and the subject is not related to your work at FOSSASIA. It is not even mentioning your project and does not reference how you solved a project in this area.
@LuD1161 Which mentor reviewed it? I don't see comments on the post and neither on the spreadsheet.
Aseem Shrey
@LuD1161
Jun 27 2017 19:05
Avi aryan had reviewed it when I posted the link here and suggested some grammatical changes
Mario Behling
@mariobehling
Jun 27 2017 19:06
Ok, thank you. I will talk to him and let him know the issues with your post.
Aseem Shrey
@LuD1161
Jun 27 2017 19:07
:+1:
Shubham Padia
@shubham-padia
Jun 27 2017 19:13
@magdalenesuo @SaptakS @enigmaeth @poush @LuD1161 Please update your api-frameworks due to solution of issue #3889 and merging of new release of framework upstream.
Mario Behling
@mariobehling
Jun 27 2017 19:13
@LuD1161 Reformulating the alembic documentation does not make a suitable blog post and I am sad to see that you are still not able to follow the guidelines and provide something that is up to expectations. @aviaryan might have reviewed some parts of this post, but it is nowhere marked as acceptable and indeed it is not acceptable.
Saptak Sengupta
@SaptakS
Jun 27 2017 19:16
@shubham-padia congrats on the upstream contribution. Btw wasn't this already implemented in your local repository?
Aseem Shrey
@LuD1161
Jun 27 2017 19:17
@mariobehling sorry , if it looks so , but some of the documentation part was needed to properly explain the rest of the migration script discussed in the blog
I was trying to explain how to manually make migrations and why is it important
Mario Behling
@mariobehling
Jun 27 2017 19:19
@LuD1161 Your behavior is unfair compared to other students who contribute much more code than you and write genuine blog posts.
Aseem Shrey
@LuD1161
Jun 27 2017 19:20
@mariobehling I do understand that , I have contributed less . But I am trying to come upto the expectations . As far as the blog posts , those are genuine.
Mario Behling
@mariobehling
Jun 27 2017 19:23
@LuD1161 I am just one voice and a number of mentors will look over this and evaluate everything.
Aseem Shrey
@LuD1161
Jun 27 2017 19:23
:+1:
Shubham Padia
@shubham-padia
Jun 27 2017 19:25

Btw wasn't this already implemented in your local repository?

@SaptakS Yeah, it was.It was accepted in upstream as it was a general bug and not specific to our project.

Saptak Sengupta
@SaptakS
Jun 27 2017 19:28
I mean, since we all are using your repository in our dependency, do we need to update?
Shubham Padia
@shubham-padia
Jun 27 2017 19:29
Yeah, #3889 was also fixed today, so you need an update for that.
Dasherized attributes were not being sorted :)
Saptak Sengupta
@SaptakS
Jun 27 2017 19:29
ok cool then
Aseem Shrey
@LuD1161
Jun 27 2017 19:35
@mariobehling
I have added a link to the PR and explaining the cause of the same in the blog post
Afroz Ahamad
@enigmaeth
Jun 27 2017 19:54

Yeah, #3889 was also fixed today, so you need an update for that.
Dasherized attributes were not being sorted :)

Cool :+1: