These are chat archives for fossasia/open-event-server

21st
Jul 2017
Niranjan Rajendran
@niranjan94
Jul 21 2017 02:24
@iamareebjamal PATCH should allow clients to skip attributes.
@harshitagupta30 your relationship payload is incorrect. Please see the docs properly.
Areeb Jamal
@iamareebjamal
Jul 21 2017 03:50
Yes, but PATCH for event is not working if I skip the timezone attribute
Niranjan Rajendran
@niranjan94
Jul 21 2017 04:42
Okay.. @iamareebjamal could you open an issue on the server repo?
Areeb Jamal
@iamareebjamal
Jul 21 2017 04:42
The DELETE request for ticket takes up to 5 sec and then return 404 but successfully delete a ticket
Doing so
Niranjan Rajendran
@niranjan94
Jul 21 2017 05:15

@iamareebjamal the delay is due to running on heroku free plan. Consecutive requests would be fast. (This because heroku free plan suspends unused instances for a while and starts them up only when a request comes in).

But for 404, open an issue.

Areeb Jamal
@iamareebjamal
Jul 21 2017 05:16
All other requests are much faster than this, so it looked like an issue. I have opened one for the 404 response
Areeb Jamal
@iamareebjamal
Jul 21 2017 05:54
Guys, I can't change the checked in status of attendee, all other fields are changing
Niranjan Rajendran
@niranjan94
Jul 21 2017 05:55
@iamareebjamal open an issue please.
With URL, Request + payload and response + status code.
Areeb Jamal
@iamareebjamal
Jul 21 2017 05:55
I thought to confirm 1st :+1:
Afroz Ahamad
@enigmaeth
Jul 21 2017 06:21
Sumedh Nimkarde
@lunaticmonk
Jul 21 2017 07:38
@shubham-padia I am trying to update the user info of 'email', 'phone' by sending a patch request at 'https://open-event-api.herokuapp.com/users/<user_id>' but it's giving me 'Unknown error'. I also tried to send it by postman with the same access token so that I can override the info, still I am getting the same error. Following are the screenshots:
patch.png
patch2.png
Niranjan Rajendran
@niranjan94
Jul 21 2017 07:39
@sumedh123 please open an issue on the server repo With URL, Request + payload and response + status code.
Sumedh Nimkarde
@lunaticmonk
Jul 21 2017 07:40
:thumbsup:
Harshita Gupta
@harshitagupta30
Jul 21 2017 10:29
@niranjan94 Thanks for the doc link but I am still getting the same response even on changing relationships according to doc.
Payload:
{
  "data": {
    "attributes": {
      "name": "Fossasia",
      "description": "Fossasia",
      "logo-url": "http://2017.fossasia.org/img/fossasia-square-300dpi.png",
      "url": "http://fossasia.org",
      "level": "1",
      "type": "Gold"
    },
    "type": "sponsor",
    "relationships": {
      "event": {
        "data": {
          "type": "event",
          "id": "105"
       }
     }
    }
  }
}
I have tried this thing as well:
 "relationships": {
      "event": {
        "data": {
          "type": "event",
          "id": "be494ae0"
       }
     }
    }
but getting the same response:
{
    "jsonapi": {
        "version": "1.0"
    },
    "errors": [
        {
            "detail": "Access forbidden",
            "status": 403,
            "source": {
                "source": ""
            },
            "title": "Access Forbidden"
        }
    ]
}
Shubham Padia
@shubham-padia
Jul 21 2017 10:33
Wait for #4117 to be closed
It will be fixed the
*then
@niranjan94 did you not notify frontend guys about #4101 and the refactor ?????
Shubham Padia
@shubham-padia
Jul 21 2017 10:52
@magdalenesuo @poush
Try to help out on the channel too
Niranjan Rajendran
@niranjan94
Jul 21 2017 11:19
@shubham-padia we have multiple clients apps that will be consuming the API. One person cannot notify each channel personally. Like I said in the first intro call we had, its upto each developer to follow what is going on in the projects that their projects depend on. In this case, its upto the developers of the frontend project to follow such conversations on the server project. These conversations anyway happen in public channels such as issues, PRs and SCRUMs.
Shubham Padia
@shubham-padia
Jul 21 2017 11:19
:+1:
Niranjan Rajendran
@niranjan94
Jul 21 2017 12:37

@shubham-padia @SaptakS @magdalenesuo @poush @enigmaeth we have 10 PRs open. Could all of you pause working on other issues and help review and get the PRs merged asap ?

https://github.com/fossasia/open-event-orga-server/pulls

Afroz Ahamad
@enigmaeth
Jul 21 2017 12:37
:+1:
Piyush Agrawal
@poush
Jul 21 2017 12:38
:+1:
Shubham Padia
@shubham-padia
Jul 21 2017 12:53
:+1:
Niranjan Rajendran
@niranjan94
Jul 21 2017 14:05

Resharing from fossasia/open-event channel

There has been a lot of confusion lately regarding permissions and what each resource in Open Event means. Especially for new developers, its really hard to understand certain parts of the project. We don't have proper documentation to most of the business logic in the application and all these discussions have taken place in some remote PRs or issue many months ago. Its difficult to track them down too.

So, I have created a Dev Handbook for the open event project. Located at https://github.com/fossasia/open-event/tree/master/dev-handbook. Currently it has information about all (most) resources and their permissions/access limitations.

From now-onwards, any change to the business logic, will be made as a PR to the dev-handbook. And that PR will be linked to the issue on the server, or app where that logic needs to be implemented in code. That way, we can keep track of all changes in one place and at the same time, on-boarding process for new-contributors is much easier.

The dev handbook is far from complete. But its a start.

Piyush Agrawal
@poush
Jul 21 2017 14:06
Great :+1:
Shubham Padia
@shubham-padia
Jul 21 2017 14:06
Cool :+1:
Niranjan Rajendran
@niranjan94
Jul 21 2017 14:08

@shubham-padia @SaptakS @magdalenesuo @poush @enigmaeth please go through it. As of the now, It primarily concerns the API and permissions. Let me know if something isn't clear.

Implementing the permission requirements stated there will be the primary target for the upcoming milestone.

Afroz Ahamad
@enigmaeth
Jul 21 2017 14:35
:+1: