These are chat archives for fossasia/open-event-server

28th
May 2018
Bhavesh Anand
@bhaveshAn
May 28 2018 17:33
@schedutron @poush @maxlorenz If the PR seems too big to review, so may I split it up in two or three ?
@mariobehling Thoughts please.
fossasia/open-event-server#4803
Saurav Tiwary
@srv-twry
May 28 2018 17:57
I have defined a one-one relationship between an event and StripeAuthorization in PR fossasia/open-event-server#4807
Now when i create an event i.e. a POST request, it returns the relationship links for the Stripe authorization as expected. Now when i make a get request for the details of the same event, the relationship links for the Stripe Authorization is missing. Can anyone guess what could be wrong ?
image.png
^ POST request has the link but GET request for the same event later doesn't have it.
Mario Behling
@mariobehling
May 28 2018 18:22
@maxlorenz Following up on our discussion in the meeting, do you have input on this issue about ORM's? fossasia/open-event-server#4695
Saurav Tiwary
@srv-twry
May 28 2018 18:46

I have defined a one-one relationship between an event and StripeAuthorization in PR fossasia/open-event-server#4807
Now when i create an event i.e. a POST request, it returns the relationship links for the Stripe authorization as expected. Now when i make a get request for the details of the same event, the relationship links for the Stripe Authorization is missing. Can anyone guess what could be wrong ?
image.png
^ POST request has the link but GET request for the same event later doesn't have it.

Solved!

Max Lorenz
@maxlorenz
May 28 2018 19:58
@mariobehling yes I do, will answer there
Bhavesh Anand
@bhaveshAn
May 28 2018 20:03
@schedutron @maxlorenz If the PR seems too big to review, so may I split it up in two or three ?
Input please ??
fossasia/open-event-server#4803
Saurav Tiwary
@srv-twry
May 28 2018 20:04
Even though you haven't asked me but I think 131 lines isn't too big a PR to review. Just my thought
Bhavesh Anand
@bhaveshAn
May 28 2018 20:05
:+1: Yes I saw your review. that's why haven't asked. Asking others ...
Max Lorenz
@maxlorenz
May 28 2018 20:08
@bhaveshAn looks okay to me. A bit long but not unreasonable
Bhavesh Anand
@bhaveshAn
May 28 2018 20:09
:+1:
Bhavesh Anand
@bhaveshAn
May 28 2018 20:14
@mariobehling These PRs have been approved, can we merge it. Also can I get the merge rights for the server repo to speed up the merge process ? fossasia/open-event-server#4814 fossasia/open-event-server#4806 fossasia/open-event-server#4779 fossasia/open-event-server#4801 fossasia/open-event-server#4728
Mario Behling
@mariobehling
May 28 2018 20:21
@bhaveshAn Thanks. I gave you merge rights, but please don't merge your own commits. There should be two reviews and the third person who approves can merge it.
Bhavesh Anand
@bhaveshAn
May 28 2018 20:21
Okay !